My favorites | Sign in
Logo
             
New issue | Search
for
| Advanced search | Search tips
Issue 3315: regression: encoding override does not work
3 people starred this issue and may be notified of changes. Back to list
 
Reported by jshin@chromium.org, Oct 10, 2008
In 0.3.15[34].0, encoding override does not work any more. 

It may or may not be a regression due to webkit merge. I'll figure out when
this regressed  by trying builds at 

http://build.chromium.org/buildbot/continuous/
Comment 1 by xlyuan@chromium.org, Oct 13, 2008
Reproduce on 0.3.155.0 (Developer Build 3281)

I get the build from http://build.chromium.org/buildbot/snapshots/chromium-rel-xp/
Comment 2 by xlyuan@chromium.org, Oct 14, 2008
Start broken from 0.3.154.0 (Developer Build 2613), OK on 0.3.154.0 (Developer Build
2600).

You can get this build from:
http://build.chromium.org/buildbot/continuous/09-25-2008/
Comment 3 by xlyuan@chromium.org, Oct 14, 2008
Encoding "Auto detect" doesn't work either.
Comment 4 by jshin@chromium.org, Oct 16, 2008
Thanks a lot for narrowing down the range. 
I think r2612 is a culprit. ( http://codereview.chromium.org/4088 ) 



Labels: Mstone-1.0
Comment 5 by jshin@chromium.org, Oct 17, 2008
It turned out that http://codereview.chromium.org/5005 is to blame (but it went into 
r2634).  

Status: Started
Cc: bre...@chromium.org
Comment 6 by ben.at.chromium.org, Oct 22, 2008
(No comment was entered for this change.)
Owner: bre...@chromium.org
Comment 7 by jshin@chromium.org, Oct 22, 2008
I already have a patch :-) ( http://codereview.chromium.org/7647 )



Owner: js...@chromium.org
Comment 8 by jshin@chromium.org, Oct 22, 2008
fixed in r3759



Status: Fixed
Comment 9 by xlyuan@chromium.org, Oct 24, 2008
Jungshik:

    For encoding manually override, fixed on both developer build and official build.

    For auto-detect, fixed on official build but still reproduce on latest developer
build, can you please check if this is a issue or not?

    Test file attached.

    Verified on:
    0.3.154.6 (Official Build 3810)
    0.3.155.0 (Developer Build 3911)

Regards,
Xiaolu

 
Chinese GB2312.html
2.4 KB   Download
Japanese Shift-JIS.html
892 bytes   Download
Comment 10 by brettw@chromium.org, Oct 24, 2008
I think this bug started since the last official build, an dhas been fixed since the 
last developer build, so what you see sounds correct.
Comment 11 by xlyuan@chromium.org, Oct 24, 2008
Another issue reproduce on latest trunk build but OK on latest official build: Chrome
doesn't highlight Thai encoding.

Steps:
1. Run latest trunk build
2. Go to http://1900.sanook.com/horoscope/horoscope_00045.php
3. Check the highlight under "Encoding" menu

Result:
No highlight

Expect:
Should highlight "Thai" sub menu

Notes:
This page has http header charset=TIS-620 and meta tag charset=windows-874

Other Browsers:
  Safari: No highlight
Firefox3: Highlight TIS-620
     IE7: Highlight Thai (Windows)
  



 


Comment 12 by xlyuan@chromium.org, Oct 24, 2008
Hmm, sorry, Brett, I didn't see your comments till I already added my new comments,
but I meant still reproduce on latest trunk build rather than fixed.
Comment 13 by jshin@chromium.org, Oct 24, 2008
Xiaolu,  autodetect is a separate issue. Thai issue is yet another one. I filed  issue  
3702  and  issue 3703 .



Comment 15 by thatan...@google.com, Nov 03, 2008
(No comment was entered for this change.)
Cc: thatan...@google.com
Comment 16 by xlyuan@chromium.org, Nov 11, 2008
Verified on build 0.3.154.12 (Official Build 4978), fixed.
Status: Verified
Sign in to add a comment

Powered by Google Project Hosting