(No comment was entered for this change.)

(No comment was entered for this change.)

(No comment was entered for this change.)

I should fix this — it's in my bookmark manager code.

Ack - it's worse than described. Step 3 is unnecessary. What happens is that, when you 
delete the selected folder in the left pane, the right pane doesn't update. It's still 
showing the (deleted) items from the deleted folder. As soon as it tries to operate on 
any item, even repainting it, it crashes.

I think this is a missing selection-changed notification after the delete operation. 
Should be easy to fix.

Checked in r37521.

Merged into Mac beta branch (307) as r37522.

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=37521 

------------------------------------------------------------------------
r37521 | snej@chromium.org | 2010-01-29 10:09:41 -0800 (Fri, 29 Jan 2010) | 4 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_tree_controller.h?r1=37521&r2=37520
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_tree_controller.mm?r1=37521&r2=37520
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_tree_controller_unittest.mm?r1=37521&r2=37520

Mac bookmark manager: Crash after deleting folder in left pane
BUG=33083
TEST=BookmarkTreeControllerTest.Deletion

------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=37522 

------------------------------------------------------------------------
r37522 | snej@chromium.org | 2010-01-29 10:13:31 -0800 (Fri, 29 Jan 2010) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/307/src/chrome/browser/cocoa/bookmark_tree_controller.h?r1=37522&r2=37521
   M http://src.chromium.org/viewvc/chrome/branches/307/src/chrome/browser/cocoa/bookmark_tree_controller.mm?r1=37522&r2=37521
   M http://src.chromium.org/viewvc/chrome/branches/307/src/chrome/browser/cocoa/bookmark_tree_controller_unittest.mm?r1=37522&r2=37521

Merge 37521 - Mac bookmark manager: Crash after deleting folder in left pane
BUG=33083
TEST=BookmarkTreeControllerTest.Deletion


TBR=snej@chromium.org
Review URL: http://codereview.chromium.org/555169
------------------------------------------------------------------------

Verified in 5.0.307.2 (r37599).

removing formerge label from verified bugs.

Platform:
  Hostname: testings-macbook-pro-15.local
  Mac OS X Version 10.6.2 (Build 10C540)
  Processor: 2 Intel 2.33 GHz
  RAM: 2048 MB

Chrome:
  Chrome version: 4.0.302.2 r36665  <<<Release/Debug>>>
  QuickTime Player: <unknown>
  QuickTime PlayerX: 90.3.1
  Flash Player: 10.0.42.34

Precondition: Have any bookmark folder with few bookmarks

<b>What steps will reproduce the problem?</b>
1. Open Bookmark manager
2. From left pane open the folder having bookmarks, which shows bookmark items on right pane
3. Select any bookmark item from right pane and from its context menu choose &quot;Edit&quot; (Dont do anything)
4.  Come to left pane and Delete its folder.

Actual : Browser crash.

Crashing Thread:
==========

Thread 0 (crashed)
 0 Google Chrome Framew0.302.2.0            0x0012eb0d -[BookmarkItem title] + 0x8 (bookmark_item.mm:54)
 1 AppKit              0.1038.25.0          0x90b27b74 -[NSOutlineView _dataSourceValueForColumn:row:] + 0x62
 2 AppKit              0.1038.25.0          0x90b2764d -[NSTableView preparedCellAtColumn:row:] + 0x14e
 3 AppKit              0.1038.25.0          0x90b26e5f -[NSTableView _dirtyVisibleCellsForKeyStateChange] + 0x22d
 4 AppKit              0.1038.25.0          0x90b2683f -[NSTableView _windowChangedKeyState] + 0xbd
 5 CoreFoundation      0.550.13.0           0x9933b4df CFArrayApplyFunction + 0xdf
 6 AppKit              0.1038.25.0          0x90a5631f -[NSView _windowChangedKeyState] + 0x7e
 7 CoreFoundation      0.550.13.0           0x9933b4df CFArrayApplyFunction + 0xdf
 8 AppKit              0.1038.25.0          0x90a5631f -[NSView _windowChangedKeyState] + 0x7e
 9 CoreFoundation      0.550.13.0           0x9933b4df CFArrayApplyFunction + 0xdf
10 AppKit              0.1038.25.0          0x90a5631f -[NSView _windowChangedKeyState] + 0x7e
11 AppKit              0.1038.25.0          0x90b265ce -[NSSplitView _windowChangedKeyState] + 0x38
12 CoreFoundation      0.550.13.0           0x9933b4df CFArrayApplyFunction + 0xdf
13 AppKit              0.1038.25.0          0x90a5631f -[NSView _windowChangedKeyState] + 0x7e
14 CoreFoundation      0.550.13.0           0x9933b4df CFArrayApplyFunction + 0xdf
15 AppKit              0.1038.25.0          0x90a5631f -[NSView _windowChangedKeyState] + 0x7e
16 AppKit              0.1038.25.0          0x90b26349 -[NSFrameView _windowChangedKeyState] + 0x67
17 AppKit              0.1038.25.0          0x90a56012 -[NSWindow _setFrameNeedsDisplay:] + 0xcc
18 AppKit              0.1038.25.0          0x90a5439c -[NSWindow _changeKeyAndMainLimitedOK:] + 0x40b
19 AppKit              0.1038.25.0          0x90b74ac7 -[NSWindow sendEvent:] + 0x1164
20 Google Chrome Framew0.302.2.0            0x00142e5a -[ChromeEventProcessingWindow sendEvent:] + 0x2a (chrome_event_processing_window.mm:98)
21 Google Chrome Framew0.302.2.0            0x00141cfd -[ChromeBrowserWindow sendEvent:] + 0x27 (chrome_browser_window.mm:300)
22 AppKit              0.1038.25.0          0x90a8db2e -[NSApplication sendEvent:] + 0x191e
23 Google Chrome Framew0.302.2.0            0x0055ad6b -[CrApplication sendEvent:] + 0x2d (chrome_application_mac.mm:33)
24 AppKit              0.1038.25.0          0x90a214fe -[NSApplication run] + 0x394
25 Google Chrome Framew0.302.2.0            0x0054ac3c base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 0x19 (message_pump_mac.mm:677)
26 Google Chrome Framew0.302.2.0            0x0054a3c5 base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 0xb (message_pump_mac.mm:213)
27 Google Chrome Framew0.302.2.0            0x0056eac3 MessageLoop::Run() + 0xb (message_loop.cc:205)
28 Google Chrome Framew0.302.2.0            0x000f3e02 BrowserMain(MainFunctionParams const&amp;) + 0x7 (browser_main.cc:163)
29 Google Chrome Framew0.302.2.0            0x0000a62a ChromeMain + 0xd (chrome_dll_main.cc:748)
30 Google Chrome                            0x00001fc5 
31 

Crash Report attached.