| Issue 32734: | Bookmark Manager: Clearing search results should re-focus the pre-search focus | |
| 3 people starred this issue and may be notified of changes. | Back to list |
Sign in to add a comment
|
What steps will reproduce the problem? 1. Hit cmd-f 2. type in something 3. Hit esc to cancel the search What is the expected result? Should re-focus what was focused before the search started (e.g. the "Bookmarks Bar" folder). What happens instead? The empty "Search results" "folder" stays focused.
,
Jan 27, 2010
Adding "ForMerge" so this gets into the beta (pink gave prior approval for isolated bookmark-mgr changes to go into the branch.)
Labels: ForMerge
,
Jan 27, 2010
In review: http://codereview.chromium.org/556048 Should be able to commit this afternoon.
Status: Started
,
Jan 27, 2010
Oops, wrong URL: http://codereview.chromium.org/555112
,
Jan 28, 2010
(No comment was entered for this change.)
Status: Fixed
,
Jan 29, 2010
Issue 33436 has been merged into this issue.
Cc: kr...@chromium.org ism...@chromium.org
,
Feb 1, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=37444
------------------------------------------------------------------------
r37444 | snej@chromium.org | 2010-01-28 13:46:40 -0800 (Thu, 28 Jan 2010) | 5 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_manager_controller.h?r1=37444&r2=37443
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_manager_controller.mm?r1=37444&r2=37443
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_manager_controller_unittest.mm?r1=37444&r2=37443
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_tree_controller.mm?r1=37444&r2=37443
Mac bookmark mgr: Restore previously selected group when search field is cleared.
BUG=32734
TEST=none
Review URL: http://codereview.chromium.org/555112
------------------------------------------------------------------------
,
Feb 1, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=37445
------------------------------------------------------------------------
r37445 | snej@chromium.org | 2010-01-28 13:49:22 -0800 (Thu, 28 Jan 2010) | 8 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/branches/307/src/chrome/browser/cocoa/bookmark_manager_controller.h?r1=37445&r2=37444
M http://src.chromium.org/viewvc/chrome/branches/307/src/chrome/browser/cocoa/bookmark_manager_controller.mm?r1=37445&r2=37444
M http://src.chromium.org/viewvc/chrome/branches/307/src/chrome/browser/cocoa/bookmark_manager_controller_unittest.mm?r1=37445&r2=37444
M http://src.chromium.org/viewvc/chrome/branches/307/src/chrome/browser/cocoa/bookmark_tree_controller.mm?r1=37445&r2=37444
Merge 37444 - Mac bookmark mgr: Restore previously selected group when search field is cleared.
BUG=32734
TEST=none
Review URL: http://codereview.chromium.org/555112
TBR=snej@chromium.org
Review URL: http://codereview.chromium.org/558023
------------------------------------------------------------------------
,
Feb 3, 2010
5.0.307.5 (Official Build 37950) dev
Status: Verified
,
Feb 14, 2010
removing formerge label from verified bugs.
Labels: -formerge
|
||||||||||
| ► Sign in to add a comment | |||||||||||
Labels: Mstone-5 ReleaseBlock-Beta