(No comment was entered for this change.)

(No comment was entered for this change.)

 Issue 20878  has been merged into this issue.

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=36338 

------------------------------------------------------------------------
r36338 | aa@chromium.org | 2010-01-15 00:05:14 -0800 (Fri, 15 Jan 2010) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tabs_module.cc?r1=36338&r2=36337
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=36338&r2=36337
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/api/extension_api.json?r1=36338&r2=36337
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/tabs/basics/test.js?r1=36338&r2=36337

Add the ability to focus a window to chrome.window.update().
Also, enable the tabs api test on linux. I'm probably going
to regret that, but it seems to work with one line removed.

BUG=31434

Review URL: http://codereview.chromium.org/545044
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=36407 

------------------------------------------------------------------------
r36407 | aa@chromium.org | 2010-01-15 13:19:30 -0800 (Fri, 15 Jan 2010) | 4 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tabs_module.cc?r1=36407&r2=36406
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=36407&r2=36406
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/api/extension_api.json?r1=36407&r2=36406
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/tabs/basics/test.js?r1=36407&r2=36406

Re-land r36338: Add the ability to focus a window to chrome.window.update().

BUG=31434
TBR=rafaelw@chromium.org
------------------------------------------------------------------------

 Issue 32811  has been merged into this issue.

(No comment was entered for this change.)

Any progress on this? To be honest, this is one of the more annoying things that 
Chrome is lacking (for me). I have a couple extensions that could really use this 
feature.

I understand you guys are very busy, and this isn't a top-priority bug. Just checking 
that this hasn't been forgotten.

It's in progress.  It's been hung up due to some problems with the associated unit 
tests.

We're needing this fix for an internal tool we're trying to build. Is there a good estimate for this fix? Not fixing it 
might hold us back from an early Dogfood. Please let me know if you'd like me to follow up with more details. 

 Issue 53521  has been merged into this issue.

It's been 8 months, and the lack of this is causing two annoying usability problems with my extension...

Putting this back on deck for m8.

(No comment was entered for this change.)

http://codereview.chromium.org/3584010/show

Will this be added to create as well? I'm asking because unlinke update it doesn't require permissions.

chrome.tabs.create({}) creates windows that are focused by default. Do you want to create windows that are _not_ focused?

Also, chrome.tabs.update() doesn't require permissions, just like chrome.tabs.create().

Maybe I misunderstand the term focus, but this is not the case for tabs created from notifications. I filed a bug report on it.

http://crbug.com/57826/

And I didn't know update doesn't require permissions any more as well. So I could just focus the tab from the callback function when it is created, all without permissions?

I noticed it doesn't like the previous URL.

http://crbug.com/57826

Ah, I've commented on that bug.

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=61555

------------------------------------------------------------------------
r61555 | aa@chromium.org | Tue Oct 05 13:41:44 PDT 2010

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/windows.html?r1=61555&r2=61554&pathrev=61555
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/api/extension_api.json?r1=61555&r2=61554&pathrev=61555
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tabs_module.cc?r1=61555&r2=61554&pathrev=61555
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/tabs/basics/test.js?r1=61555&r2=61554&pathrev=61555

Add chrome.windows.update({focused:true});

BUG=31434
TEST=browser_tests --gtest_filter=ExtensionApiTest.*Tabs

Review URL: http://codereview.chromium.org/3584010
------------------------------------------------------------------------

There is still a slight difference between having focused in chrome.tabs.create (in the case of notifications as mentioned in the bug report) and using chrome.windows.update to focus the window in which the tab was created, because the latter requires permissions.

I'm only mentioning it because I like to be as light as possible on requested permissions to avoid scaring users away. Maybe focusing a just created tab from a notification should indeed require permissions. I don't know. I can file a bug report or feature request on it.

Ah, chrome.windows.create/chrome.windows.update still require permissions -- you are right. I was thinking of chrome.tabs.create/chrome.tabs.update.

Ok, fair enough. It should be easy to allow those two methods to be used without permissions. I'll look into it.

Thanks!

Since we are passed the branch, moving all mstone-8 issues to mstone-9 for triage/punting

Moving all P2 bugs w/ owners into Mstone-10.  I'll leave this to the owners discretion if they want to move the work back into M9, however, my caveat would be that the priority should be on completing P0/P1 bugs in the span of the next few weeks.

Anthony, please stop. Or at least talk to me first about what you're trying to achieve so that we can work together. This is ridiculous.

Thanks for adding this; it's working well for us.

(No comment was entered for this change.)

This appears to have been fixed at some point; focusing a tab now brings its window to the front.  As far as I'm concerned this bug is fixed. :)

(No comment was entered for this change.)