Issue 31434 - chromium - Extensions can focus tabs but not windows

Issue 31434:	Extensions can focus tabs but not windows	‹ Prev 9370 of 16393 Next ›
	27 people starred this issue and may be notified of changes.	Back to list

Status:	Started
Owner:	aa@chromium.org
Cc:	erikkay@chromium.org
Type-Bug
Pri-2
Feature-Extensions
Area-UI
ext

Reported by megazzt, Jan 01, 2010

Google Chrome	4.0.266.0 (Official Build 33992)
WebKit	532.6
V8	2.0.3.1
User Agent	Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US) 
AppleWebKit/532.6 (KHTML, like Gecko) Chrome/4.0.266.0 Safari/532.6

What steps will reproduce the problem?
1. Have an extension call tab.update to select a tab in another window that 
is either minimized or otherwise not focused.
2. The other window will not focus or restore.
3. Note there is no similar window.update call, no apparent way to focus a 
window!

What is the expected result?

Either selecting a tab in another window should focus that window, or, 
since that is not desirable all the time, there should be a separate API to 
focus a window.

At least, bring it to the top of the Chrome windows, if not the entire 
desktop (THAT could be annoying in the right cases).

What happens instead?

Currently, the tab is selected in the window, but the window remains in the 
background or minimized.  If an extension is updating a tab to show the 
user something the user may not know something has occurred!

In my specific case, I am updating my extension One Number to "recycle" 
tabs... e.g. if the user has Google Reader open the extension will refresh 
that tab if the user opens Google Reader from my extension instead of 
making a new tab.  If the tab is in another window or minimized there is no 
way for my extension to indicate something is happening and the user may 
think One Number is broken.

Please provide any additional information below. Attach a screenshot if
possible.

I can work around this by limiting the "recycle scope" to the current 
window but it would be nice to be able to do it in all windows.

Comment 1 by phajdan.jr@chromium.org, Jan 11, 2010

(No comment was entered for this change.)

Labels: -Area-Undefined Area-Feature Feature-Extensions

Comment 2 by aa@chromium.org, Jan 13, 2010

(No comment was entered for this change.)

Status: Started
Owner: a...@chromium.org

Comment 3 by aa@chromium.org, Jan 15, 2010

 Issue 20878  has been merged into this issue.

Comment 4 by bugdroid1@chromium.org, Jan 15, 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=36338 

------------------------------------------------------------------------
r36338 | aa@chromium.org | 2010-01-15 00:05:14 -0800 (Fri, 15 Jan 2010) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tabs_module.cc?r1=36338&r2=36337
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=36338&r2=36337
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/api/extension_api.json?r1=36338&r2=36337
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/tabs/basics/test.js?r1=36338&r2=36337

Add the ability to focus a window to chrome.window.update().
Also, enable the tabs api test on linux. I'm probably going
to regret that, but it seems to work with one line removed.

BUG=31434

Review URL: http://codereview.chromium.org/545044
------------------------------------------------------------------------

Comment 5 by bugdroid1@chromium.org, Jan 15, 2010

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=36407 

------------------------------------------------------------------------
r36407 | aa@chromium.org | 2010-01-15 13:19:30 -0800 (Fri, 15 Jan 2010) | 4 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_tabs_module.cc?r1=36407&r2=36406
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=36407&r2=36406
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/api/extension_api.json?r1=36407&r2=36406
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/tabs/basics/test.js?r1=36407&r2=36406

Re-land r36338: Add the ability to focus a window to chrome.window.update().

BUG=31434
TBR=rafaelw@chromium.org
------------------------------------------------------------------------

Comment 6 by dhw@chromium.org, Jan 21, 2010

 Issue 32811  has been merged into this issue.

Comment 7 by laforge@chromium.org, Feb 16, 2010

(No comment was entered for this change.)

Labels: -Area-Feature Area-UI

Comment 8 by pcxunlimited, Feb 25, 2010

Any progress on this? To be honest, this is one of the more annoying things that 
Chrome is lacking (for me). I have a couple extensions that could really use this 
feature.

I understand you guys are very busy, and this isn't a top-priority bug. Just checking 
that this hasn't been forgotten.

Comment 9 by erikkay@chromium.org, Mar 01, 2010

It's in progress.  It's been hung up due to some problems with the associated unit 
tests.

Cc: erik...@chromium.org

Comment 10 by hol...@google.com, Apr 12, 2010

We're needing this fix for an internal tool we're trying to build. Is there a good estimate for this fix? Not fixing it 
might hold us back from an early Dogfood. Please let me know if you'd like me to follow up with more details.

Comment 11 by erikkay@chromium.org, Aug 30 (3 days ago)

 Issue 53521  has been merged into this issue.

► Sign in to add a comment