My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 288019: WEBPImageDecoder.cpp uses unreleased libwebp features
7 people starred this issue and may be notified of changes. Back to list
 
Project Member Reported by phajdan.jr@chromium.org, Sep 9, 2013
Here's what I get when trying to compile against libwebp-0.3.1:

../../third_party/WebKit/Source/core/platform/image-decoders/webp/WEBPImageDecoder.cpp: In member function ‘bool WebCore::WEBPImageDecoder::updateDemuxer()’:
../../third_party/WebKit/Source/core/platform/image-decoders/webp/WEBPImageDecoder.cpp:248:69: error: ‘WebPIterator’ has no member named ‘blend_method’
../../third_party/WebKit/Source/core/platform/image-decoders/webp/WEBPImageDecoder.cpp:248:85: error: ‘WEBP_MUX_BLEND’ was not declared in this scope
../../third_party/WebKit/Source/core/platform/image-decoders/webp/WEBPImageDecoder.cpp:256:109: error: ‘WebPIterator’ has no member named ‘has_alpha’

I think this was introduced in https://chromiumcodereview.appspot.com/22802020 as a cherry-pick from upstream git.

It's obviously fine to let this bake for a while in our repo, but ideally libwebp should make a release with this code before M31 hits stable.

It seems I can't assign it to Urvang, so trying Frank first - could you help route this to the right people?
Sep 10, 2013
#1 urv...@google.com
Yes, this is known, and due to the cherry-picked changes as Pawel mentioned.

We will release the next libwebp version before M31 hits stable (which seems to be 12th Nov) as suggested.

Feel free to mark this as M31 releaseblock-stable.
Sep 13, 2013
#2 urv...@chromium.org
(No comment was entered for this change.)
Labels: ReleaseBlock-Stable
Oct 14, 2013
#3 phajdan.jr@chromium.org
(No comment was entered for this change.)
Owner: urv...@chromium.org
Cc: fbarch...@chromium.org
Oct 14, 2013
#4 urv...@google.com
(No comment was entered for this change.)
Owner: jz...@chromium.org
Cc: urv...@chromium.org
Oct 22, 2013
#5 jz...@chromium.org
We'll make an attempt to make a release within the same time frame of the stable release, but this isn't a release blocker.
Labels: -M-31 -ReleaseBlock-Stable M-32
Nov 7, 2013
#6 kar...@google.com
Moving all non essential bugs to the next Milestone.
Labels: -M-32 M-33 MovedFrom-32
Dec 3, 2013
#7 spo...@gmail.com
Sure would be nice if this got made into a release. :/
Dec 17, 2013
#8 bugdro...@chromium.org
This issue has already been moved once and is lower than Priority 1,therefore removing mstone.
Labels: -M-33 MovedFrom-33
Jan 2, 2014
#9 phajdan.jr@chromium.org
Looks like this is fixed with libwebp-0.4.0. I've tested it and building with system libwebp seems to work with that version. Thanks!
Jan 7, 2014
#10 jz...@chromium.org
As noted the availability of libwebp-0.4.0 addresses this issue.
Status: Fixed
Sign in to add a comment

Powered by Google Project Hosting