My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 2822: Use MenuItemView instead of Menu for the Page menu button
2 people starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  sky@chromium.org
Closed:  Jun 2010

Restricted
  • Only users with Commit permission may comment.


Sign in to add a comment
 
Reported by xlyuan@chromium.org, Sep 25, 2008
See <b\1232732>

There is currently a hack in chrome\views\accelerator.cc which modifies the
shortcut string in certain cases for RTL locaes. For example, instead of
returning "Ctrl++" the hack returns "++Ctrl". This hack is required because
Windows does not support Unicode directionality marks for text inside
menus. Modifying the string in this manner is not very safe since it relies
on the fact that we always the strings that need adjustment always have the
suffix "+" and KEY (where KEY is the actual accelerator key).

One way to avoid using this hack is to not use Windows menus and instead
use the chrome specific menus (the same menus used by on the bookmark bar).

 
Sep 29, 2008
#1 niran...@chromium.org
(No comment was entered for this change.)
Labels: Mstone-X
Sep 29, 2008
#2 mal.chromium@gmail.com
(No comment was entered for this change.)
Labels: Area-BrowserUI I18N are
Sep 29, 2008
#3 mal.chromium@gmail.com
(No comment was entered for this change.)
Labels: -are -area-i18n
Dec 18, 2009
#4 or...@chromium.org
Area-UI-Features label replaces Area-BrowserUI label
Labels: -Area-BrowserUI Area-UI-Features
Feb 17, 2010
#5 lafo...@chromium.org
(No comment was entered for this change.)
Labels: Area-UI
Feb 17, 2010
#6 lafo...@chromium.org
(No comment was entered for this change.)
Labels: -Area-UI-Features
Jun 28, 2010
#7 pkasting@chromium.org
Scott, I think your work obsoletes this?
Owner: s...@chromium.org
Cc: -s...@chromium.org
Jun 28, 2010
#8 sky@chromium.org
Indeed. We're now using menuitemview for the wrench menu.
Status: Fixed
Mar 18, 2011
#9 lafo...@chromium.org
See &lt;b\1232732&gt;

There is currently a hack in chrome\views\accelerator.cc which modifies the
shortcut string in certain cases for RTL locaes. For example, instead of
returning &quot;Ctrl++&quot; the hack returns &quot;++Ctrl&quot;. This hack is required because
Windows does not support Unicode directionality marks for text inside
menus. Modifying the string in this manner is not very safe since it relies
on the fact that we always the strings that need adjustment always have the
suffix &quot;+&quot; and KEY (where KEY is the actual accelerator key).

One way to avoid using this hack is to not use Windows menus and instead
use the chrome specific menus (the same menus used by on the bookmark bar).
Labels: -I18N bulkmove Feature-I18N
Oct 12, 2012
#10 bugdro...@chromium.org
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Labels: Restrict-AddIssueComment-Commit
Mar 10, 2013
#11 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Area-UI -Feature-I18N Cr-UI-I18N Cr-UI
Mar 20, 2013
#12 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Cr-UI-I18N Cr-UI-Internationalization
Sign in to add a comment

Powered by Google Project Hosting