Issue 28203 - chromium - Mac: NTP detached bookmark bar border color regressed

Issue 28203:	Mac: NTP detached bookmark bar border color regressed
	2 people starred this issue and may be notified of changes.	Back to list

Status:	Verified
Owner:	viettrungluu@chromium.org
Closed:	Nov 18
Cc:	thakis@chromium.org
Type-Bug
Pri-2
OS-Mac
Area-BrowserUI
Mstone-4
ReleaseBlock-Beta

Reported by viettrungluu@chromium.org, Nov 18, 2009

In r32425 (which does the morph animation), I broke the border color (and 
presumably other colors as well), by ignoring existing alphas. E.g., on the 
default theme it displays as black (or is it a dark gray), whereas it should 
display as a mid-light gray.

See also  issue 25600 .

Comment 1 by viettrungluu@chromium.org, Nov 18, 2009

(No comment was entered for this change.)

Status: Started

Comment 2 by thakis@chromium.org, Nov 18, 2009

Since  issue 25941  was mstone:4 releaseblock:beta I'm carrying that over to here.

Labels: Mstone-4 ReleaseBlock-Beta

Comment 3 by viettrungluu@chromium.org, Nov 18, 2009

r32461 (tired of waiting for the droid to show up)

Status: Fixed

Comment 4 by bugdroid1@chromium.org, Nov 19, 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=32461 

------------------------------------------------------------------------
r32461 | viettrungluu@chromium.org | 2009-11-18 17:42:26 -0800 (Wed, 18 Nov 2009) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view.mm?r1=32461&r2=32460

Mac: Fix regression in NTP detached bookmark bar colours.

The regression was caused by r32425.

BUG=28203
TEST=Look at NTP detached bookmark bar: it should be medium-ish grey, not black (or is that dark grey)?

Review URL: http://codereview.chromium.org/406009
------------------------------------------------------------------------

Comment 5 by bugdroid1@chromium.org, Nov 19, 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=32518 

------------------------------------------------------------------------
r32518 | viettrungluu@chromium.org | 2009-11-19 08:57:48 -0800 (Thu, 19 Nov 2009) | 11 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/cocoa/bookmark_bar_toolbar_view.mm?r1=32518&r2=32517

Merge 32461 - Mac: Fix regression in NTP detached bookmark bar colours.

The regression was caused by r32425 [merged r32517].

BUG=28203
TEST=Look at NTP detached bookmark bar: it should be mediumish grey, not black (or is that dark grey?).

Review URL: http://codereview.chromium.org/406009

TBR=viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/410002
------------------------------------------------------------------------

Comment 6 by kr...@chromium.org, Nov 19, 2009

4.0.249.4 r32475

Status: Verified

Comment 7 by bugdroid1@chromium.org, Nov 30, 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=32461 

------------------------------------------------------------------------
r32461 | viettrungluu@chromium.org | 2009-11-18 17:42:26 -0800 (Wed, 18 Nov 2009) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view.mm?r1=32461&r2=32460

Mac: Fix regression in NTP detached bookmark bar colours.

The regression was caused by r32425.

BUG=28203
TEST=Look at NTP detached bookmark bar: it should be medium-ish grey, not black (or is that dark grey)?

Review URL: http://codereview.chromium.org/406009
------------------------------------------------------------------------

Comment 8 by bugdroid1@chromium.org, Nov 30, 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=32518 

------------------------------------------------------------------------
r32518 | viettrungluu@chromium.org | 2009-11-19 08:57:48 -0800 (Thu, 19 Nov 2009) | 11 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/cocoa/bookmark_bar_toolbar_view.mm?r1=32518&r2=32517

Merge 32461 - Mac: Fix regression in NTP detached bookmark bar colours.

The regression was caused by r32425 [merged r32517].

BUG=28203
TEST=Look at NTP detached bookmark bar: it should be mediumish grey, not black (or is that dark grey?).

Review URL: http://codereview.chromium.org/406009

TBR=viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/410002
------------------------------------------------------------------------

► Sign in to add a comment