| Issue 26990: | no way to reordering browser action | |
| 70 people starred this issue and may be notified of changes. | Back to list |
Sign in to add a comment
|
there should be a way to choose the order in wich the browser action are displayed near the omnibox. for example in the extensions page something like move left/move right (or move up/move down) or better the ability to move them directly with the mouse. so an user should order them as he wish. with many browser action installed can choose the order of them would be very useful, due to feel and like of users. |
||||||||||||||||||||||||||
,
Nov 06, 2009
Are they currently just lining up in order of installation? It'd be great if you could drop them elsewhere on the toolbar too, like on the left side. (I've always wanted a Stop button next to Reload, myself.) |
|||||||||||||||||||||||||||
,
Nov 06, 2009
On a related note, Issue 24498. |
|||||||||||||||||||||||||||
,
Nov 06, 2009
yea, you should be able to drag move them.
Status: Available
Cc: est...@chromium.org Labels: -Area-Misc Area-Extensions |
|||||||||||||||||||||||||||
,
Nov 15, 2009
(No comment was entered for this change.)
Labels: Feature-Extensions
|
|||||||||||||||||||||||||||
,
Nov 18, 2009
(No comment was entered for this change.)
Labels: -Area-Extensions
|
|||||||||||||||||||||||||||
,
Nov 21, 2009
This feature is needed soon. |
|||||||||||||||||||||||||||
,
Nov 21, 2009
Issue 21236 is a dup. |
|||||||||||||||||||||||||||
,
Nov 21, 2009
Issue 21236 has been merged into this issue. |
|||||||||||||||||||||||||||
,
Nov 24, 2009
can someone triage this and give an owner? this is required for browser action!!! |
|||||||||||||||||||||||||||
,
Nov 24, 2009
Sorry, I don't think this is going to make it for the initial release. We understand it's an important issue, but our UI has been frozen for a little while now.
Labels: Mstone-5
|
|||||||||||||||||||||||||||
,
Nov 24, 2009
fine.. just wanted to be sure that you would start soon to work on this. Mstone 5 is ok! thank you and continue the great job guys ;) |
|||||||||||||||||||||||||||
,
Dec 03, 2009
(No comment was entered for this change.)
Status: Started
Owner: est...@chromium.org Cc: -est...@chromium.org |
|||||||||||||||||||||||||||
,
Dec 07, 2009
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=34005
------------------------------------------------------------------------
r34005 | estade@chromium.org | 2009-12-07 14:34:31 -0800 (Mon, 07 Dec 2009) | 11 lines
Changed paths:
A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_toolbar_model.cc
A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_toolbar_model.h
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extensions_service.cc?r1=34005&r2=34004
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extensions_service.h?r1=34005&r2=34004
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc?r1=34005&r2=34004
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.h?r1=34005&r2=34004
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=34005&r2=34004
Extensions: create a simple model for the browser action buttons toolstrip and use it on Linux.
TODO: persist the order of buttons
TODO: use the model on windows, mac
TODO: let the view change the order of buttons
My plan for persisting the order is just to write/read a simple text file to/from disk, one extension id per line. Similar to the bookmark model, except that is structured data (because they try to hold more information).
BUG=26990
Review URL: http://codereview.chromium.org/462026
------------------------------------------------------------------------
|
|||||||||||||||||||||||||||
,
Dec 10, 2009
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=34272
------------------------------------------------------------------------
r34272 | estade@chromium.org | 2009-12-10 12:10:15 -0800 (Thu, 10 Dec 2009) | 7 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/browser_action_apitest.cc?r1=34272&r2=34271
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_toolbar_model.cc?r1=34272&r2=34271
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_toolbar_model.h?r1=34272&r2=34271
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extensions_service.cc?r1=34272&r2=34271
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc?r1=34272&r2=34271
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h?r1=34272&r2=34271
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc?r1=34272&r2=34271
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.h?r1=34272&r2=34271
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/gtk_util.cc?r1=34272&r2=34271
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/gtk_util.h?r1=34272&r2=34271
GTK: hook up drag and drop of browser actions (for reordering).
The changes are propagated across open chrome windows, but are not persisted between sessions yet.
BUG=26990
Review URL: http://codereview.chromium.org/463056
------------------------------------------------------------------------
|
|||||||||||||||||||||||||||
,
Dec 14, 2009
done on Linux.
Status: Available
Owner: --- Cc: est...@chromium.org Labels: -OS-All OS-Windows OS-Mac |
|||||||||||||||||||||||||||
,
Dec 14, 2009
cc'ing andy for mac side.
Cc: andyb...@chromium.org
|
|||||||||||||||||||||||||||
,
Dec 14, 2009
Just Windows and Mac to go.. |
|||||||||||||||||||||||||||
,
Dec 17, 2009
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=34490
------------------------------------------------------------------------
r34490 | estade@chromium.org | 2009-12-14 12:51:29 -0800 (Mon, 14 Dec 2009) | 7 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_prefs.cc?r1=34490&r2=34489
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_prefs.h?r1=34490&r2=34489
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_toolbar_model.cc?r1=34490&r2=34489
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_toolbar_model.h?r1=34490&r2=34489
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc?r1=34490&r2=34489
Persist the order of extensions in the browser action toolbar across sessions.
Very similar to what we did with the extension shelf.
BUG=26990
Review URL: http://codereview.chromium.org/487021
------------------------------------------------------------------------
|
|||||||||||||||||||||||||||
,
Dec 21, 2009
please this needs an owner for windows/mac! the number of extensions is growing fast.. is necessary a way to reordering them! thanks ;) |
|||||||||||||||||||||||||||
,
Dec 21, 2009
in the meantime the best workaround is to disable all extensions, then re-enable them in the order you want them to appear on the shelf |
|||||||||||||||||||||||||||
,
Dec 21, 2009
this does not work for me! the order seems not to be releted to the order of enabling. oor better is not persistent between sessions! am i wrong? |
|||||||||||||||||||||||||||
,
Dec 21, 2009
@20 That new order will only work until you restart the browser. |
|||||||||||||||||||||||||||
,
Jan 25, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=37025
------------------------------------------------------------------------
r37025 | estade@chromium.org | 2010-01-25 11:05:49 -0800 (Mon, 25 Jan 2010) | 7 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.cc?r1=37025&r2=37024
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.h?r1=37025&r2=37024
Views: use ExtensionToolbarModel for ordering of browser action buttons.
This doesn't implement drag and drop reording, but the order is stored on shutdown and restored on startup.
BUG=26990
Review URL: http://codereview.chromium.org/554057
------------------------------------------------------------------------
|
|||||||||||||||||||||||||||
,
Jan 26, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=37026
------------------------------------------------------------------------
r37026 | estade@chromium.org | 2010-01-25 11:42:34 -0800 (Mon, 25 Jan 2010) | 7 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.cc?r1=37026&r2=37025
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.h?r1=37026&r2=37025
Revert r37025, which (may have) caused workertest redness
Views: use ExtensionToolbarModel for ordering of browser action buttons. This doesn't implement drag and drop reording, but the order is stored on shutdown and restored on startup. BUG=26990 Review URL: http://codereview.chromium.org/554057
TBR=amanda
Review URL: http://codereview.chromium.org/546133
------------------------------------------------------------------------
|
|||||||||||||||||||||||||||
,
Jan 26, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=37061
------------------------------------------------------------------------
r37061 | estade@chromium.org | 2010-01-25 15:35:50 -0800 (Mon, 25 Jan 2010) | 12 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.cc?r1=37061&r2=37060
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.h?r1=37061&r2=37060
re-try r37025 with fix for incognito mode
----------------------------------------
Views: use ExtensionToolbarModel for ordering of browser action buttons.
This doesn't implement drag and drop reording, but the order is stored on shutdown and restored on startup.
BUG=26990
Review URL: http://codereview.chromium.org/549151
------------------------------------------------------------------------
|
|||||||||||||||||||||||||||
,
Jan 27, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=37302
------------------------------------------------------------------------
r37302 | estade@chromium.org | 2010-01-27 12:40:44 -0800 (Wed, 27 Jan 2010) | 11 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.cc?r1=37302&r2=37301
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.h?r1=37302&r2=37301
re-try r37061 with fix for browser tests
----------------------------------------
Views: use ExtensionToolbarModel for ordering of browser action buttons.
This doesn't implement drag and drop reording, but the order is stored on shutdown and restored on startup.
BUG=26990
Review URL: http://codereview.chromium.org/553084
------------------------------------------------------------------------
|
|||||||||||||||||||||||||||
,
Jan 30, 2010
(No comment was entered for this change.)
Labels: Area-Feature
|
|||||||||||||||||||||||||||
,
Jan 30, 2010
Working on the Windows side of this (forgot to take the bug).
Status: Started
Owner: fin...@chromium.org |
|||||||||||||||||||||||||||
,
Jan 30, 2010
Issue 33847 has been merged into this issue. |
|||||||||||||||||||||||||||
,
Feb 01, 2010
(No comment was entered for this change.)
Labels: m5-priority
|
|||||||||||||||||||||||||||
,
Feb 02, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=37922
------------------------------------------------------------------------
r37922 | finnur@chromium.org | 2010-02-02 17:17:26 -0800 (Tue, 02 Feb 2010) | 9 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/base/file_path.cc?r1=37922&r2=37921
M http://src.chromium.org/viewvc/chrome/trunk/src/base/file_path.h?r1=37922&r2=37921
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_drag_data.cc?r1=37922&r2=37921
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_drag_data.h?r1=37922&r2=37921
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_toolbar_model.h?r1=37922&r2=37921
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.cc?r1=37922&r2=37921
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.h?r1=37922&r2=37921
A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/extensions/browser_action_drag_data.cc
A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/extensions/browser_action_drag_data.h
A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/extensions/browser_action_drag_data_unittest.cc
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/extensions/browser_action_overflow_menu_controller.cc?r1=37922&r2=37921
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser.gypi?r1=37922&r2=37921
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=37922&r2=37921
Support reordering of Browser Actions within the container. Currently does not support dragging to/from the chevron menu.
Also fixed two bugs in the same code:
- the container would be 0 width if a value for it hasn't been saved (part of bug 32101 ).
- the default icon was not used when a tab specific icon was not found ( bug 34317 ).
BUG=http://crbug.com/26990, http://crbug.com/32101, http://crbug.com/34317
TEST=In both LTR and RTL locale, try reordering the browser actions and make sure to test dragging to the ends with and without a chevron visible. Install Send to Gmail extension and make sure it has an icon while in the overflow menu.
Review URL: http://codereview.chromium.org/549224
------------------------------------------------------------------------
|
|||||||||||||||||||||||||||
,
Feb 02, 2010
Windows is done. Just Mac to go, I guess? Is Andy an appropriate owner?
Owner: andyb...@chromium.org
Cc: -andyb...@chromium.org fin...@chromium.org Labels: -OS-Windows |
|||||||||||||||||||||||||||
,
Feb 02, 2010
I know this sounds picky, but wouldn't it look cooler if the dragging worked like the NTP dragging? |
|||||||||||||||||||||||||||
,
Feb 02, 2010
Yes I'm the appropriate owner. Thanks, finnur. Is there a UI spec somewhere or should I just find a linux/win build to play with? |
|||||||||||||||||||||||||||
,
Feb 02, 2010
I'll find one for you tomorrow. |
|||||||||||||||||||||||||||
,
Feb 03, 2010
Will this be in next Windows dev |
|||||||||||||||||||||||||||
,
Feb 03, 2010
@GraemeErickson, are you suggesting that dragging the extensions work like the NTP dragging that also swaps the locations? If that's the case, then NO WAY! Dragging only one extension and inserting only that extension into the dropped location is perfect and the only way to go. |
|||||||||||||||||||||||||||
,
Feb 03, 2010
@krtulmay, no, I dislike the swap function as much as you do. What I'm talking about is how the thumbnail drags with your cursor as you move it. Currently in Chromium, there are just dividers between the browser actions as you move them around. I think it would look less IE-ish and more Chrome-ish if the browser actions moved around with your cursor. |
|||||||||||||||||||||||||||
,
Feb 03, 2010
> more Chrome-ish if the browser actions moved around with your cursor Yes, that would be more Chrome-ish and sounds like a neat idea! Sounds like it should go into its own bug report/feature request. |
|||||||||||||||||||||||||||
,
Feb 04, 2010
Working fine on latest Windows. |
|||||||||||||||||||||||||||
,
Feb 04, 2010
Can't wait!!!! Hopefully this will allow users to place extensions and all icons where ever we want on the toolbar, including of the far left. thanks google |
|||||||||||||||||||||||||||
,
Feb 04, 2010
bmcfiv: Just so that there is no misunderstanding: This changelist does not allow you to move the browser action container anywhere, only reorder the icons within it. There is another bug describing a feature request to move the browser action container. You might want to hunt that down and star it to keep track of updates. |
|||||||||||||||||||||||||||
,
Feb 04, 2010
too bad but thanks for the response. i will do that. |
|||||||||||||||||||||||||||
,
Feb 04, 2010
For those interested in moving built-in functions, please vote for Issue 24498. |
|||||||||||||||||||||||||||
,
Feb 05, 2010
I like that the badge moves with the cursor now, but I still think it'd look cooler if they "slid" across the container, rather than dropped into a spot. I'm thinking of how thumbnails can slide around the NTP. It'd also be cool if, like the NTP, a badge would slide over if you moved another badge over it. |
|||||||||||||||||||||||||||
,
Feb 05, 2010
I like having the slider, but I think it would be better if it was invisible and the then the cursor changes when it hovers over the area; much like in firefox between the location bar and search bar. Does anyone know if there is an 'issue' regarding this, and if so what number is it? |
|||||||||||||||||||||||||||
,
Feb 06, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=38135
------------------------------------------------------------------------
r38135 | finnur@chromium.org | 2010-02-04 13:38:07 -0800 (Thu, 04 Feb 2010) | 6 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/bookmark_bar_view.cc?r1=38135&r2=38134
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.cc?r1=38135&r2=38134
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.h?r1=38135&r2=38134
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/extensions/browser_action_overflow_menu_controller.cc?r1=38135&r2=38134
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/extensions/browser_action_overflow_menu_controller.h?r1=38135&r2=38134
M http://src.chromium.org/viewvc/chrome/trunk/src/views/view.cc?r1=38135&r2=38134
M http://src.chromium.org/viewvc/chrome/trunk/src/views/view.h?r1=38135&r2=38134
M http://src.chromium.org/viewvc/chrome/trunk/src/views/view_gtk.cc?r1=38135&r2=38134
M http://src.chromium.org/viewvc/chrome/trunk/src/views/view_win.cc?r1=38135&r2=38134
Adding drag-drop support in and out of the Browser Action overflow menu.
BUG=26990
TEST=Drag icons into and out of (and within) both the Browser Action container and its overflow menu.
Review URL: http://codereview.chromium.org/570014
------------------------------------------------------------------------
|
|||||||||||||||||||||||||||
,
Feb 06, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=38174
------------------------------------------------------------------------
r38174 | finnur@chromium.org | 2010-02-04 19:34:54 -0800 (Thu, 04 Feb 2010) | 8 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.cc?r1=38174&r2=38173
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.h?r1=38174&r2=38173
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/extensions/browser_action_overflow_menu_controller.cc?r1=38174&r2=38173
Now showing the browser action image (including badge) when dragging and
showing the badge in the overflow menu.
BUG=26990
TEST=Browser actions in container/overflow should show image and badge and
also while dragging back and forth.
Review URL: http://codereview.chromium.org/575016
------------------------------------------------------------------------
|
|||||||||||||||||||||||||||
,
Feb 10, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=38632
------------------------------------------------------------------------
r38632 | andybons@chromium.org | 2010-02-10 09:57:01 -0800 (Wed, 10 Feb 2010) | 6 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.h?r1=38632&r2=38631
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/autocomplete_text_field_editor.mm?r1=38632&r2=38631
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/extensions/browser_action_button.h?r1=38632&r2=38631
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/extensions/browser_action_button.mm?r1=38632&r2=38631
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.h?r1=38632&r2=38631
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm?r1=38632&r2=38631
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/extensions/extension_action_context_menu.h?r1=38632&r2=38631
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/extensions/extension_action_context_menu.mm?r1=38632&r2=38631
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.mm?r1=38632&r2=38631
[Mac] Use the ExtensionToolbarModel for ordering of the Browser Actions. Prep for drag and drop for re-ordering.
Also fixes crashers where if you tried to disable an extension via its context menu while an incognito window was key, boom.
BUG=26990
TEST=none
Review URL: http://codereview.chromium.org/595017
------------------------------------------------------------------------
|
|||||||||||||||||||||||||||
,
Feb 11, 2010
Issue 35377 has been merged into this issue. |
|||||||||||||||||||||||||||
,
Feb 16, 2010
(No comment was entered for this change.)
Labels: -Area-Feature Area-UI
|
|||||||||||||||||||||||||||
,
Feb 17, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=39231
------------------------------------------------------------------------
r39231 | andybons@chromium.org | 2010-02-17 09:33:01 -0800 (Wed, 17 Feb 2010) | 7 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view.h?r1=39231&r2=39230
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view.mm?r1=39231&r2=39230
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.h?r1=39231&r2=39230
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm?r1=39231&r2=39230
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.mm?r1=39231&r2=39230
[Mac] Adds grippys to the left side of the Browser Actions container to resize the container (they do not work yet), refactors a bunch of code out of toolbar_controller.mm and adds a slight gradient'ed divider between the container and the page/wrench menus buttons.
http://imgur.com/OqKGF.png
TEST=none
BUG=26990
Review URL: http://codereview.chromium.org/606079
------------------------------------------------------------------------
|
|||||||||||||||||||||||||||
,
Feb 17, 2010
The mouse hover pop ups do not work on extensions in overflow list. Can this fixed |
|||||||||||||||||||||||||||
,
Feb 17, 2010
@53: That would be Issue 35345. |
|||||||||||||||||||||||||||
,
Mar 02, 2010
Issue chromium-os:1736 has been merged into this issue. |
|||||||||||||||||||||||||||
,
Mar 08, 2010
(No comment was entered for this change.)
Labels: -Type-Bug Type-Feature
|
|||||||||||||||||||||||||||
,
Mar 09, 2010
(No comment was entered for this change.)
Labels: Mstone-X wasm5kg
|
|||||||||||||||||||||||||||
,
Mar 10, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=41114
------------------------------------------------------------------------
r41114 | andybons@chromium.org | 2010-03-09 18:00:10 -0800 (Tue, 09 Mar 2010) | 12 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller.mm?r1=41114&r2=41113
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/extension_installed_bubble_controller.mm?r1=41114&r2=41113
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view.h?r1=41114&r2=41113
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/extensions/browser_actions_container_view.mm?r1=41114&r2=41113
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.h?r1=41114&r2=41113
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm?r1=41114&r2=41113
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.h?r1=41114&r2=41113
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.mm?r1=41114&r2=41113
[Mac] More progress towards resizing the Browser Actions container.
o Icons fade out as they are moved off screen by resizing the window.
o Dragging the resizer actually resizes the container.
o Known issues include:
+ no chevron.
+ no updating of other windows if the size of the container changes.
+ the cursor is a bit wonky in updating its state.
o Fixes a slew of janky UI bugs relating to having a lot of extensions installed.
BUG=26990,29838
TEST=none
Review URL: http://codereview.chromium.org/657038
------------------------------------------------------------------------
|
|||||||||||||||||||||||||||
,
Mar 10, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=41124
------------------------------------------------------------------------
r41124 | andybons@chromium.org | 2010-03-09 19:11:56 -0800 (Tue, 09 Mar 2010) | 15 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/branches/342/src/chrome/browser/cocoa/browser_window_controller.mm?r1=41124&r2=41123
M http://src.chromium.org/viewvc/chrome/branches/342/src/chrome/browser/cocoa/extension_installed_bubble_controller.mm?r1=41124&r2=41123
M http://src.chromium.org/viewvc/chrome/branches/342/src/chrome/browser/cocoa/extensions/browser_actions_container_view.h?r1=41124&r2=41123
M http://src.chromium.org/viewvc/chrome/branches/342/src/chrome/browser/cocoa/extensions/browser_actions_container_view.mm?r1=41124&r2=41123
M http://src.chromium.org/viewvc/chrome/branches/342/src/chrome/browser/cocoa/extensions/browser_actions_controller.h?r1=41124&r2=41123
M http://src.chromium.org/viewvc/chrome/branches/342/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm?r1=41124&r2=41123
M http://src.chromium.org/viewvc/chrome/branches/342/src/chrome/browser/cocoa/toolbar_controller.h?r1=41124&r2=41123
M http://src.chromium.org/viewvc/chrome/branches/342/src/chrome/browser/cocoa/toolbar_controller.mm?r1=41124&r2=41123
Merge 41114 - [Mac] More progress towards resizing the Browser Actions container.
o Icons fade out as they are moved off screen by resizing the window.
o Dragging the resizer actually resizes the container.
o Known issues include:
+ no chevron.
+ no updating of other windows if the size of the container changes.
+ the cursor is a bit wonky in updating its state.
o Fixes a slew of janky UI bugs relating to having a lot of extensions installed.
BUG=26990,29838
TEST=none
Review URL: http://codereview.chromium.org/657038
TBR=andybons@chromium.org
Review URL: http://codereview.chromium.org/811002
------------------------------------------------------------------------
|
|||||||||||||||||||||||||||
,
Mar 25, 2010
Hey Andy, on ToT I now see that grippy without having any browser actions installed. Just in case you didn't know. :-P |
|||||||||||||||||||||||||||
,
Mar 26, 2010
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=42845
------------------------------------------------------------------------
r42845 | andybons@chromium.org | 2010-03-26 15:31:24 -0700 (Fri, 26 Mar 2010) | 6 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/Toolbar.xib?r1=42845&r2=42844
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/extensions/browser_action_button.h?r1=42845&r2=42844
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/extensions/browser_action_button.mm?r1=42845&r2=42844
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/extensions/browser_actions_controller.mm?r1=42845&r2=42844
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.mm?r1=42845&r2=42844
[Mac] Enables drag N' drop for the buttons within the Browser Actions container. Also fixes an issue where the grippy was being shown when no Browser Actions were installed.
Known issue: You can drag the buttons outside of the container, even though they will recover by snapping back into place. This will be fixed in a further revision.
TEST=try dragging browser action buttons in order to reorder them.
BUG=26990
Review URL: http://codereview.chromium.org/1418003
------------------------------------------------------------------------
|
|||||||||||||||||||||||||||
,
Mar 26, 2010
(No comment was entered for this change.)
Status: Fixed
|
|||||||||||||||||||||||||||
,
Mar 26, 2010
Thank you! |
|||||||||||||||||||||||||||
,
Mar 31, 2010
Google Chrome 5.0.365.0 (Official Build 43016) unknown WebKit 533.3 V8 2.2.0
Status: Verified
|
|||||||||||||||||||||||||||
,
Apr 23, 2010
Closely related issue: issue 42441 |
|||||||||||||||||||||||||||
| ► Sign in to add a comment | |||||||||||||||||||||||||||