My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 257634: adhd often fails compile on CrOS fox canary
1 person starred this issue and may be notified of changes. Back to list
Status:  Verified
Owner:  cwo...@chromium.org
Closed:  Aug 2013
Cc:  dgr...@chromium.org, th...@chromium.org


Sign in to add a comment
 
Project Member Reported by cwo...@chromium.org, Jul 5, 2013
Problem is a race condition in the install. The modules can not be relinked until libcras is installed to the staging directory, but automake does not create a dependency between the installation steps.

adhd-0.0.1-r538: libtool: install: warning: relinking `libasound_module_ctl_cras.la'
adhd-0.0.1-r538: libtool: install: warning: relinking `libasound_module_pcm_cras.la'
...
adhd-0.0.1-r538: /usr/x86_64-pc-linux-gnu/x86_64-cros-linux-gnu/binutils-bin/2.22/ld.gold.real: error: cannot find -lcras
adhd-0.0.1-r538: collect2: error: ld returned 1 exit status
adhd-0.0.1-r538: /usr/x86_64-pc-linux-gnu/x86_64-cros-linux-gnu/binutils-bin/2.22/ld.gold.real: error: cannot find -lcras
adhd-0.0.1-r538: collect2: error: ld returned 1 exit status

Jul 8, 2013
#1 bugdro...@chromium.org
Project: chromiumos/third_party/adhd
Branch : master
Author : Chris Wolfe <cwolfe@chromium.org>
Commit : 5e382e8faa085ca49768d4fbaf771ea64c3aabe4

Code Review +2: Dylan Reid
Verified    +1: Chris Wolfe
Change-Id     : I39a51d85fbbbe7e8b9a1f48441a32813a4e5c5ba
Reviewed-at   : https://gerrit.chromium.org/gerrit/61026

Add dependency between installation rules.

Because of limitations in automake, there is a race between
installing libcras and libtool's relinking of the modules. This
occasionally causes the Chrome OS builders to fail, and need to
retry this package.

This change forces a dependency between the installation steps
to prevent the race condition. Tested by adding a sleep in the
generated install-lib_LTLIBRARIES rules, to produce the race every
time.

BUG=chromium:257634
TEST=Manual

Commit-Queue: Chris Wolfe <cwolfe@chromium.org>

M  cras/src/Makefile.am
Aug 22, 2013
#2 vapier@chromium.org
(No comment was entered for this change.)
Status: Fixed
Sep 5, 2013
#3 patri...@chromium.org
(No comment was entered for this change.)
Status: Verified
Sign in to add a comment

Powered by Google Project Hosting