Issue 24881 - chromium - You should be able to use (slightly) bigger icons in browser actions (and maybe page actions)

Issue 24881:	You should be able to use (slightly) bigger icons in browser actions (and maybe page actions)
	1 person starred this issue and may be notified of changes.	Back to list

Status:	Fixed
Owner:	aa@chromium.org
Closed:	Oct 19
Type-Bug
Pri-1
OS-All
Area-Extensions
Mstone-4
ReleaseBlock-Beta
Feature-Extensions
ext

Reported by aa@chromium.org, Oct 15, 2009

Glen and Cole claim the max size is 19, and that page and browser actions are 
the same. When I measured it on the mocks, it looked more like 21 and that 
page actions were smaller.

Comment 1 by bugdroid1@chromium.org, Oct 18, 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=29365 

------------------------------------------------------------------------
r29365 | aa@chromium.org | 2009-10-16 18:03:26 -0700 (Fri, 16 Oct 2009) | 20 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/image_loading_tracker.cc?r1=29365&r2=29364
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/image_loading_tracker.h?r1=29365&r2=29364
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc?r1=29365&r2=29364
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc?r1=29365&r2=29364
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.cc?r1=29365&r2=29364
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/location_bar_view.cc?r1=29365&r2=29364
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension.cc?r1=29365&r2=29364
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension.h?r1=29365&r2=29364
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/icon_size_test
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/icon_size_test/icon.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/icon_size_test/manifest.json

Allow slightly larger browser and page action icons.

This allows 19px icons to be able to be used for both
browser and page icons.

I think it looks nicer with the page actions slightly smaller, and that is what we also usually do in Chrome,
but some Chrome location bar icons use 18px for soft edges,
so I guess this will just have to be something we advise
developers on.

We can actually fit up to 21 (whoa nelly) pixels on Windows,
but apparently the space is slightly smaller on mac.

Also minor layout fix. We were sizing the browser action
buttons 1px too short.

BUG=24881
TEST=Load chrome/test/data/extensions/samples/icon_size_test. Icons should be 17px for the page action and 19px for the browser action and centered nicely in the space.

Review URL: http://codereview.chromium.org/286001
------------------------------------------------------------------------

Comment 2 by aa@chromium.org, Oct 19, 2009

(No comment was entered for this change.)

Status: Fixed

Comment 3 by erikkay@chromium.org, Mar 03, 2010

(No comment was entered for this change.)

Labels: Feature-Extensions

► Sign in to add a comment