My favorites ▼ | Sign in
Logo
Project Home
  
Downloads
  
Wiki
  
Issues
    
New issue | Search
for
| Advanced search | Search tips
Issue 24635: Make page actions API more like browser actions API
1 person starred this issue and may be notified of changes. Back to list
 
Reported by aa@chromium.org, Oct 12, 2009 
See  bug 23879  and design doc: 
http://code.google.com/p/chromium/w/edit/PageActionAPIv2
Comment 1 by mpcomplete@chromium.org, Oct 12, 2009 
(No comment was entered for this change.)
Status: Started
Owner: mpcompl...@chromium.org
Comment 2 by bugdroid1@chromium.org, Oct 14, 2009 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=28912 

------------------------------------------------------------------------
r28912 | mpcomplete@chromium.org | 2009-10-13 16:17:50 -0700 (Tue, 13 Oct 2009) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browser_actions_api.cc?r1=28912&r2=28911
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browser_event_router.cc?r1=28912&r2=28911
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_file_util.cc?r1=28912&r2=28911
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_page_actions_module.cc?r1=28912&r2=28911
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_process_manager.cc?r1=28912&r2=28911
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extensions_service.cc?r1=28912&r2=28911
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc?r1=28912&r2=28911
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/location_bar_view.cc?r1=28912&r2=28911
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension.cc?r1=28912&r2=28911
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension.h?r1=28912&r2=28911
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_action.h?r1=28912&r2=28911
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_constants.cc?r1=28912&r2=28911
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_constants.h?r1=28912&r2=28911
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_unittest.cc?r1=28912&r2=28911
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/resources/extension_process_bindings.js?r1=28912&r2=28911

Update page action manifest parsing to match the new format.

Preserves backwards compatability with the old manifest format.

BUG=24635

Review URL: http://codereview.chromium.org/275007
------------------------------------------------------------------------
Comment 3 by bugdroid1@chromium.org, Oct 18, 2009 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=29335 

------------------------------------------------------------------------
r29335 | mpcomplete@chromium.org | 2009-10-16 14:53:46 -0700 (Fri, 16 Oct 2009) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/browser_action_apitest.cc?r1=29335&r2=29334
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browser_actions_api.cc?r1=29335&r2=29334
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc?r1=29335&r2=29334
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_page_actions_module.cc?r1=29335&r2=29334
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_page_actions_module.h?r1=29335&r2=29334
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_page_actions_module_constants.cc?r1=29335&r2=29334
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_page_actions_module_constants.h?r1=29335&r2=29334
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/page_action_apitest.cc
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc?r1=29335&r2=29334
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/location_bar_view_gtk.h?r1=29335&r2=29334
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.cc?r1=29335&r2=29334
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.h?r1=29335&r2=29334
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/location_bar_view.cc?r1=29335&r2=29334
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=29335&r2=29334
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/api/extension_api.json?r1=29335&r2=29334
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/pageAction.html
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_action.h?r1=29335&r2=29334
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/extension_process_bindings.cc?r1=29335&r2=29334
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/resources/extension_process_bindings.js?r1=29335&r2=29334
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/browser_action/manifest.json?r1=29335&r2=29334
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/page_action
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/page_action/background.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/page_action/icon.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/page_action/manifest.json
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/page_action/update.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/page_action/update2.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/test_page_action
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/test_page_action/background.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/test_page_action/manifest.json
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/test_page_action/print_16x16.png

Implement new page action API.

Still no actual drawing code for badges, though.

BUG=24635
TEST=Load the sample test_page_action extension and click the page action to cycle through various states.

Review URL: http://codereview.chromium.org/269079
------------------------------------------------------------------------
Comment 4 by erikkay@chromium.org, Oct 19, 2009 
Split off popups into  issue 25216 .
Comment 5 by erikkay@chromium.org, Oct 19, 2009 
scratch that, I mean:  issue 24645  and 24644.
Comment 6 by bugdroid1@chromium.org, Oct 19, 2009 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=29457 

------------------------------------------------------------------------
r29457 | mpcomplete@chromium.org | 2009-10-19 14:08:30 -0700 (Mon, 19 Oct 2009) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browser_actions_api.cc?r1=29457&r2=29456
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_page_actions_module.cc?r1=29457&r2=29456
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc?r1=29457&r2=29456
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/location_bar_view_gtk.h?r1=29457&r2=29456
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.cc?r1=29457&r2=29456
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/location_bar_view.cc?r1=29457&r2=29456
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/location_bar_view.h?r1=29457&r2=29456
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_action.cc?r1=29457&r2=29456
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_action.h?r1=29457&r2=29456
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/test_browser_action/background.html?r1=29457&r2=29456
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/test_page_action/background.html?r1=29457&r2=29456

Implement badges for page actions. Also add badge text color API.

Also change color APIs from wanting ARGB to RGBA.

BUG=24635
BUG=24644
BUG=25215

Review URL: http://codereview.chromium.org/291003
------------------------------------------------------------------------
Comment 7 by aa@chromium.org, Oct 19, 2009 
(No comment was entered for this change.)
Status: Fixed
Comment 8 by bugdroid1@chromium.org, Oct 20, 2009 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=29509 

------------------------------------------------------------------------
r29509 | nsylvain@chromium.org | 2009-10-20 06:33:41 -0700 (Tue, 20 Oct 2009) | 15 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browser_actions_api.cc?r1=29509&r2=29508
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_page_actions_module.cc?r1=29509&r2=29508
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc?r1=29509&r2=29508
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/location_bar_view_gtk.h?r1=29509&r2=29508
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.cc?r1=29509&r2=29508
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/location_bar_view.cc?r1=29509&r2=29508
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/location_bar_view.h?r1=29509&r2=29508
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_action.cc?r1=29509&r2=29508
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_action.h?r1=29509&r2=29508
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/test_browser_action/background.html?r1=29509&r2=29508
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/test_page_action/background.html?r1=29509&r2=29508

Revert 29457, because this is making ExtensionBrowserTest.PageAction crash on Vista

Original description:
Implement badges for page actions. Also add badge text color API.

Also change color APIs from wanting ARGB to RGBA.

BUG=24635
BUG=24644
BUG=25215

Review URL: http://codereview.chromium.org/291003

TBR=mpcomplete@chromium.org
Review URL: http://codereview.chromium.org/306004
------------------------------------------------------------------------
Comment 9 by bugdroid1@chromium.org, Oct 20, 2009 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=29556 

------------------------------------------------------------------------
r29556 | mpcomplete@chromium.org | 2009-10-20 13:13:24 -0700 (Tue, 20 Oct 2009) | 13 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browser_actions_api.cc?r1=29556&r2=29555
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_page_actions_module.cc?r1=29556&r2=29555
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc?r1=29556&r2=29555
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/location_bar_view_gtk.h?r1=29556&r2=29555
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.cc?r1=29556&r2=29555
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/location_bar_view.cc?r1=29556&r2=29555
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/location_bar_view.h?r1=29556&r2=29555
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_action.cc?r1=29556&r2=29555
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_action.h?r1=29556&r2=29555
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/test_browser_action/background.html?r1=29556&r2=29555
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/test_page_action/background.html?r1=29556&r2=29555

Revert "Revert 29457, because this is making ExtensionBrowserTest.PageAction crash on Vista"

Original description:

Implement badges for page actions. Also add badge text color API.

Also change color APIs from wanting ARGB to RGBA.

BUG=24635
BUG=24644
BUG=25215

Review URL: http://codereview.chromium.org/293031
------------------------------------------------------------------------
Comment 10 by bugdroid1@chromium.org, Oct 22, 2009 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=29822 

------------------------------------------------------------------------
r29822 | jon@chromium.org | 2009-10-22 14:34:26 -0700 (Thu, 22 Oct 2009) | 18 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/223/src/chrome/browser/extensions/extension_browser_actions_api.cc?r1=29822&r2=29821
   M http://src.chromium.org/viewvc/chrome/branches/223/src/chrome/browser/extensions/extension_page_actions_module.cc?r1=29822&r2=29821
   M http://src.chromium.org/viewvc/chrome/branches/223/src/chrome/browser/gtk/location_bar_view_gtk.cc?r1=29822&r2=29821
   M http://src.chromium.org/viewvc/chrome/branches/223/src/chrome/browser/gtk/location_bar_view_gtk.h?r1=29822&r2=29821
   M http://src.chromium.org/viewvc/chrome/branches/223/src/chrome/browser/views/browser_actions_container.cc?r1=29822&r2=29821
   M http://src.chromium.org/viewvc/chrome/branches/223/src/chrome/browser/views/location_bar_view.cc?r1=29822&r2=29821
   M http://src.chromium.org/viewvc/chrome/branches/223/src/chrome/browser/views/location_bar_view.h?r1=29822&r2=29821
   M http://src.chromium.org/viewvc/chrome/branches/223/src/chrome/common/extensions/extension_action.cc?r1=29822&r2=29821
   M http://src.chromium.org/viewvc/chrome/branches/223/src/chrome/common/extensions/extension_action.h?r1=29822&r2=29821
   M http://src.chromium.org/viewvc/chrome/branches/223/src/chrome/test/data/extensions/samples/test_browser_action/background.html?r1=29822&r2=29821
   M http://src.chromium.org/viewvc/chrome/branches/223/src/chrome/test/data/extensions/samples/test_page_action/background.html?r1=29822&r2=29821

Merge 29509 - Revert 29457, because this is making ExtensionBrowserTest.PageAction crash on Vista

Original description:
Implement badges for page actions. Also add badge text color API.

Also change color APIs from wanting ARGB to RGBA.

BUG=24635
BUG=24644
BUG=25215

Review URL: http://codereview.chromium.org/291003

TBR=mpcomplete@chromium.org
Review URL: http://codereview.chromium.org/306004

TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/324006
------------------------------------------------------------------------
Comment 11 by bugdroid1@chromium.org, Oct 22, 2009 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=29823 

------------------------------------------------------------------------
r29823 | jon@chromium.org | 2009-10-22 14:37:21 -0700 (Thu, 22 Oct 2009) | 16 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/223/src/chrome/browser/extensions/extension_browser_actions_api.cc?r1=29823&r2=29822
   M http://src.chromium.org/viewvc/chrome/branches/223/src/chrome/browser/extensions/extension_page_actions_module.cc?r1=29823&r2=29822
   M http://src.chromium.org/viewvc/chrome/branches/223/src/chrome/browser/gtk/location_bar_view_gtk.cc?r1=29823&r2=29822
   M http://src.chromium.org/viewvc/chrome/branches/223/src/chrome/browser/gtk/location_bar_view_gtk.h?r1=29823&r2=29822
   M http://src.chromium.org/viewvc/chrome/branches/223/src/chrome/browser/views/browser_actions_container.cc?r1=29823&r2=29822
   M http://src.chromium.org/viewvc/chrome/branches/223/src/chrome/browser/views/location_bar_view.cc?r1=29823&r2=29822
   M http://src.chromium.org/viewvc/chrome/branches/223/src/chrome/browser/views/location_bar_view.h?r1=29823&r2=29822
   M http://src.chromium.org/viewvc/chrome/branches/223/src/chrome/common/extensions/extension_action.cc?r1=29823&r2=29822
   M http://src.chromium.org/viewvc/chrome/branches/223/src/chrome/common/extensions/extension_action.h?r1=29823&r2=29822
   M http://src.chromium.org/viewvc/chrome/branches/223/src/chrome/test/data/extensions/samples/test_browser_action/background.html?r1=29823&r2=29822
   M http://src.chromium.org/viewvc/chrome/branches/223/src/chrome/test/data/extensions/samples/test_page_action/background.html?r1=29823&r2=29822

Merge 29556 - Revert "Revert 29457, because this is making ExtensionBrowserTest.PageAction crash on Vista"

Original description:

Implement badges for page actions. Also add badge text color API.

Also change color APIs from wanting ARGB to RGBA.

BUG=24635
BUG=24644
BUG=25215

Review URL: http://codereview.chromium.org/293031

TBR=mpcomplete@chromium.org
Review URL: http://codereview.chromium.org/306059
------------------------------------------------------------------------
Comment 12 by erikkay@chromium.org, Mar 03, 2010 
(No comment was entered for this change.)
Labels: Feature-Extensions
► Sign in to add a comment

Powered by Google Project Hosting