| Issue 24401: | Chromium thinks it is the default when Safari is the default | |
| 5 people starred this issue and may be notified of changes. | Back to list |
Sign in to add a comment
|
Chrome Version : 4.0.222.2 (28505) OS version : 10.6.1 What steps will reproduce the problem? 1. Using Safari Set Default browser to Chromium.app 2. Open chromium and see the non-default browser message 3. Select make default browser 4. Restart safari and see that Safari is now set as the default browser 5. Restart Chromium and see that it thinks it is still the default What is the expected result? Chromium should know itself What happens instead? Chromium thinks it is safari |
||||||||||||||||||||
,
Oct 09, 2009
(No comment was entered for this change.)
Status: Assigned
Owner: pinker...@chromium.org Labels: -Area-Misc -Pri-2 Area-BrowserUI Pri-1 Mstone-4 ReleaseBlock-Beta |
|||||||||||||||||||||
,
Oct 09, 2009
This was caused by Mark's bundling changes. The default browser code expects the main app bundle to be org.chromium.chromium because that's what other apps will set. However, when we set the default browser ourselves, we set it to org.chromium.chromium.framework because that's our "main bundle". As a result, it doesn't match what Safari sees, so it continues to display the default browser as Safari (because it can't find an app with that bundle). Conversely, when safari sets it, it doesn't match our expectations and we think we're not the default browser. Mark, which API should we be using here now that MainAppBundle() has changed meaning?
Cc: m...@chromium.org
|
|||||||||||||||||||||
,
Oct 09, 2009
(No comment was entered for this change.)
Status: Started
|
|||||||||||||||||||||
,
Oct 13, 2009
(No comment was entered for this change.)
Status: Fixed
|
|||||||||||||||||||||
,
Oct 14, 2009
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=28813
------------------------------------------------------------------------
r28813 | pinkerton@chromium.org | 2009-10-13 07:12:45 -0700 (Tue, 13 Oct 2009) | 4 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/shell_integration_mac.mm?r1=28813&r2=28812
Use the real bundle identifier instead of the framework's identifier for detecting default browser identifier.
BUG=24401
TEST=set default to chromium from safari, verify chromium thinks it's default. set default to safari in safari, verify chromium thinks it's not default. Then set it to default and verify Safari thinks Chromium is default.
Review URL: http://codereview.chromium.org/261039
------------------------------------------------------------------------
|
|||||||||||||||||||||
,
Oct 15, 2009
4.0.223.0 (Official Build 29072)
Status: Verified
|
|||||||||||||||||||||
,
Oct 21, 2009
Issue 25473 has been merged into this issue. |
|||||||||||||||||||||
| ► Sign in to add a comment | |||||||||||||||||||||