(No comment was entered for this change.)

Just as an FYI: Having multiple Browser Actions per extension means implementing 
something similar to Page Actions, where the Chrome support js makes a native call into 
Chrome to find out what Browser Actions the extension supports and sets up events for 
each one.

Yeah, I figure it should be pretty easy to combine the best parts of both these APIs (?
).

Sure. I have no problem with that.

(No comment was entered for this change.)

Bumping to P1 as it is a large API change.

I've put a draft of how to do this here:

http://code.google.com/p/chromium/wiki/BrowserActions
http://code.google.com/p/chromium/wiki/PageActionAPIv2

Please let me know what you think.

Good stuff.

Out of curiosity... in what scenario does it make sense to update the browser action 
tooltip per tab? 

I presume details of dragging etc. apply to Browser Actions also, even though they are 
only specified for Page Actions?

nit: the documentation for setBadgeText should appear before setBadgeBackgroundColor 
and setBadgeTextColor. It would give the two latter functions more context.

 

To be honest, I think the tooltip component is pretty uninteresting. I include it 
mainly for consistency with other things in the toolbar that also have tooltips.

But playing along, say you had a 'bookmark in delicious' browser action. If a tab is 
already bookmarked you might want to change the icon, and change the tooltip to say 
'edit bookmark'.

Splitting into two bugs: one for browser actions and one for page actions.

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=29068 

------------------------------------------------------------------------
r29068 | aa@chromium.org | 2009-10-14 17:02:24 -0700 (Wed, 14 Oct 2009) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser.cc?r1=29068&r2=29067
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browser_actions_api.cc?r1=29068&r2=29067
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browser_actions_api.h?r1=29068&r2=29067
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browser_event_router.cc?r1=29068&r2=29067
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browser_event_router.h?r1=29068&r2=29067
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc?r1=29068&r2=29067
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/image_loading_tracker.cc?r1=29068&r2=29067
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc?r1=29068&r2=29067
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.cc?r1=29068&r2=29067
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/api/extension_api.json?r1=29068&r2=29067
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/browserAction.html?r1=29068&r2=29067
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_resource_unittest.cc?r1=29068&r2=29067
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/extension_process_bindings.cc?r1=29068&r2=29067
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/resources/extension_process_bindings.js?r1=29068&r2=29067
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/gmail_browser_action/background.html?r1=29068&r2=29067
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/make_page_red/background.html?r1=29068&r2=29067
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/print_browser_action/background.html?r1=29068&r2=29067
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/test_browser_action/background.html?r1=29068&r2=29067
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/test_browser_action/manifest.json?r1=29068&r2=29067

Update browser actions api to be like new design doc.

BUG=23879
TEST=Install sample gmail browser action sample.

Review URL: http://codereview.chromium.org/264046
------------------------------------------------------------------------

(No comment was entered for this change.)

(No comment was entered for this change.)

Fixing a bulk edit. Looks like the search query was not correct.

(No comment was entered for this change.)