Issue 23833 - chromium - browser actions: popups should have a nice border

Issue 23833:	browser actions: popups should have a nice border
	2 people starred this issue and may be notified of changes.	Back to list

Status:	Fixed
Owner:	erikkay@chromium.org
Closed:	Oct 07
Type-Bug
Pri-1
OS-All
Area-Extensions
Mstone-4
ReleaseBlock-Beta
Feature-Extensions
ext

Reported by erikkay@chromium.org, Oct 05, 2009

See the mocks in  issue 23596  for an example.

For now, we'll make the border fixed.  In the future, we may want to support 
a 9-grid API to allow authors to do something custom.

Comment 1 by aa@chromium.org, Oct 05, 2009

(No comment was entered for this change.)

Labels: Mstone-4 ReleaseBlock-Beta

Comment 2 by aa@chromium.org, Oct 05, 2009

(No comment was entered for this change.)

Labels: -Pri-2 Pri-1

Comment 3 by erikkay@chromium.org, Oct 05, 2009

(No comment was entered for this change.)

Status: Started
Owner: erik...@chromium.org

Comment 4 by bugdroid1@chromium.org, Oct 06, 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=28187 

------------------------------------------------------------------------
r28187 | erikkay@chromium.org | 2009-10-06 16:50:06 -0700 (Tue, 06 Oct 2009) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.cc?r1=28187&r2=28186
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_bubble.h?r1=28187&r2=28186
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_bubble_win.cc?r1=28187&r2=28186
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/bubble_border.cc?r1=28187&r2=28186
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/bubble_border.h?r1=28187&r2=28186
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/extensions/extension_popup.cc?r1=28187&r2=28186
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/extensions/extension_popup.h?r1=28187&r2=28186
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/set_page_color/manifest.json?r1=28187&r2=28186
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/set_page_color/popup.html?r1=28187&r2=28186

Add an BubbleBorder to BrowserAction popups and fix positioning of the
popup.

BUG=23833,23835
TEST=none

Review URL: http://codereview.chromium.org/259065
------------------------------------------------------------------------

Comment 5 by erikkay@chromium.org, Oct 07, 2009

(No comment was entered for this change.)

Status: Fixed

Comment 6 by erikkay@chromium.org, Mar 03, 2010

(No comment was entered for this change.)

Labels: Feature-Extensions

► Sign in to add a comment