Issue 23832 - chromium - browser actions: popup should be able to close itself

Issue 23832:	browser actions: popup should be able to close itself
	1 person starred this issue and may be notified of changes.	Back to list

Status:	Fixed
Owner:	erikkay@chromium.org
Closed:	Oct 06
Type-Bug
Pri-2
OS-All
Area-Extensions
Mstone-4
ReleaseBlock-Beta
Feature-Extensions
ext

Reported by erikkay@chromium.org, Oct 05, 2009

The popup code is the only place that really knows when it's done an action 
which should cause it to dismiss.  For simplicity's sake, window.close() 
should just work.

Comment 1 by aa@chromium.org, Oct 05, 2009

(No comment was entered for this change.)

Labels: Mstone-4 ReleaseBlock-Beta

Comment 2 by bugdroid1@chromium.org, Oct 06, 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=28053 

------------------------------------------------------------------------
r28053 | erikkay@chromium.org | 2009-10-05 15:00:05 -0700 (Mon, 05 Oct 2009) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.cc?r1=28053&r2=28052
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.h?r1=28053&r2=28052
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_bubble_win.cc?r1=28053&r2=28052
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages.h?r1=28053&r2=28052
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/set_page_color/popup.html?r1=28053&r2=28052

Allow popups to close themselves with window.close().

This also fixes an issue where not all of the parts of WebPreferences were being serialized/deserialized across IPC.

BUG=23832
TEST=run set_page_color extension, when it sets the color, the popup
should close

Review URL: http://codereview.chromium.org/243096
------------------------------------------------------------------------

Comment 3 by bugdroid1@chromium.org, Oct 06, 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=28115 

------------------------------------------------------------------------
r28115 | erikkay@chromium.org | 2009-10-06 09:11:44 -0700 (Tue, 06 Oct 2009) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.cc?r1=28115&r2=28114
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.h?r1=28115&r2=28114
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_bubble_win.cc?r1=28115&r2=28114
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages.h?r1=28115&r2=28114
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/set_page_color/popup.html?r1=28115&r2=28114

Resubmit http://codereview.chromium.org/243096 with gcc compile error fixed.

BUG=23832
TBR=mpcomplete

Review URL: http://codereview.chromium.org/257056
------------------------------------------------------------------------

Comment 4 by erikkay@chromium.org, Oct 06, 2009

(No comment was entered for this change.)

Status: Fixed

Comment 5 by erikkay@chromium.org, Mar 03, 2010

(No comment was entered for this change.)

Labels: Feature-Extensions

► Sign in to add a comment