| Issue 23593: | browser action button disappears when loading a new extension | |
| 1 person starred this issue and may be notified of changes. | Back to list |
Sign in to add a comment
|
I had the print button browser action loaded via --load-extension. I then manually loaded mappy from chrome://extensions. When I did that, the print browser action button disappeared (although the space for the button remained). |
||||||||||||||||||
,
Oct 01, 2009
This also reproduces for me if I "reload" an extension with a browser action. |
|||||||||||||||||||
,
Oct 02, 2009
(No comment was entered for this change.)
Status: Assigned
Owner: sidc...@chromium.org |
|||||||||||||||||||
,
Oct 14, 2009
(No comment was entered for this change.)
Status: Started
|
|||||||||||||||||||
,
Oct 15, 2009
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=29143
------------------------------------------------------------------------
r29143 | sidchat@chromium.org | 2009-10-15 11:00:38 -0700 (Thu, 15 Oct 2009) | 5 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/toolbar_view.cc?r1=29143&r2=29142
Fix bug: browser action button disappears when loading a new extension. This was happenening because BrowserActionContainer, on receiving notification about an extension load/unload/change, deletes all BrowserAction views, re-adds all the views again, and asks the toolbar to SetBounds for the BrowserActionContainer. However, during deletion, it does not re-set the bounds. As a result, when SetBounds is called by the toolbar again, it does not see any changed in BrowserActionContainer, and does not layout again, causing all the browser actions to disappear. The solution lies in forcing Layout() after SetBounds() in ToolbarView.
BUG=23593
TEST=none
Review URL: http://codereview.chromium.org/276033
------------------------------------------------------------------------
|
|||||||||||||||||||
,
Oct 15, 2009
(No comment was entered for this change.)
Status: Fixed
|
|||||||||||||||||||
,
Mar 03, 2010
(No comment was entered for this change.)
Labels: Feature-Extensions
|
|||||||||||||||||||
| ► Sign in to add a comment | |||||||||||||||||||