My favorites ▼ | Sign in
Logo
Project Home
  
Downloads
  
Wiki
  
Issues
    
New issue | Search
for
| Advanced search | Search tips
Issue 23269: Browser actions: implement setIcon(ImageData)
2 people starred this issue and may be notified of changes. Back to list
 
Reported by aa@chromium.org, Sep 28, 2009 
You should be able to draw the browser action icon dynamically using the 
ImageData object from canvas.
Comment 1 by mpcomplete@chromium.org, Sep 29, 2009 
(No comment was entered for this change.)
Status: Started
Owner: mpcompl...@chromium.org
Comment 2 by mpcomplete@chromium.org, Sep 29, 2009 
(No comment was entered for this change.)
Status: Available
Owner: ---
Comment 3 by aa@chromium.org, Oct 05, 2009 
(No comment was entered for this change.)
Labels: ReleaseBlock-Beta
Comment 4 by aa@chromium.org, Oct 05, 2009 
(No comment was entered for this change.)
Status: Started
Owner: mpcompl...@chromium.org
Labels: Size-Large
Comment 5 by aa@chromium.org, Oct 05, 2009 
Marking this P1 because it is an important thing to try and prove works asap.
Labels: Pri-1
Comment 6 by bugdroid1@chromium.org, Oct 06, 2009 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=28130 

------------------------------------------------------------------------
r28130 | mpcomplete@chromium.org | 2009-10-06 11:15:58 -0700 (Tue, 06 Oct 2009) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/values.cc?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/values.h?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_extension_function.cc?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_extension_function.h?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/dom_ui.cc?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/dom_ui.h?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_dom_ui.cc?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_dom_ui.h?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_function.cc?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_function.h?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_function_dispatcher.cc?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_function_dispatcher.h?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.cc?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.h?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_view_host.cc?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_view_host.h?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_view_host_delegate.h?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.cc?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.h?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages_internal.h?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/extension_api_client_unittest.cc?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/extension_process_bindings.cc?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view.cc?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view.h?r1=28130&r2=28129
   M http://src.chromium.org/viewvc/chrome/trunk/src/ipc/ipc_message_utils.cc?r1=28130&r2=28129

Modify extension request IPC messages to pass a ListValue instead of a string.

This allows us to pass binary values through extension requests. I use this in
my next CL to pass SkBitmaps.

BUG=23269
TEST=no

Review URL: http://codereview.chromium.org/251093
------------------------------------------------------------------------
Comment 7 by bugdroid1@chromium.org, Oct 06, 2009 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=28136 

------------------------------------------------------------------------
r28136 | mpcomplete@chromium.org | 2009-10-06 11:56:51 -0700 (Tue, 06 Oct 2009) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browser_actions_api.cc?r1=28136&r2=28135
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.cc?r1=28136&r2=28135
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/api/extension_api.json?r1=28136&r2=28135
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_action.h?r1=28136&r2=28135
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/extensions/extension_process_bindings.cc?r1=28136&r2=28135
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/resources/extension_process_bindings.js?r1=28136&r2=28135
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/test_browser_action/background.html?r1=28136&r2=28135

Implement browserAction.setIcon(ImageData) for extensions.

BUG=23269
TEST=load the test_browser_action sample extension, and click the browser action. Watch it dynamically update.

Review URL: http://codereview.chromium.org/242150
------------------------------------------------------------------------
Comment 8 by mpcomplete@chromium.org, Oct 06, 2009 
(No comment was entered for this change.)
Status: Fixed
Comment 9 by erikkay@chromium.org, Mar 03, 2010 
(No comment was entered for this change.)
Labels: Feature-Extensions
► Sign in to add a comment

Powered by Google Project Hosting