Issue 23031 - chromium - Extension Shelf on Linux doesn't use GTK theme colors

Issue 23031:	Extension Shelf on Linux doesn't use GTK theme colors
	3 people starred this issue and may be notified of changes.	Back to list

Status:	Fixed
Owner:	----
Closed:	Sep 28
Cc:	erg@chromium.org
Type-Bug
Pri-2
OS-Linux
Area-BrowserUI
Size-Small

Reported by benjo316, Sep 25, 2009

Chrome Version       : 4.0.219.0 (Developer Build Ubuntu build 27064)
URLs (if applicable) : N/A
Other browsers tested: N/A

What steps will reproduce the problem?
1. Have an extension that uses the extension shelf
2. Options -> Personal Stuff -> Set to GTK+ theme
3. Observe the default colors aren't consistent (text comes from GTK theme, 
but background doesn't)

What is the expected result?
Shelf takes colors from GTK+ theme.

What happens instead?
Default (hard-coded?) color is used.

Please provide any additional information below. Attach a screenshot if
possible.

It appears that the shelf is getting the default text color from the 
desktop theme (when the theme is set to the GTK+ theme, at least). In that 
case, wouldn't it make sense to get the background color from GTK too?

As it is, the shelf doesn't match the rest of the UI when it is set to the 
GTK+ theme, and it can be hard to read the text in the shelf when it is set 
to a bright color.

	Screenshot-New Tab - Chromium.png 19.0 KB View Download

Comment 1 by CalebEgg, Sep 25, 2009

(No comment was entered for this change.)

Status: Untriaged
Cc: e...@chromium.org
Labels: -OS-All -Area-Misc OS-Linux Area-BrowserUI Size-Small

Comment 2 by erg@chromium.org, Sep 25, 2009

While I can confirm that we aren't themeing the extension shelf yet, I don't know why 
your text is green there. That text is supposed to be hard coded to black.

What gtk theme are you running?

Comment 3 by benjo316, Sep 25, 2009

Just plain "Clearlooks". (That is to say, not "Human-Clearlooks" or 
"ClearlooksClassic")

Comment 4 by erg@chromium.org, Sep 25, 2009

Are you sure? I'm looking at Clearlooks right now and it doesn't have green and orange 
text and Clearlooks has a light gray background instead of a black one...

(Also, I've found the place where we aren't updating the CSS properly.)

Status: Started

Comment 5 by benjo316, Sep 25, 2009

Yeah, I customized the colors (colors tab, under "customize..." in Ubuntu's Appearance 
Preferences). It's apparently using the input box text color, which I set as #B8EEA5. I tried changing it to a red color and reloading the extension, and the color of the 
text changed as expected (suspected?).

Comment 6 by bugdroid1@chromium.org, Sep 28, 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=27368 

------------------------------------------------------------------------
r27368 | erg@google.com | 2009-09-28 09:54:09 -0700 (Mon, 28 Sep 2009) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.cc?r1=27368&r2=27367
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/extension_shelf_gtk.cc?r1=27368&r2=27367

Extensions: Listen for BROWSER_THEME_CHANGED and send updated CSS.
GTK: Listen for BROWSER_THEME_CHANGED and upload proper colors.

BUG=23031

Review URL: http://codereview.chromium.org/248006
------------------------------------------------------------------------

Comment 7 by erg@chromium.org, Sep 28, 2009

(No comment was entered for this change.)

Status: Fixed

► Sign in to add a comment