See attached mock!

	menu.png 30.9 KB   View   Download

(No comment was entered for this change.)

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=27599 

------------------------------------------------------------------------
r27599 | aa@chromium.org | 2009-09-30 00:32:01 -0700 (Wed, 30 Sep 2009) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_dll_resource.h?r1=27599&r2=27598
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=27599&r2=27598
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser.cc?r1=27599&r2=27598
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser.h?r1=27599&r2=27598
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/browser_action_test.cc
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.cc?r1=27599&r2=27598
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.h?r1=27599&r2=27598
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/toolbar_view.cc?r1=27599&r2=27598
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/toolbar_view.h?r1=27599&r2=27598
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=27599&r2=27598
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension.cc?r1=27599&r2=27598
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_action.cc?r1=27599&r2=27598
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_action.h?r1=27599&r2=27598
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_unittest.cc?r1=27599&r2=27598
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/make_page_red
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/make_page_red/background.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/make_page_red/icon.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/make_page_red/manifest.json
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/make_page_red_no_icon
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/make_page_red_no_icon/background.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/make_page_red_no_icon/manifest.json

Integrate browser actions with the wrench menu. Browser
actions always show up in a submenu of the wrench menu, and
if they have an icon, they also show up in the toolbar area.

BUG=23380,22883
TEST=Added new automated tests for the command handling, but we need to test that the menu items show up manually. To do that, run with no extension installed, you should see "extensions" in the wrench menu. Add an extension that adds a browser action, you should now see an "extensions" submenu with "manage extensions" and the browser action(s) in the submenu.

Review URL: http://codereview.chromium.org/246037
------------------------------------------------------------------------

(No comment was entered for this change.)

Chrome/mac doesn't display the wrench menu button by default, as the system always 
shows the menu bar anyway. Is this UI decision final? In that case, there should be a 
bug to add "Extensions" to the "Window" menu on OS X. You can assign it to me (and as 
this potentially requires a string change, it's somewhat urgent).

Yeah, I noticed the lack of the wrench menu. I think adding the item to the system menu 
bar makes sense, but we're not implementing any of this on other platforms until we're 
sure we like it.

btw, thakis, we've been told that you don't need to worry about ongoing extension work 
for string freeze.  Our freeze will be more like Oct 31.