| Issue 22589: | desktop shortcut file must me executable | |
| 1 person starred this issue and may be notified of changes. | Back to list |
Sign in to add a comment
|
Desktop files created by chromium are displayed as a text files on the desktop. When double clicked, a popup says it's an "Untrusted application launcher", and proposes to "Launch Anyway", "Mark as Trusted" or "Cancel". (that's with Nautilus 2.27.92 on Ubuntu Karmic) This happens to just be a chmod issue. 755 instead of 644 fixes it. This also turns the text icon to the proper chromium icon. Note that Nautilus creates its launchers with a "#!/usr/bin/env xdg-open" shebang, which while not mandatory, would be good to have too. |
||||||||||||||||||
,
Sep 21, 2009
also see issue 22566
Status: Assigned
Owner: phajdan...@chromium.org |
|||||||||||||||||||
,
Sep 22, 2009
Security guys, please advise. The change in code would be trivial, but I'm not sure about security implications here.
Cc: cev...@chromium.org lcamtuf skyli...@chromium.org
|
|||||||||||||||||||
,
Sep 22, 2009
I think that's OK, assuming the launcher is itself constructed well (it's text-based, so we should make sure there is no shell command injection via unescaped $, |, `, ;, \r, \n, &, ", ', \, >, < anywhere, etc). |
|||||||||||||||||||
,
Sep 23, 2009
(No comment was entered for this change.)
Status: Started
|
|||||||||||||||||||
,
Sep 24, 2009
Can someone remind me how to create an application shortcut on Linux? The "Create Application Shortcuts" option in the page menu doesn't seem to do anything for me. |
|||||||||||||||||||
,
Sep 24, 2009
Should work on ToT. If it doesn't, please file a new bug with your env, location and name of Chrome's .desktop file, and whether you're using Chrome or Chromium. |
|||||||||||||||||||
,
Sep 24, 2009
I'll try ToT. Can you assume for a moment that I'm stupid and give me a click-by-click guide to what to do to create an application shortcut? (Gmail as a concrete example would be useful). |
|||||||||||||||||||
,
Sep 24, 2009
Just doing Page-> Create application shortcuts->Create should work. Make sure that the "Desktop" checkbox is selected. After a while a shortcut should appear on your desktop (it's asynchronous). |
|||||||||||||||||||
,
Sep 25, 2009
(No comment was entered for this change.)
Cc: -skyli...@chromium.org
|
|||||||||||||||||||
,
Sep 25, 2009
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=27194
------------------------------------------------------------------------
r27194 | phajdan.jr@chromium.org | 2009-09-25 09:21:57 -0700 (Fri, 25 Sep 2009) | 11 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/shell_integration_linux.cc?r1=27194&r2=27193
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/shell_integration_unittest.cc?r1=27194&r2=27193
Improve desktop shortcut creation:
- remove more comments (which generally only apply to the browser itself)
- add #!/usr/bin/env xdg-open shebang
- make the .desktop file placed on the desktop executable
- add more tests to make sure we're still secure
TEST=Covered by unit_tests.
BUG=22589
Review URL: http://codereview.chromium.org/232003
------------------------------------------------------------------------
|
|||||||||||||||||||
,
Sep 25, 2009
(No comment was entered for this change.)
Status: Fixed
|
|||||||||||||||||||
| ► Sign in to add a comment | |||||||||||||||||||