My favorites ▼ | Sign in
Logo
Project Home
  
Downloads
  
Wiki
  
Issues
    
New issue | Search
for
| Advanced search | Search tips
Issue 22575: Browser actions (and page actions): Need to be able to decode images on the fly
3 people starred this issue and may be notified of changes. Back to list
 
Reported by finnur@chromium.org, Sep 21, 2009 
I thought there was a bug on this already, but couldn't find it.

During the implementation of PageActions we discussed being able to change 
the icon to something that was not necessarily declared in the manifest. This 
would require changes to how we unpack the images in the renderer.

Now, with the concept of a BrowserAction ( bug 22099 ), this looks to me like 
it is becoming a requirement.
Comment 1 by mpcomplete@chromium.org, Sep 29, 2009 
(No comment was entered for this change.)
Status: Started
Owner: mpcompl...@chromium.org
Comment 2 by aa@chromium.org, Sep 29, 2009 
(No comment was entered for this change.)
Summary: Browser actions (and page actions): Need to be able to decode images on the fly
Comment 3 by mpcomplete@chromium.org, Sep 29, 2009 
(No comment was entered for this change.)
Status: Available
Owner: ---
Comment 4 by aa@chromium.org, Oct 05, 2009 
This should come relatively easily with the dynamic images work.
Labels: Mstone-4 ReleaseBlock-Beta
Comment 5 by aa@chromium.org, Oct 16, 2009 
Bumping this to p1 because the manifest parsing code is in a weird broken state without 
it (we don't allow iconIndex in the new manifest format, but we have no replacement for 
it).
Labels: -Pri-2 Pri-1
Comment 6 by aa@chromium.org, Oct 16, 2009 
(No comment was entered for this change.)
Status: Started
Owner: a...@chromium.org
Comment 7 by bugdroid1@chromium.org, Oct 19, 2009 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=29495 

------------------------------------------------------------------------
r29495 | aa@chromium.org | 2009-10-19 22:16:54 -0700 (Mon, 19 Oct 2009) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/browser_action_apitest.cc?r1=29495&r2=29494
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.cc?r1=29495&r2=29494
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.h?r1=29495&r2=29494
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/api/extension_api.json?r1=29495&r2=29494
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/docs/browserAction.html?r1=29495&r2=29494
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/resources/extension_process_bindings.js?r1=29495&r2=29494
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/update2.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/set_icon_path
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/set_icon_path/background.html
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/set_icon_path/icon1.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/set_icon_path/icon2.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/set_icon_path/icon3.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/set_icon_path/icon4.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/set_icon_path/icon5.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/samples/set_icon_path/manifest.json

Implement chrome.browserAction.setIcon({path:...});

BUG=22575

Review URL: http://codereview.chromium.org/269103
------------------------------------------------------------------------
Comment 8 by aa@chromium.org, Oct 19, 2009 
(No comment was entered for this change.)
Status: Fixed
Comment 9 by erikkay@chromium.org, Mar 03, 2010 
(No comment was entered for this change.)
Labels: Feature-Extensions
► Sign in to add a comment

Powered by Google Project Hosting