| Issue 22558: | Omnibox should draw red bar over "https" for bad certs | |
| 1 person starred this issue and may be notified of changes. | Back to list |
Sign in to add a comment
|
Chrome Version : 4.0.211 What steps will reproduce the problem? 1. Go to a page with a bad https cert What is the expected result? Windows draws a red line through https, see e.g. http://www.joeno1.net/wp/wp- content/uploads/2009/04/chrome_warning_04162009.png . What happens instead? No line on OS X. Not sure about Linux – cc'ing erg for that. |
||||||||||||||||||||
,
Sep 21, 2009
http://codereview.chromium.org/215038/show adds a normal horizontal strikethrough. If this is good enough, I can send it out for review. If we have to have the diagonal strikethrough, then this change won't work :) |
|||||||||||||||||||||
,
Sep 21, 2009
That's probably up the the UI team. CC'ing alcor.
Cc: al...@google.com
|
|||||||||||||||||||||
,
Sep 23, 2009
I checked with Cole - taking the CL for the horizontal red strike though is fine for beta. Thanks!
Status: Assigned
Labels: ReleaseBlock-Beta Mstone-4 |
|||||||||||||||||||||
,
Sep 23, 2009
(No comment was entered for this change.)
Status: Started
|
|||||||||||||||||||||
,
Sep 24, 2009
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=27064
------------------------------------------------------------------------
r27064 | rohitrao@chromium.org | 2009-09-24 07:55:21 -0700 (Thu, 24 Sep 2009) | 5 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm?r1=27064&r2=27063
[Mac] Add a strikethrough through insecure url schemes.
BUG=http://crbug.com/22558
TEST=Go to https://www.twitter.com/. See the cert mismatch warning. Check that "https:// in the omnibox is red with a strikethrough.
Review URL: http://codereview.chromium.org/215038
------------------------------------------------------------------------
|
|||||||||||||||||||||
,
Sep 24, 2009
(No comment was entered for this change.)
Status: Fixed
|
|||||||||||||||||||||
,
Sep 28, 2009
Horizontal strike on https:// Platform: Hostname: Macintosh-0017f2d64524.local Mac OS X Version 10.5.8 (Build 9L27) Processor: 2 Intel 2.33 GHz RAM: 2048 MB Chromium: Chromium version: 4.0.219.4 SVN Revision: 27365 <<<Release>>> QuickTime Player: 7.6.4 QuickTime PlayerX: <unknown> Flash Player: 10.0.32
Status: Verified
|
|||||||||||||||||||||
,
Sep 28, 2009
This was fixed and Verified for Win and Mac. Reproducible on Linux ( UBUNTU ) . Tested on 4.0.219.3 ( Ubuntu build 27338 ).
Status: Untriaged
Cc: kr...@chromium.org Labels: -OS-Mac OS-Linux |
|||||||||||||||||||||
,
Sep 28, 2009
Ismail, can you create a new one for Linux?
Status: Verified
Labels: -OS-Linux OS-Mac |
|||||||||||||||||||||
| ► Sign in to add a comment | |||||||||||||||||||||