My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 21852: Implement WebGL
74 people starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  kbr@chromium.org
Closed:  Dec 2010
Cc:  evan@chromium.org, hbridge@google.com, vangelis@chromium.org, zmo@chromium.org
M-9

Restricted
  • Only users with EditIssue permission may comment.


Sign in to add a comment
 
Project Member Reported by darin@chromium.org, Sep 14, 2009
Implement WebGL

Sep 15, 2009
#1 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=26202 

------------------------------------------------------------------------
r26202 | darin@chromium.org | 2009-09-15 00:05:23 -0700 (Tue, 15 Sep 2009) | 10 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?r1=26202&r2=26201
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/test_expectations.txt?r1=26202&r2=26201

Update WebKit to r48388

This commit introduces a failing webgl test.  I added a skip for
all webgl tests.

TBR=brettw
BUG=21852
TEST=none

Review URL: http://codereview.chromium.org/196117
------------------------------------------------------------------------

Sep 23, 2009
#2 darin@chromium.org
(No comment was entered for this change.)
Status: Available
Labels: -Area-BrowserBackend Area-WebKit
Sep 28, 2009
#3 darin@chromium.org
(No comment was entered for this change.)
Status: Assigned
Owner: k...@chromium.org
Sep 28, 2009
#4 kbr@chromium.org
The initial WebGL implementation for Chrome has been committed:

https://bugs.webkit.org/show_bug.cgi?id=29664
http://codereview.chromium.org/219001

The current code is Windows-only, is disabled by default in the build, and requires 
the sandbox to be disabled. Ports to other platforms to follow shortly; running with 
the sandbox enabled is a longer-term goal.

See the above chromium.org CL for instructions on how to enable in the build.

Status: Started
Sep 30, 2009
#5 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=27637 

------------------------------------------------------------------------
r27637 | kbr@google.com | 2009-09-30 11:35:49 -0700 (Wed, 30 Sep 2009) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_host_delegate_helper.cc?r1=27637&r2=27636
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=27637&r2=27636
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=27637&r2=27636
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages.h?r1=27637&r2=27636
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/public/WebSettings.h?r1=27637&r2=27636
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/src/WebSettingsImpl.cpp?r1=27637&r2=27636
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/src/WebSettingsImpl.h?r1=27637&r2=27636
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webpreferences.cc?r1=27637&r2=27636
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webpreferences.h?r1=27637&r2=27636

Added command line argument --enable-webgl to facilitate turning on
ENABLE_3D_CANVAS in development builds. Currently this argument also
requires disabling the sandbox.

BUG=http://crbug.com/21852
TEST=none (runs preexisting WebGL layout tests; more coming)

Review URL: http://codereview.chromium.org/246042
------------------------------------------------------------------------

Sep 30, 2009
#6 kbr@chromium.org
http://codereview.chromium.org/246042 has been committed which will make it easier to 
set ENABLE_3D_CANVAS=1 in the Dev Channel. Ports to other platforms ongoing.

Oct 2, 2009
#7 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=27902 

------------------------------------------------------------------------
r27902 | kbr@google.com | 2009-10-02 14:26:35 -0700 (Fri, 02 Oct 2009) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/glew/README.chromium?r1=27902&r2=27901
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/glew/src/glew.c?r1=27902&r2=27901
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/src/GraphicsContext3D.cpp?r1=27902&r2=27901
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/webkit.gyp?r1=27902&r2=27901

Ported Chrome's WebGL implementation to Mac OS X. Removed code which
used the GPU to vertically flip the framebuffer. Updated GLEW to use
standard dlopen / dlsym rather than deprecated mach-o/dyld functions;
updated README.chromium.

BUG=http://crbug.com/21852
TEST=none (runs existing WebGL tests; more coming)

Review URL: http://codereview.chromium.org/256037
------------------------------------------------------------------------

Oct 6, 2009
#8 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=28062 

------------------------------------------------------------------------
r28062 | kbr@google.com | 2009-10-05 16:32:52 -0700 (Mon, 05 Oct 2009) | 10 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/glew/README.chromium?r1=28062&r2=28061
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/glew/include/GL/glew.h?r1=28062&r2=28061
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/glew/src/glew.c?r1=28062&r2=28061
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/src/GraphicsContext3D.cpp?r1=28062&r2=28061
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/webkit.gyp?r1=28062&r2=28061

Ported Chrome's WebGL implementation to Linux. Required changes to
GLEW's bootstrapping sequence on both X11 and Windows platforms to
avoid linking against libGL.so.1 directly due to
http://crbug.com/16800 . Made GLEW's inclusion of glu.h optional.
Tested on Linux, Mac and Windows.

BUG=http://crbug.com/21852
TEST=none (runs existing WebGL tests; more coming)

Review URL: http://codereview.chromium.org/258024
------------------------------------------------------------------------

Oct 7, 2009
#9 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=28336 

------------------------------------------------------------------------
r28336 | kbr@google.com | 2009-10-07 15:53:20 -0700 (Wed, 07 Oct 2009) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/build/features_override.gypi?r1=28336&r2=28335

Compile WebGL support in to Chrome's Dev Channel builds. Still
requires command line option --enable-webgl (and, currently,
--no-sandbox) to enable.

BUG=http://crbug.com/21852
TEST=none (runs existing WebGL tests; more coming)

Review URL: http://codereview.chromium.org/270003
------------------------------------------------------------------------

Oct 21, 2009
#10 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=29632 

------------------------------------------------------------------------
r29632 | kbr@google.com | 2009-10-21 03:48:37 -0700 (Wed, 21 Oct 2009) | 8 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/build/features_override.gypi?r1=29632&r2=29631
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/src/GraphicsContext3D.cpp?r1=29632&r2=29631

Implemented getActiveAttrib, getActiveUniform and readPixels. Removed
unnecessary UTF-8 conversion when converting C strings to WebKit
Strings. Re-enabled WebGL in Dev Channel builds.

BUG=http://crbug.com/21852
TEST=none (runs existing WebGL tests; more coming)

Review URL: http://codereview.chromium.org/308006
------------------------------------------------------------------------

Oct 27, 2009
#11 dpranke@chromium.org
(No comment was entered for this change.)
Labels: LayoutTests
Oct 29, 2009
#12 kbr@chromium.org
(No comment was entered for this change.)
Labels: 3D-WebGL
Nov 24, 2009
#13 or...@chromium.org
(No comment was entered for this change.)
Labels: 3d-Mstone-2
Dec 1, 2009
#14 dglazkov@chromium.org
(No comment was entered for this change.)
Labels: LTTF
Dec 8, 2009
#15 or...@chromium.org
Not a demo blocker. Moving to m3.
Labels: -3d-Mstone-2 3d-Mstone-3
Dec 11, 2009
#16 f...@sofaraway.org
Is it supposed to work on Linux just yet?
It doesn't work with the ubuntu builds.
Tried with --enable-webgl --no-sandbox using trunk and the beta, no error, nada.
Just nothing rendered in the examples.

At build time, i use libglew1.5-dev to provide glew.h (since mid-Oct when it 
became necessary)
At runtime, i obviously have libglew1.5.
As for libGL.so.1, it could come from libgl1-mesa-glx or nvidia-glx-XXX for nvidia 
users.
In my case:
lrwxrwxrwx 1 root root     18 2009-10-27 23:14 /usr/lib/libGL.so.1 -> 
libGL.so.185.18.36
-rw-r--r-- 1 root root 622272 2009-10-26 10:50 /usr/lib/libGL.so.185.18.36
(so nvidia-glx-185)

is it http://crbug.com/16800?
Cc: a...@chromium.org e...@chromium.org
Dec 11, 2009
#17 kbr@chromium.org
> Is it supposed to work on Linux just yet?
> It doesn't work with the ubuntu builds.

Should be working. Just tested 
http://build.chromium.org/buildbot/continuous/linux/LATEST/chrome-linux.zip (r34374) 
and it runs the samples linked from the Chromium blog post. This is on 64-bit Ubuntu 
8.04 with NVIDIA hardware and drivers. Could you test the behavior with this exact 
build? Please provide any output to the terminal.

Dec 11, 2009
#18 trevor.g...@gmail.com
yes, worked for me also. tested the cute puppy and other demos at
<http://www.khronos.org/webgl/wiki/Demo_Repository>
this is amd64 jaunty with nvidia.
Dec 11, 2009
#19 evan@chromium.org
It could be because Chrome's glew is forked.  See
http://neugierig.org/software/chromium/notes/2009/12/forking.html (search for "glew")
Dec 11, 2009
#20 kbr@chromium.org
Yes, it was necessary to modify GLEW to dynamically look up all OpenGL entry points, because per 
http://crbug.com/16800 we can not link against libGL.so. During build time we compile in the GLEW sources so 
we do not have an additional dynamic library dependency.

Dec 18, 2009
#21 mal.chromium@gmail.com
(No comment was entered for this change.)
Labels: Internals-Graphics
Dec 19, 2009
#22 f...@sofaraway.org
I've dropped libglew1.5-dev from my build-depends list and now it's failing with
GraphicsContext3D: error opening libGL.so.1. Not very explicit.
I'm not getting the "GraphicsContext3D: tried:" line (missing "\n"?)

But as it requires --no-sandbox, there's no point in me spending on this for now. I 
don't want to encourage users to run chromium without the sandbox.
Jan 13, 2010
#23 kbr@chromium.org
Please see https://code.google.com/p/chromium/issues/detail?id=26055 , in particular 
comments 30 and 31. I believe the current Chromium continuous build should work.

Jan 28, 2010
#24 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=37416 

------------------------------------------------------------------------
r37416 | dglazkov@chromium.org | 2010-01-28 10:47:28 -0800 (Thu, 28 Jan 2010) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/test_expectations.txt?r1=37416&r2=37415
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/layout_test_controller.cc?r1=37416&r2=37415

Enable WebGL layout tests.

R=kbr
TEST=none
BUG=21852

Review URL: http://codereview.chromium.org/556061
------------------------------------------------------------------------

Feb 1, 2010
#25 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=37418 

------------------------------------------------------------------------
r37418 | dglazkov@chromium.org | 2010-01-28 11:03:54 -0800 (Thu, 28 Jan 2010) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/test_expectations.txt?r1=37418&r2=37417

Still skip WebGL tests on Linux. They crash.

TBR=kbr
TEST=none
BUG=21852

Review URL: http://codereview.chromium.org/553137
------------------------------------------------------------------------

Feb 1, 2010
#26 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=37419 

------------------------------------------------------------------------
r37419 | dglazkov@chromium.org | 2010-01-28 11:09:33 -0800 (Thu, 28 Jan 2010) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/test_expectations.txt?r1=37419&r2=37418

Skip Win too, because they crash on bots.

TBR=kbr
TEST=none
BUG=21852

Review URL: http://codereview.chromium.org/552218
------------------------------------------------------------------------

Feb 11, 2010
#27 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=38767 

------------------------------------------------------------------------
r38767 | jorlow@chromium.org | 2010-02-11 05:43:54 -0800 (Thu, 11 Feb 2010) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/test_expectations.txt?r1=38767&r2=38766

Add test expectations from last roll.

TBR=yurys
BUG=21852
TEST=none

Review URL: http://codereview.chromium.org/597041
------------------------------------------------------------------------

Feb 16, 2010
#28 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=39154 

------------------------------------------------------------------------
r39154 | dglazkov@chromium.org | 2010-02-16 15:12:09 -0800 (Tue, 16 Feb 2010) | 7 lines
Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/canvas
   A http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/canvas/webgl
   A http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/canvas/webgl/gl-get-calls-expected.txt
   A http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/canvas/webgl/null-object-behaviour-expected.txt
   A http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/canvas/webgl/texImageTest-expected.txt
   A http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/fast/canvas/webgl/uniform-location-expected.txt
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/test_expectations.txt?r1=39154&r2=39153

Rebaseline Mac WebGL tests and mark Win+Linux as deferred.

TBR=kbr
TEST=none
BUG=21852

Review URL: http://codereview.chromium.org/611005
------------------------------------------------------------------------

Feb 16, 2010
#29 a...@chromium.org
(No comment was entered for this change.)
Cc: -a...@chromium.org
Mar 21, 2010
#30 ambr...@gmail.com
Please add /usr/lib{,32,64}/libGL.so to library search paths on Linux. On Gentoo there 
is no /usr/lib*/libGL.so.1, because actual libs are in /usr/lib*/opengl/{xorg-
x11,nvidia,ati}/lib to allow having multiple OpenGL libs installed, and "eselect 
opengl" is used to select one. This program adds the real lib dir to LDPATH so the 
libs are in the linker cache (for programs linked directly) and sets up the 
/usr/lib*/libGL.so symlink for programs loading the library with dlopen().
Mar 22, 2010
#31 evan@chromium.org
ambrop7: can you open a separate bug about this libGL issue?  I want to ask some 
questions and I don't want to clutter this bug up with the answers.
Dec 19, 2010
#32 fabios4rulez
Should this be marked as fixed since WebGL is now available on chrome beta?
Dec 20, 2010
#33 kbr@chromium.org
I'm CC'ing our product manager. I think we should probably wait to close it until WebGL is available on the stable channel.

Cc: hbri...@google.com vange...@chromium.org
Labels: Area-Internals
Dec 21, 2010
#34 hbridge@google.com
(No comment was entered for this change.)
Labels: -3D-WebGL -3d-Mstone-3 feature-gpu-webl
Dec 21, 2010
#35 hbridge@google.com
I think we can mark it as fixed.  It'll be verified etc later.
Status: Fixed
Labels: -Size-Medium -Mstone-X -feature-gpu-webl Mstone-9 Feature-GPU-WebGL
Sep 22, 2011
#36 downch...@gmail.com
This has pretty well reverted into a bug, from the GPU blacklist:
http://www.google.com/support/forum/p/Chrome/thread?tid=4ed2cebe3379b1a2
Sep 26, 2011
#37 kbr@chromium.org
(No comment was entered for this change.)
Cc: zmo@chromium.org
Oct 13, 2012
#38 bugdro...@chromium.org
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Labels: Restrict-AddIssueComment-Commit
Mar 10, 2013
#39 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Area-WebKit -Mstone-9 -Feature-GPU-WebGL -Internals-Graphics -Area-Internals Cr-Content M-9 Cr-Internals-GPU-WebGL Cr-Internals-Graphics Cr-Internals
Mar 13, 2013
#40 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Apr 5, 2013
#41 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Cr-Content Cr-Blink
Apr 9, 2013
#42 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Cr-Internals-GPU-WebGL Cr-Blink-WebGL
Sign in to add a comment

Powered by Google Project Hosting