Issue 21281 - chromium - When you reload a development extension, you get a new ID

Issue 21281:	When you reload a development extension, you get a new ID
	7 people starred this issue and may be notified of changes.	Back to list

Status:	Fixed
Owner:	----
Closed:	Oct 06
Type-Bug
OS-All
Area-Extensions
Size-Medium
Feature-Extensions
ext

Reported by aa@chromium.org, Sep 08, 2009

What steps will reproduce the problem?
1. Load an extension via --load-extension or the "load extension" button in 
chrome://extensions/
2. Press reload in chrome://extensions/ for that extension.
3. Notice that the extension gets a new ID (...aa, ...ab, .etc).

What is the expected output? What do you see instead?

This messes up extensions that use persistent storage since they end up in 
a new origin each time they are reloaded.

--load-extensions should somehow get a consistent origin. Maybe we should 
hash the name or something? Or give them an origin like local-
path_to_extension?

Comment 1 by mpcomplete@chromium.org, Sep 10, 2009

I like the idea of hashing the path name. That way it will stay consistent across 
browser restarts, and work for disable/reenable too.

Status: Available

Comment 2 by aa@chromium.org, Oct 03, 2009

 Issue 23736  has been merged into this issue.

Comment 3 by aa@chromium.org, Oct 03, 2009

(No comment was entered for this change.)

Status: Started

Comment 4 by bugdroid1@chromium.org, Oct 06, 2009

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=28095 

------------------------------------------------------------------------
r28095 | aa@chromium.org | 2009-10-05 23:17:54 -0700 (Mon, 05 Oct 2009) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browsertest.cc?r1=28095&r2=28094
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browsertest.h?r1=28095&r2=28094
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc?r1=28095&r2=28094
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_uitest.cc?r1=28095&r2=28094
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_updater_unittest.cc?r1=28095&r2=28094
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extensions_service_unittest.cc?r1=28095&r2=28094
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/sandboxed_extension_unpacker.cc?r1=28095&r2=28094
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension.cc?r1=28095&r2=28094
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension.h?r1=28095&r2=28094
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_unittest.cc?r1=28095&r2=28094
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/uitest/event_sink/manifest.json?r1=28095&r2=28094

Generate IDs for --load-extension by hashing the path instead
of incrementing a static counter.

BUG=21281
TEST=Load an unpacked extension from chrome://extensions/ that
does not have an ID in its manifest. The resulting ID should
be random-looking, not something like "aaaaaa".

Review URL: http://codereview.chromium.org/256049
------------------------------------------------------------------------

Comment 5 by aa@chromium.org, Oct 06, 2009

(No comment was entered for this change.)

Status: Fixed

Comment 6 by erikkay@chromium.org, Mar 03 (6 days ago)

(No comment was entered for this change.)

Labels: Feature-Extensions

► Sign in to add a comment