Issue 2069 - chromium - Regression: Shelves (infobar / download shelf) not hidden correctly after tab close

Status:	Verified
Owner:	glen@chromium.org
Closed:	Oct 2008
Cc:	sky@chromium.org
Type-Bug
Pri-1
OS-All
Area-BrowserUI
Mstone-1.0

Sign in to add a comment

Reported by rig9919, Sep 10, 2008

Product Version      : 0.2.152.0
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari 3:
Firefox 3:
IE 7:

What steps will reproduce the problem?
1. Download something
2. Close the tab
3. Click your download button's arrow to get menu with "open, show in 
folder"

What is the expected result?
Should show the menu

What happens instead?
Entire download bar becomes unresponsive until you double click it to 
restore screen.

Please provide any additional information below. Attach a screenshot if 
possible.

Comment 1 by niranjan@chromium.org, Sep 22, 2008

Please repro on the dev channel + trunk builds.

Status: Assigned
Owner: mberkow...@chromium.org
Labels: -Area-Unknown Area-BrowserUI

Comment 2 by goocai, Oct 03, 2008

Same here, and once double-clicked, the bar disappear. Tested on 0.2.153.1

Comment 3 by venkataramana@chromium.org, Oct 03, 2008

This is dupe of  Issue  1904 .

-Venkat.

Status: Duplicate

Comment 4 by venkataramana@chromium.org, Oct 03, 2008

oops..sorry..wrong duping... 2979 is dupe of this.

-Venkat.

Status: Untriaged
Owner: venkatar...@chromium.org

Comment 5 by venkataramana@chromium.org, Oct 03, 2008

Consistent Repro Steps:

--Go to any webpage(Eg: google.com)
--Copy and paste any URL which points to download in the same tab (eg: http://www.download.com/3001-2239_4-10891365.html?
spi=1ec293304541968b88b9408ec6cfc3ad)
--Close the tab.

Summary: Regression: Download bar becomes unresponsive
Labels: -Pri-2 Pri-1

Comment 6 by mberkow...@chromium.org, Oct 03, 2008

I can reproduce this in 154.0.  It appears to be a redraw issue involving the
Download Bar (the bar is not really there).  Use repro steps in bug # 1904.

Comment 7 by venkataramana@chromium.org, Oct 14, 2008

Comments from Glen:
Problem appears to be because frame::shelf_view_ is killed without calling Layout() 
when the tab is closed, and when ShelfVisibilityChangedImpl is subsequently fired 
for 
the new tab as part of ShowTabContents, it thinks that no shelf view was visible, so 
it doesn't detect any change and doesn't call Layout().

Not yet sure why this doesn't affect infobars.

Comment 8 by venkataramana@chromium.org, Oct 14, 2008

(No comment was entered for this change.)

Cc: s...@chromium.org

Comment 9 by glen@chromium.org, Oct 14, 2008

This bug affects infobars as well.

Summary: Regression: Shelves (infobar / download shelf) not hidden correctly after tab close
Owner: g...@chromium.org

Comment 10 by mal.chromium, Oct 15, 2008

This regression needs to get fixed before 1.0. Ideally before we push the next Beta 
update, if it can get fixed this week.

Labels: Mstone-1.0

Comment 11 by glen@chromium.org, Oct 15, 2008

Fix is approved, waiting on me being around while the tree is open, sorry.

Comment 12 by glen@chromium.org, Oct 17, 2008

Fixed with r3528

Status: Fixed

Comment 13 by mberkow...@chromium.org, Oct 20, 2008

Verified in 0.3.154.5 (Official Build 3584).

Status: Verified

Comment 14 by jon@chromium.org, Dec 04, 2008

 Issue 3865  has been merged into this issue.

Issue 2069:	Regression: Shelves (infobar / download shelf) not hidden correctly after tab close
	6 people starred this issue and may be notified of changes.	Back to list