My favorites | Sign in
Logo
             
New issue | Search
for
| Advanced search | Search tips
Issue 20654: Flash does not register any clicks
87 people starred this issue and may be notified of changes. Back to list
 
Reported by hyperair, Aug 30, 2009
Chrome Version       : 4.0.204.0 (Ubuntu build 24734)
URLs (if applicable) : Any youtube video, or megavideo.com video
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari 4:
  Firefox 3.x: OK
IE 7:
IE 8:

What steps will reproduce the problem?
1. Open a youtube video. Note that it begins playing immediately.
2. Click on the pause button.

What is the expected result?
Video pauses.

What happens instead?
Video does not pause. When clicking on the button, the cursor changes from 
the hand back to the usual pointer for the duration that the button is held 
down.

Please provide any additional information below. Attach a screenshot if
possible.
Ubuntu 9.10 64-bit, Chromium from the Chromium-daily PPA, and 64-bit Flash 
(10.0 r32)
Comment 95 by evan@chromium.org, Nov 03, 2009
ummary of the last 100 comments, since people clearly aren't reading
them before leaving their own redundant comments.

This affects:
- Multiple distros
- Both 32 and 64 bit
- Browsers other than Chrome, but it seems to be worse in Chrome for reasons
  that aren't yet clear.

One user reports it affects gnash as well, but that may be a different bug.

The upstream Ubuntu bug is a trainwreck of useless comments but you can
subscribe to it to learn about updates:
  https://bugs.edge.launchpad.net/ubuntu/+source/flashplugin-nonfree/+bug/410407

The problem seems to be made worse by:
- compiz (some people found turning it off fixes the problem; others find it
          doesn't matter)
- nspluginwrapper (as with compiz, unclear whether it fixes)
- GTK 2.18's client side windows (setting GDK_NATIVE_WINDOWS=1 works for some,
                                  not for others)

Known workarounds aside from toggling the above:
 - Hold down middle mouse button while clicking left button

In general, even if it's a Flash bug we are interested in working around it
if possible.

From now on, I will delete any new comments that aren't adding new information.
Please click the star button on the bug to get informed of updates.
Comment 96 by evan@chromium.org, Nov 10, 2009
This is a very helpful comment from the Ubuntu bug.  Perhaps there's an off-by-one in our 
positioning somewhere?

"I have a theory as to the cause.  I'm experiencing this in Chromium with
Compiz on, but I don't think it's the fault of either.  When you hover
over certain buttons/items in a flash box, they register as links with
the OS, and the mouse changes to show that.  For most cursors it changes
to be a hand, on mine, the cursor just blinks, to each their own.
However, when the cursor is in link mode over flash, and you click, the
cursor is moved to the right by 1 pixel.  I can verify that it's not
just my mouse moving because it works on A) my trackball, and B) my
touchpad, with my hands off the ball/pad respectively.  Flash registers
this click/move as a Drag, not a Click, and doesn't click the button.  I
can 99% guarantee this, because if I move my mouse to the left at JUST
the right rate, the 1 pixel shift is counteracted, the click goes
through as a click, and the button registers.  This also explains the
right-click trick, and very rapid click trick, as both of those register
clicks before flash can shift the cursor.  I'd like confirmation, from
anyone with a low enough resolution monitor and a trackpad with separate
buttons, to see the shift, and that it's only on links in flash."
Comment 97 by bugdroid1@chromium.org, Nov 11, 2009
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=31734 

------------------------------------------------------------------------
r31734 | evan@chromium.org | 2009-11-11 15:49:51 -0800 (Wed, 11 Nov 2009) | 15 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/plugin/plugin_thread.cc?r1=31734&r2=31733

linux: work around "flash does not register any clicks" bug

I had a flash of inspiration!  Setting GDK_NATIVE_WINDOWS in the
environment doesn't work because we don't propagate the setting down
into the plugin subprocess.  I confirmed that setting it manually
fixes it.  That is, on this computer I previously had the no-clicks
bug and with this change the problem is solved.

Note: there are multiple confusing levels to this bug; if
nspluginwrapper gets involved I still encounter the problem.
But this definitely fixes the problem for me.

BUG=20654

Review URL: http://codereview.chromium.org/384059
------------------------------------------------------------------------

Comment 98 by DizzyC81, Nov 12, 2009
Hi evan, 
I can confirm that it fixed the problem for me!
I just upgraded to  build 31785 and it solved my problem.
Wow finally a breakthrough with this annoying bug.
Thank you evan.
Comment 99 by DizzyC81, Nov 13, 2009
PS: I know I'm off topic but maybe this helps someone.
This fix, the fact that you set GDK_NATIVE_WINDOWS=1 also helped me with another 
issue I had.
I am using Easystroke for mouse gestures. And before this fix, it would never 
register gesture strokes on a flash clip. 
That is solved as well with this fix :D
So thanks again!
(I haven't checked but maybe somebody has complained about this or submitted a bug 
report about this)
Comment 100 by tony.chromium, Nov 13, 2009
 Issue 27108  has been merged into this issue.
Comment 101 by tony.chromium, Nov 13, 2009
 Issue 27673  has been merged into this issue.
Comment 102 by bugdroid1@chromium.org, Nov 19 (5 days ago)
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=31734 

------------------------------------------------------------------------
r31734 | evan@chromium.org | 2009-11-11 15:49:51 -0800 (Wed, 11 Nov 2009) | 15 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/plugin/plugin_thread.cc?r1=31734&r2=31733

linux: work around "flash does not register any clicks" bug

I had a flash of inspiration!  Setting GDK_NATIVE_WINDOWS in the
environment doesn't work because we don't propagate the setting down
into the plugin subprocess.  I confirmed that setting it manually
fixes it.  That is, on this computer I previously had the no-clicks
bug and with this change the problem is solved.

Note: there are multiple confusing levels to this bug; if
nspluginwrapper gets involved I still encounter the problem.
But this definitely fixes the problem for me.

BUG=20654

Review URL: http://codereview.chromium.org/384059
------------------------------------------------------------------------

Comment 103 by evan@chromium.org, Nov 19 (5 days ago)
(No comment was entered for this change.)
Labels: Mstone-4
Comment 104 by mal.chromium, Nov 22 (2 days ago)
So, evan, what more do we do with this bug?

Should we mark it fixed and open new bugs if your fix doesn't work for other 
configurations? That is my preference.
Labels: ReleaseBlock-Beta
Comment 105 by evan@chromium.org, Nov 22 (2 days ago)
I think I was leaving it open and tagging it mstone-4 to remind myself to merge it to 
the branch.  I agree with your preference otherwise.
Comment 106 by evan@chromium.org, Yesterday (36 hours ago)
This made the 249 branch, so I'm closing.

If you are still having problems with clicking on Flash and have verified you're using 
the newest Google Chrome you can find, please file a new bug with as much system info 
as possible (in particular the output of "nspluginwrapper -l").
Status: Fixed
Sign in to add a comment