My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 205081: Upstream our local google-breakpad fork
3 people starred this issue and may be notified of changes. Back to list
 
Project Member Reported by kmix...@chromium.org, Oct 24, 2011
It would be great if we could just pull in breakpad without having our own fork that needs manually merging periodically.  The fork is a decent sized departure from upstream (converts core files to minidumps instead of having everything on the system use ptrace and link against breakpad).  

1The steps to this would be to
1) move src/tools/linux/core2md/{linux_dumper,minidump_writer}.{cc,h} to src/client/linux/minidump_writer (this would overwrite the upstream files with the ones we've been manually merging)
2) change tools/linux/core2md Makefile to build from the merged location
3) patch the changes in minidump_writer and new code in src/tools/linux/core2md into a fresh svn google-breakpad checkout
4) upstream them
5) kill off src/platform/google-breakpad and make our google-breakpad ebuild just pull directly from subversion (though I'm not sure if that's technically allowed by our build system - we might need to keep around our clone of google-breakpad)

When I made the changes to linux_dumper and minidump_writer, I optimized for easier to merge instead of easiest to maintain.  We may need to change that upon getting reviews.


Mar 16, 2013
#1 bugdro...@chromium.org
(No comment was entered for this change.)
Blockedon: chromium-os:22009 chromium-os:23555
Oct 24, 2011
#2 kmix...@chromium.org
(No comment was entered for this change.)
Blockedon: 22009
Oct 26, 2011
#3 tr...@chromium.org
Mike, RTC, can you take a look at this and help prioritize if appropriate?
Status: Assigned
Cc: r...@chromium.org
Labels: Team-Systems
Nov 8, 2011
#4 kmix...@chromium.org
I think this should be priority 1.  I spent probably a full day uprevving from ~730 to 875 ( issue 22009 ), including getting help from mkrebs.  About 1/3 of the time was in merging our stuff manually which this would eliminate.  Granted that still left 2/3 of the time where we dealt with build system tweaks they made upstream (that didn't make sense on ARM) and fixing an upstream bug.  But still - reducing this to be the minimal amount would be nice.
Nov 29, 2011
#5 benc...@chromium.org
(No comment was entered for this change.)
Blockedon: 23555
Dec 6, 2011
#6 benc...@chromium.org
I filed an upstream bug (https://code.google.com/p/google-breakpad/issues/detail?id=455) and am working on refactoring the code changes.
Jan 9, 2012
#7 benc...@chromium.org
(No comment was entered for this change.)
Status: Started
Owner: benc...@chromium.org
Cc: mkr...@chromium.org
Labels: Mstone-R18
Jan 12, 2012
#8 kmix...@chromium.org
(No comment was entered for this change.)
Cc: -kmix...@chromium.org
Jan 20, 2012
#9 bugdro...@chromium.org
Commit: 4420ba7e2fdfc79b8f4f34ff09a8439d9aa5800b
 Email: benchan@chromium.org

google-breakpad: Remove legacy files and core_dumper target.

The Chromium OS changes to google-breakpad have been upstreamed (r905).
This CL modifies the google-breakpad ebuild to remove the core_dumper
target and other legacy files.

BUG=chromium-os:22042
TEST=Verified the following:
1. emerge google-breadpad for x86-generic, arm-generic and amd64-generic
2. cros_run_unit_tests -p google-breakpad for x86-generic, amd64-generic
3. Run the following autotest tests on a Cr48:
   - logging_CrashSender
   - logging_UserCrash

Change-Id: Icf8644c8080d1de83e00c289296de8c3a9eb0d53
Reviewed-on: https://gerrit.chromium.org/gerrit/14544
Reviewed-by: Michael Krebs <mkrebs@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Commit-Ready: Ben Chan <benchan@chromium.org>

D	chromeos-base/google-breakpad/files/core2md/common/linux/mmapped_range.h
D	chromeos-base/google-breakpad/files/core2md/tools/linux/core2md/Makefile
D	chromeos-base/google-breakpad/files/core2md/tools/linux/core2md/core2md.cc
D	chromeos-base/google-breakpad/files/core2md/tools/linux/core2md/core_dumper.cc
D	chromeos-base/google-breakpad/files/core2md/tools/linux/core2md/core_reader.cc
D	chromeos-base/google-breakpad/files/core2md/tools/linux/core2md/core_reader.h
D	chromeos-base/google-breakpad/files/core2md/tools/linux/core2md/linux_dumper.cc
D	chromeos-base/google-breakpad/files/core2md/tools/linux/core2md/linux_dumper.h
D	chromeos-base/google-breakpad/files/core2md/tools/linux/core2md/minidump_writer.cc
D	chromeos-base/google-breakpad/files/core2md/tools/linux/core2md/minidump_writer.h
M	chromeos-base/google-breakpad/google-breakpad-9999.ebuild
Jan 20, 2012
#10 benc...@chromium.org
(No comment was entered for this change.)
Status: Fixed
Labels: Iteration-47
Jan 30, 2012
#11 rajeevku...@chromium.org
Verified with build "1653.0.0" on Cr-48.

Both "logging_CrashSender" & "logging_UserCrash" autotests ran successfully, and the tests passed.

Status: Verified
Apr 6, 2012
#12 dd...@chromium.org
(No comment was entered for this change.)
Labels: -Mstone-R18 Mstone-18
May 15, 2012
#13 chromeos...@chromium.org
(No comment was entered for this change.)
Labels: FixedIn-1606.0.0 FixedInIndex-36
Blockedon: -22009 -23555 chromium-os:22009 chromium-os:23555
Sep 7, 2012
#14 bugdro...@chromium.org
Commit: 609ecce70db92df131f852d8d8590094bdbd4b56
 Email: benchan@chromium.org

google-breakpad: uprev breakpad to r905

The Chromium OS changes to google-breakpad have been upstreamed (r905).
This CL pulls and merges from the upstream branch.

BUG=chromium-os:22042
TEST=Verified the following:
1. emerge google-breadpad for x86-generic, arm-generic and amd64-generic
2. cros_run_unit_tests google-breakpad for x86-generic and amd64-generic
3. Run the following autotest tests on a Cr48:
   - logging_CrashSender
   - logging_UserCrash

Change-Id: I865193573ca3ac78f1d85abfd848686a3e3510e3

MM	Makefile.am
MM	Makefile.in
AM	src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc
Mar 6, 2013
#15 lafo...@google.com
(No comment was entered for this change.)
Labels: OS-Chrome
Blockedon: -chromium-os:22009 -chromium-os:23555 chromium-os:22009 chromium-os:23555
Mar 9, 2013
#16 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Area-Logging -Team-Systems -Mstone-18 M-18 Cr-Internals-Logging Cr-OS-Systems
Sign in to add a comment

Powered by Google Project Hosting