My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 202697: cros_image_to_target assumes chroot is named "chroot"
1 person starred this issue and may be notified of changes. Back to list
 
Project Member Reported by sleffler@chromium.org, Aug 24, 2011
This code:

  def ChrootPath(self, filename):
       self.CrosUtilsPath(os.path.join('..', '..', 'chroot',
                                          filename.strip(os.path.sep)))

doesn't work when your chroot is named something like "chroot-arm".  It may happen to work if you share the source tree w/ another chroot named "chroot" but it bit me when cros_generate_update_payload needed to be updated and I updated it only in the "chroot-arm" chroot.
Mar 16, 2013
#1 bugdroid1@chromium.org
(No comment was entered for this change.)
Blockedon: chromium-os:19602
Aug 24, 2011
#2 davidjames@google.com
(No comment was entered for this change.)
Owner: zbe...@chromium.org
Aug 24, 2011
#3 bugdroid1@chromium.org
Commit: 908a843d78ebc91898bd9b7ebd75dce5dc993086
 Email: zbehan@chromium.org

cros_image_to_target: when in chroot, call the chroot tools relative to /

This fixes a problem with chroots named other than 'chroot', but only
when running inside the chroot.

BUG=chromium-os:19596
TEST=run it inside the chroot

Change-Id: I9532fe7762e2d7e277305fb948e5cabc242a5213
Reviewed-on: http://gerrit.chromium.org/gerrit/6597
Tested-by: Zdenek Behan <zbehan@chromium.org>
Reviewed-by: Zdenek Behan <zbehan@chromium.org>

M	bin/cros_image_to_target.py
Nov 1, 2011
#4 zbe...@chromium.org
This is FIXED, but only for a special case when running inside the chroot.

Issue 19602 tracks deciding whether we really want to call this script from outside the chroot, and if we don't and explicitly remove that functionality, this bug shall be no more.
Cc: mtennant@chromium.org
Blockedon: 19602
Nov 1, 2011
#5 mtennant@chromium.org
Triaging after Zdenek's input above.
Status: Available
Labels: Mstone-X
Oct 30, 2012
#6 benhe...@google.com
(No comment was entered for this change.)
Labels: -Mstone-X
Blockedon: -chromium-os:19602 chromium-os:19602
Mar 6, 2013
#7 lafo...@google.com
(No comment was entered for this change.)
Labels: OS-Chrome
Mar 9, 2013
#8 bugdroid1@chromium.org
(No comment was entered for this change.)
Labels: -Area-Build Build
Jul 18, 2013
#9 davidjames@chromium.org
(No comment was entered for this change.)
Labels: -Sev-2
Aug 2, 2013
#10 scottz@chromium.org
(No comment was entered for this change.)
Owner: ---
Labels: -Build Build-Tools
Jan 9, 2014
#11 scottz@chromium.org
obsolete
Status: WontFix
Sign in to add a comment

Powered by Google Project Hosting