My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 202651: Fake network library is in use on the netbook
8 people starred this issue and may be notified of changes. Back to list
 
Project Member Reported by sato...@chromium.org, Aug 23, 2011
Chrome OS Version  :  ToT
Chrome Version     :  ToT
Type of computer   :  N/A
Network info       :   N/A

Please specify Area-* of the system to which this bug/feature applies (add
the label below).

What steps will reproduce the problem?
1. Build a new Chromium OS image from from ToT trees of Chromium and Chromium OS
2. Boot from the image

What is the expected output?

Expected: OOBE screen works as before
Actual: "Select a network" menu says "Fake Wifi Connected"

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)

100% reproducible

What is the impact to the user, and is there a workaround? If so, what is
it?

Very bad

Please provide any additional information below.

http://crrev.com/97662 is likely the culprit. satorux is now testing if reverting this patch fixes the issue.

Mar 16, 2013
#1 bugdroid1@chromium.org
(No comment was entered for this change.)
Blockedon: chromium-os:19577
Aug 23, 2011
#2 sato...@chromium.org
(No comment was entered for this change.)
Labels: iteration-37
Aug 23, 2011
#3 sato...@chromium.org
Reverted 97662 and booted. It leaves me with a device that infinite-loops trying to start up Chrome, just like James described off-line.

/var/log/chrome/chrome says

FATAL:netowkr_library.cc(3786)] Check failed: res.

Aug 23, 2011
#4 stevenjb@chromium.org
Issue 19519 has been merged into this issue.
Cc: anna...@chromium.org jose...@chromium.org kr...@chromium.org stanl...@chromium.org pstew@chromium.org zelidrag@chromium.org josa...@chromium.org
Aug 23, 2011
#5 stevenjb@chromium.org
(No comment was entered for this change.)
Labels: -Pri-1 Pri-0 ReleaseBlock-Dev
Aug 23, 2011
#6 rhashim...@chromium.org
I also see the crash loop on mario reverting r97662 from ToT.  If I reset to r97673 and revert r97662 and r97481 then I get a successful startup on seaboard and mario.
Aug 23, 2011
#7 sato...@chromium.org
Then something is wrong in (97673, ToT). Steven will be doing a bisect.
Owner: stevenjb@chromium.org
Cc: -stevenjb@chromium.org sato...@chromium.org
Aug 23, 2011
#8 sato...@chromium.org
Confirmed that r97673 -r97662 -r97481 reverted was good (- indicates a revert) as rhashimoto commented.
Aug 23, 2011
#9 sato...@chromium.org
Confirmed that r97797 -r97662 -r97481 reverted was good.
Aug 23, 2011
#10 sato...@chromium.org
Per stevenjb, 97836 -r97662 was bad.
Aug 23, 2011
#11 sato...@chromium.org
Confirmed that r97819 -r97662 was bad (chrome keep restarting)
Aug 23, 2011
#12 sato...@chromium.org
Confirmed that r97802 -r97662 was good (chrome booted)
Aug 23, 2011
#13 sato...@chromium.org
Per stevenjb, 97812 -r97662 was good.
Aug 23, 2011
#14 nirnimesh@chromium.org
r97662 also breaks pyauto (test automation). When we have a resolution please try desktopui_UrlFetch test and verify that there are no error messages like in  issue 19532 . Or let me know and I can try it out as well. Thanks
Aug 23, 2011
#15 sato...@chromium.org
Per stevenjb, 97815 was the culprit. We are now double-checking...
Aug 23, 2011
#16 stevenjb@chromium.org
Confirmed that 97815 is the culprit, and we know why:
We are passing Value between libcros and Chrome. 97815 changed the size of Value for Chrome, but not libcros (which gets Value from libchrome).

We are discussing options to fix this now.

Aug 23, 2011
#17 stevenjb@chromium.org
Created  issue 19577  to track the crash bug which needs to be fixed before we can revert 97662.

Blockedon: 19577
Aug 23, 2011
#18 xiyuan@chromium.org
 Issue 19526  has been merged into this issue.
Aug 23, 2011
#19 nirnimesh@chromium.org
Why not immediately revert 97815 so that 97662 can be reverted, until the problem in  issue 19576  can be fixed?
97662 is blocking  issue 19532  due to which all test automation is broken, due to which chrome with the nasty 'webpage not rendering bug' ( issue 19468 ) cannot be uprev'ed.
Aug 23, 2011
#20 sato...@chromium.org
I'd say it's not right to revert 97815 at this moment. It would've made sense to rever the patch if it broke chrome os build bots, but it didn't as 97662 masked the issue unveiled by 97815 (crosbug.com/19577).  Note that nothing is wrong with 97815 itself. The root cause of the problem is the way we use the Value class in in libcros.

Hopefully, the fix for this issue is now under code review: http://codereview.chromium.org/7714024/

Aug 23, 2011
#21 nirnimesh@chromium.org
Are you expecting the temp fix and the 97662-revert to land today?
If not, chromeos build tomorrow will be stuck with  issue 19468 , which blocks all R15 testing for another day.
Aug 23, 2011
#22 sato...@chromium.org
Got approval from a base directory owner. I'm about to check this in on behalf of stevenjb.
Aug 23, 2011
#23 sato...@chromium.org
I meant I was about to check in http://codereview.chromium.org/7714024/.

Afterward, 97662 should also be reverted. I'll give it a try...
Aug 23, 2011
#24 josa...@chromium.org
Next R15 Dev RC  build is tonight, please update this bug if commit is landed in ToT before 1 am 
Aug 23, 2011
#25 sato...@chromium.org
Done.

http://src.chromium.org/viewvc/chrome?view=rev&revision=97997 should fix 19577 (Value size issue)

http://src.chromium.org/viewvc/chrome?view=rev&revision=97999 should fix this (fake network library)
Aug 24, 2011
#26 stevenjb@chromium.org
Thanks satorou!

Status: Fixed
Aug 25, 2011
#27 stanl...@chromium.org
(No comment was entered for this change.)
Labels: Network
Aug 26, 2011
#28 stanl...@chromium.org
Make sure Fake* networks are not showing up in the network list.
Owner: vtodk...@chromium.org
Cc: stevenjb@chromium.org
Aug 26, 2011
#29 vtodk...@chromium.org
Verified on :
Google Chrome	15.0.862.1 (Official Build 98372)
Platform	950.0 (Official Build) dev-channel x86
WebKit	        535.2 (@93705)
JavaScript	V8 3.5.8

Select a network menu shows all the available wifi network.

Status: Verified
Mar 6, 2013
#30 lafo...@google.com
(No comment was entered for this change.)
Labels: OS-Chrome
Blockedon: -chromium-os:19577 chromium-os:19577
Mar 10, 2013
#31 bugdroid1@chromium.org
(No comment was entered for this change.)
Labels: -Mstone-R15 M-15
Sign in to add a comment

Powered by Google Project Hosting