My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 201726: KernelCollectorTest.CollectBadDirectory failing on x86 canaries
1 person starred this issue and may be notified of changes. Back to list
 
Project Member Reported by ellyjo...@chromium.org, Aug 3, 2011
http://chromeos-botmaster.mtv.corp.google.com:8026/builders/x86-alex%20canary/builds/810/steps/Test/logs/stdio

crash-reporter-0.0.1-r56: [ RUN      ] KernelCollectorTest.CollectBadDirectory
crash-reporter-0.0.1-r56: kernel_collector_test.cc:237: Failure
crash-reporter-0.0.1-r56: Value of: FindLog( "Unable to create appropriate crash directory")
crash-reporter-0.0.1-r56:   Actual: false
crash-reporter-0.0.1-r56: Expected: true
crash-reporter-0.0.1-r56: [  FAILED  ] KernelCollectorTest.CollectBadDirectory (1 ms)
Aug 3, 2011
#1 bugdroid1@chromium.org
Commit: 61237ecd8a56715db76a30bf24b0c9e04b03a4c2
 Email: ellyjones@chromium.org

crash-reporter: disable CollectBadDirectory

Treecloser filed as crosbug.com/18622; temporarily disabling this test to reopen
the tree.

BUG=chromium-os:18622
TEST=Not anymore

Change-Id: I4b7467f6044e02ab1308f449d5aa530a15535933
Signed-off-by: Elly Jones <ellyjones@chromium.org>
Reviewed-on: http://gerrit.chromium.org/gerrit/5214
Reviewed-by: Chris Masone <cmasone@chromium.org>

M	kernel_collector_test.cc
Aug 3, 2011
#2 kmix...@chromium.org
This test is basically putting a file in a place where a directory is expected then running the Collect function to make sure it complains about not being able to create the directory that spools kernel crsahes.

The kernel collector code hasn't changed since April 7, though possibly underlying code has recently changed that breaks some assumption.

Suggest sync'ing everything, running the specific test repeatedly (--gtest_filter I think is the option you want) to see if it fails and then print the logs on failure to see why it fails.  Possibly one immediate change is to enable printing logs to stderr during the test run (SetUpTests parameter) so that from the output you can always see logs, but that might be noisy.
Owner: mkr...@chromium.org
Sep 2, 2011
#3 davidjames@google.com
Not a TreeCloser any more, since the test is disabled. If the tree breaks again on this test, please re-add TreeCloser label.
Labels: -TreeCloser
Sep 26, 2011
#4 bugdroid1@chromium.org
Commit: 017f3b86355fa61c5648373aa4a7548591a0c4a6
 Email: sergiu@chromium.org

crash-reporter: Activate updated BadDirectory test

Activated the BadDirectory test which was breaking the build.

BUG=chromium-os:18622
TEST=Ran the unit tests locally and it succeded.

Change-Id: I439d9fb40ec37261ef839c82817d6bc67e683c7d
Signed-off-by: Sergiu Iordache <sergiu@chromium.org>
Reviewed-on: http://gerrit.chromium.org/gerrit/5433
Reviewed-by: Ken Mixter <kmixter@chromium.org>
Tested-by: Michael Krebs <mkrebs@chromium.org>

M	kernel_collector_test.cc
Sep 26, 2011
#5 mkr...@chromium.org
Submitted sergiu's fix, as he has left.  I ran the unit test with his change and it indeed works now.

Status: Fixed
Sep 26, 2011
#6 mkr...@chromium.org
Still breaking the buildbots for some reason.  Reverted for now ("http://gerrit.chromium.org/gerrit/#change,8332").

Status: Assigned
Mar 26, 2012
#7 mkr...@chromium.org
Haven't looked at this in a long while.  I'm lowering the priority because it's no longer blocking anything, and the failure doesn't imply anything bad could happen in the real world even if something's broken with it.

Labels: -Pri-0 -Sev-0 Pri-2 Sev-2 Mstone-X
Apr 20, 2012
#8 mkr...@chromium.org
(No comment was entered for this change.)
Status: Started
Labels: Iteration-54
Apr 23, 2012
#9 mkr...@chromium.org
bugdroid1@, bugdroid1@, wherefore art thou bugdroid1@...

commit b29c964a039e6d819d750ff7a6b322fae96aa188
Author: Sergiu Iordache <sergiu@chromium.org>
Date:   Fri Aug 5 15:32:15 2011 -0700

    crash-reporter: Re-enable CollectBadDirectory unittest
    
    The KernelCollectorTest.CollectBadDirectory unittest was first re-enabled by
    sergiu@ in https://gerrit.chromium.org/gerrit/5433, but it broke the
    buildbots and had to be re-disabled.  So I'm trying again, but this time I
    have the power of trybots!  I also added code to output the log if it fails
    again.
    
    BUG=chromium-os:18622
    TEST=Ran unittests.  Ran trybots on: alex-paladin, amd64-generic-paladin,
    arm-tegra2-paladin, lumpy-paladin, stumpy-paladin.
    
    Change-Id: Ib7fa1c1a32e9c198db9bdae8f933c9dd9fc3381a
    Reviewed-on: https://gerrit.chromium.org/gerrit/20667
    Tested-by: Michael Krebs <mkrebs@chromium.org>
    Reviewed-by: Ben Chan <benchan@chromium.org>
    Commit-Ready: Michael Krebs <mkrebs@chromium.org>

M       kernel_collector_test.cc

Status: Fixed
Apr 25, 2012
#10 kr...@chromium.org
(No comment was entered for this change.)
Status: Verified
May 8, 2012
#11 bugdroid1@chromium.org
Commit: b29c964a039e6d819d750ff7a6b322fae96aa188
 Email: sergiu@chromium.org

crash-reporter: Re-enable CollectBadDirectory unittest

The KernelCollectorTest.CollectBadDirectory unittest was first re-enabled by
sergiu@ in https://gerrit.chromium.org/gerrit/5433, but it broke the
buildbots and had to be re-disabled.  So I'm trying again, but this time I
have the power of trybots!  I also added code to output the log if it fails
again.

BUG=chromium-os:18622
TEST=Ran unittests.  Ran trybots on: alex-paladin, amd64-generic-paladin,
arm-tegra2-paladin, lumpy-paladin, stumpy-paladin.

Change-Id: Ib7fa1c1a32e9c198db9bdae8f933c9dd9fc3381a
Reviewed-on: https://gerrit.chromium.org/gerrit/20667
Tested-by: Michael Krebs <mkrebs@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Ready: Michael Krebs <mkrebs@chromium.org>

M	kernel_collector_test.cc
May 15, 2012
#12 chromeos...@chromium.org
(No comment was entered for this change.)
Labels: FixedIn-2171.0.0 FixedInIndex-49
Mar 6, 2013
#13 lafo...@google.com
(No comment was entered for this change.)
Labels: OS-Chrome
Mar 9, 2013
#14 bugdroid1@chromium.org
(No comment was entered for this change.)
Labels: -Area-Test Cr-Test
Sign in to add a comment

Powered by Google Project Hosting