| Issue 20166: | Linux omnibox control key behavior is incorrect | |
| 3 people starred this issue and may be notified of changes. | Back to list |
Sign in to add a comment
|
What steps will reproduce the problem? 1. Start typing a URL that gets inline-autocompleted, e.g. "www.goo". 2. Press the Control key. What is the expected result? On Windows, the inline-autocompleted text remains highlighted. What happens instead? On Linux ToT, the inline-autocompleted text disappears when the Control key is pressed and reappears when it is released. This makes it impossible to hit Ctrl- L and then Delete or Backspace while you're typing text into the omnibox to select and clear it all -- when 'L' is pressed all of the text is highlighted, but the selection gets reset to just span the inline-autocompleted text when you release Control. Possibly related: brettw points out that hitting a Ctrl-combination is supposed to stop the "append .com" behavior, so that you can hold Control, press V to paste a URL from the clipboard, press Enter, and then release Control, without .com getting added to your URL (please let me know if I'm mis-characterizing this, Brett). |
||||||||||||||||
,
Aug 24, 2009
(No comment was entered for this change.)
Cc: de...@chromium.org
|
|||||||||||||||||
,
Aug 24, 2009
If we can find out what caused this, we should revert it ASAP before we make a dev release. |
|||||||||||||||||
,
Aug 24, 2009
(No comment was entered for this change.)
Status: Assigned
|
|||||||||||||||||
,
Aug 24, 2009
I added the support of control key in CL http://codereview.chromium.org/172041, which should follow the same behavior than Windows version. I'll check the code to see what's wrong with it. |
|||||||||||||||||
,
Aug 25, 2009
CL http://codereview.chromium.org/173462 fixes this issue.
Status: Started
|
|||||||||||||||||
,
Aug 27, 2009
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=24705
------------------------------------------------------------------------
r24705 | suzhe@chromium.org | 2009-08-27 17:31:28 -0700 (Thu, 27 Aug 2009) | 10 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete_edit_view.h?r1=24705&r2=24704
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc?r1=24705&r2=24704
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h?r1=24705&r2=24704
Fix control key and paste behavior in Linux omnibox.
BUG=12316: Linux Omnibox, autocomplete on paste annoying.
BUG=13096: Support desired_tld in Linux omnibox
BUG=20166: Linux omnibox control key behavior is incorrect
TEST=Select all text in omnibox and paste something into omnibox by either ctrl-v, paste item in context menu or middle click, to see if inline autocomplete is not activated.
TEST=Input something in omnibox, eg. "goog", make sure the inline autocomplete is activated, then press ctrl key to see if the inline autocomplete is still there.
TEST=Input something in omnibox, eg. "cnn", press ctrl-Enter to see if www.cnn.com is opened.
Review URL: http://codereview.chromium.org/173462
------------------------------------------------------------------------
|
|||||||||||||||||
,
Aug 27, 2009
(No comment was entered for this change.)
Status: Fixed
|
|||||||||||||||||
,
Aug 31, 2009
Issue 20701 has been merged into this issue.
Cc: de...@chromium.org
|
|||||||||||||||||
,
Sep 03, 2009
Issue 21009 has been merged into this issue. |
|||||||||||||||||
| ► Sign in to add a comment | |||||||||||||||||