My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 201000: Collect chrome crash dumps during testing
5 people starred this issue and may be notified of changes. Back to list
 
Project Member Reported by nsand...@chromium.org, Jul 20, 2011
From  issue 13758 

We rev chrome more-or-less every day.  Sometimes intermittent crashes get introduced --  an inherent risk of staying close to ToT.  Tests that make chrome do stuff might expose these intermittent bugs.  That does not mean that the tests are flaky and should be disabled, it means that Chrome is segfaulting some of the time on or around login or logout, and someone should try to figure out what's up with that.

Unfortunately, I don't think we gather any crash dumps for chrome during tests.  I believe this is because we hate ourselves and like to make our own lives difficult.  But...still, this bug is not particularly meaningful and should probably be closed.  A Chrome SEGV that happens to occur during one of the smoke suite tests could be any one of a zillion things.


Chris, do you know who could implement this? 


Mar 16, 2013
#1 bugdroid1@chromium.org
(No comment was entered for this change.)
Blockedon: chromium-os:18269 chromium-os:18637 chromium-os:18638
Blocking: chromium-os:17899 chromium-os:18484
Jul 20, 2011
#2 nsand...@chromium.org
(No comment was entered for this change.)
Blocking: 17899
Jul 20, 2011
#3 cmasone@chromium.org
Perhaps mkrebs?  I know he's working on all manner of crash reporter things these days.  
Owner: mkr...@chromium.org
Cc: kmix...@chromium.org
Jul 21, 2011
#4 petkov@chromium.org
 Issue 17987  has been merged into this issue.
Cc: petkov@chromium.org davemo...@chromium.org r...@chromium.org zelidrag@chromium.org r...@chromium.org
Jul 25, 2011
#5 davidjames@chromium.org
This is critical to debugging Chrome flakiness on tip of tree. Without logs, it is not possible to debug Chrome crashes
Labels: -Pri-1 Pri-0 TreeCloser
Jul 26, 2011
#6 cmasone@chromium.org
The first step is to create /mnt/stateful_partition/etc/enable_chromium_coredumps

I'm not sure where to create this...there doesn't seem to be a good place in an ebuild to do it, off the top of my head.
Jul 27, 2011
#7 cmasone@chromium.org
Taking this over
Status: Started
Owner: cmasone@chromium.org
Jul 27, 2011
#8 mkr...@chromium.org
I have a change pending (http://gerrit.chromium.org/gerrit/#change,4861) that will allow the crash reporter to collect chrome crashes if a certain file exists.  This is basically what Darin suggested in "http://crosbug.com/17987", where Autotest's UITest class could create/remove that file.  If that's useful for this issue, I expect the change to be submitted soon.

Jul 27, 2011
#9 cmasone@chromium.org
http://gerrit.chromium.org/gerrit/#change,4876

I wrote this up today, which touches a different magic file that -- apparently -- we've supported for quite some time now, and causes chrome to actually dump core.  It also copies those core files back over when the test is done.  we'd need to symbolize the core file, but we've already got code that symbolizes minidumps at the end of an autotest run, so it's gotta be doable :-)

I dunno, I tend to favor the solution that does not require any changes outside of autotest, but am mostly indifferent.
Jul 28, 2011
#10 cmasone@chromium.org
Talked to Ken, and I am wrong :-)

My change would disable the collecting of all non-chrome crash dumps :-P

So, I will update the change I made to create the magic file that Mike's code looks for instead. 
Jul 28, 2011
#11 cmasone@chromium.org
(No comment was entered for this change.)
Owner: mkr...@chromium.org
Jul 28, 2011
#12 bugdroid1@chromium.org
Commit: eb32f939c38d5bc3dad323d5d9e3778b32001c5b
 Email: cmasone@chromium.org

[autotest] Enable Chrome coredumps, copy back to the device after UITests.

Touch the magic file to enable crash_reporter to handle chrome minidumps.

BUG=chromium-os:17898
TEST=manually trigger crash during a test, see that the core files are copied back

Change-Id: Id2b010fcd335e2efa243aefb2b8896cdc5c927ab
Reviewed-on: http://gerrit.chromium.org/gerrit/4876
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Michael Krebs <mkrebs@chromium.org>

M	client/cros/constants.py
M	client/cros/cros_ui_test.py
Jul 28, 2011
#13 cmasone@chromium.org
 Issue 16513  has been merged into this issue.
Cc: davidjames@chromium.org an...@chromium.org derat@chromium.org
Jul 28, 2011
#14 cmasone@chromium.org
 Issue 16514  has been merged into this issue.
Jul 28, 2011
#15 cmasone@chromium.org
 Issue 16515  has been merged into this issue.
Jul 29, 2011
#16 bugdroid1@chromium.org
Commit: 9e8e5f468993a49b0004a3bcef5c81b9e1fe1f63
 Email: mkrebs@chromium.org

Don't ignore chrome crashes when autotesting.

If the file "/mnt/stateful_partition/etc/collect_chrome_crashes" exists on
the target, allow chrome crashes to be reported by crash reporter.  The
intention is that the autotest system will create this file.  This is a
relatively temporary fix to help track down chrome problems, until the
crashes can be handled by crash reporter in the field as well.

BUG=chromium-os:17987, chromium-os:17898
TEST=Ran unit tests.

Change-Id: I68a584a0b861669117d8e97f5687b4c8fc876011
Reviewed-on: http://gerrit.chromium.org/gerrit/4861
Reviewed-by: Ken Mixter <kmixter@chromium.org>
Tested-by: Ken Mixter <kmixter@chromium.org>

M	user_collector.cc
M	user_collector.h
M	user_collector_test.cc
Jul 29, 2011
#17 kmix...@chromium.org
I pushed Mike's change though there's still a need to generate the /mnt/stateful_partition/etc/collect_chrome_crashes during tests.
Jul 29, 2011
#18 cmasone@chromium.org
I landed a change yesterday to do that :-)

So...we should be good!
Status: Fixed
Jul 29, 2011
#19 cmasone@chromium.org
Whoops.  Chrome crashes get put in the cryptohome while users are logged in.  So we'll need to copy them out.
Status: Started
Jul 29, 2011
#20 cmasone@chromium.org
(No comment was entered for this change.)
Owner: cmasone@chromium.org
Jul 29, 2011
#21 bugdroid1@chromium.org
Commit: b0e162534f79f16882088699fc07464c77ac835e
 Email: cmasone@chromium.org

[autotest] Copy crash reports out of cryptohome on every logout

We're losing Chrome crash reports that occur while the user is logged in.
Copy them out so that we can process the minidumps.

BUG=chromium-os:17898
TEST=suite_Smoke

Change-Id: I1faaab8c48b4b9677adae2081c70f0394e1e39e3
Reviewed-on: http://gerrit.chromium.org/gerrit/5045
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Gaurav Shah <gauravsh@chromium.org>

M	client/cros/cros_ui_test.py
M	client/site_tests/login_CryptohomeMounted/login_CryptohomeMounted.py
M	client/site_tests/power_LoadTest/power_LoadTest.py
Aug 1, 2011
#22 bugdroid1@chromium.org
Commit: cafdb0487979ecc4e414213a2aeb170ba20f50e4
 Email: cmasone@chromium.org

[autotest] Ensure we grab chrome crashes when we log out

Missed a couple spots where we call logout()

BUG=chromium-os:17898
TEST=manual, introduce a 'pkill -11 ^chrome$' in the middle of some test that logs in, run it, and ensure that we copy back chrome crash dumps

Change-Id: Ie8abe567c0e7b7fd69755b99bbc6f12763304254
Reviewed-on: http://gerrit.chromium.org/gerrit/5070
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>

M	client/cros/cros_ui_test.py
Aug 1, 2011
#23 cmasone@chromium.org
(No comment was entered for this change.)
Blocking: 18484
Aug 2, 2011
#24 stevenjb@chromium.org
(No comment was entered for this change.)
Cc: stevenjb@chromium.org
Aug 3, 2011
#25 cmasone@chromium.org
As thieu pointed out, grabbing crash reports -before- logging out does not mean we'll get the crashes that occur during log out.

That's harder.  Thieule and mkrebs are working on this now.
Owner: thieule@chromium.org
Labels: Mstone-R14
Aug 3, 2011
#26 gauravsh@chromium.org
(No comment was entered for this change.)
Cc: gauravsh@chromium.org
Aug 3, 2011
#27 thieule@chromium.org
(No comment was entered for this change.)
Blockedon: 18637 18638
Aug 3, 2011
#28 bugdroid1@chromium.org
Commit: e8bd1ae8d444b27a68c1c8da28915a44118a09c6
 Email: mkrebs@chromium.org

Fix logging_UserCrash for recent crash_reporter change.

Don't test that a core file is left behind for developer builds.  Commit
http://gerrit.chromium.org/gerrit/#change,4861 changed crash_reporter to
always remove core files if we're in the middle of testing crash reporting
itself.

BUG=chromium-os:17987, chromium-os:17898
TEST=Ran logging_UserCrash remote test

Change-Id: I08e3995f1ba62f1a5b48613b256dc8b031592498
Reviewed-on: http://gerrit.chromium.org/gerrit/5185
Reviewed-by: Ken Mixter <kmixter@chromium.org>
Tested-by: Michael Krebs <mkrebs@chromium.org>

M	client/site_tests/logging_UserCrash/logging_UserCrash.py
Aug 8, 2011
#29 cmasone@chromium.org
https://sandbox.google.com/storage/chromeos-image-archive/x86-pineview-full/0.15.870.0-a1-b47/_index.html

Hm.  Looks like we got _a_ chrome crash dump, though it's also filed in the wrong test case somehow (login_CryptohomeIncognitoUnmounted instead of login_CryptohomeMounted)

it's not symbolized, though the debug symbols seem to also be available at the link above...I'm confuzzled.  But, perhaps this will at least enable us to get someone to start working on  bug17899 ?
Aug 8, 2011
#30 davidjames@chromium.org
Here are stacktraces from http://chromeos-botmaster.mtv.corp.google.com:8026/builders/x86-mario%20canary/builds/837 and http://chromeos-botmaster.mtv.corp.google.com:8026/builders/x86-mario%20canary/builds/838

FYI, here is recipe for generating stacktrace:
  $ wget http://chromeosbuild7.mtv.corp.google.com/archive/x86-mario-release/0.15.871.0-a1-b838/test_results.tgz
  $ wget http://chromeosbuild7.mtv.corp.google.com/archive/x86-mario-release/0.15.871.0-a1-b838/debug.tgz
  $ tar -xzf test_results.tgz
  $ tar -xzf debug.tgz
  $ ( for i in $(find test_harness -name "chrome*.dmp"); do minidump_stackwalk $i debug/breakpad; done ) > stack.txt 2>/dev/null
stack-b837.txt
35.6 KB   View   Download
stack-b838.txt
42.6 KB   View   Download
Aug 8, 2011
#31 cmasone@chromium.org
well, the b838 track looks like the bug we've been looking for in 17899 -- but I don't know how much it will help :-/

Aug 9, 2011
#32 davemo...@chromium.org
and b837 looks like this: https://code.google.com/p/chromium-os/issues/detail?id=18269
Blockedon: 18269
Aug 9, 2011
#33 cmasone@chromium.org
So, we actually collect these crashes now.  As such, I will mark it fixed.  Continuing work is tracked elsewhere.

crosbug.com/18484 tracks symbolizing them correctly (thieule is on it, he knows what needs doing)
The crashes that originally triggered this are tracked in crosbug.com/17899 and crosbug.com/18269
Associating dumps with correct tests tracked in crosbug.com/18943 (we seem to have some kind of one-off error currently)
Status: Fixed
Aug 12, 2011
#34 kr...@chromium.org
(No comment was entered for this change.)
Status: Verified
Aug 18, 2011
#35 or...@chromium.org
(No comment was entered for this change.)
Labels: Iteration-36
Sep 7, 2011
#36 chromeos...@chromium.org
(No comment was entered for this change.)
Labels: FixedIn-0.15-848.0
Oct 25, 2011
#37 chromeos...@chromium.org
(No comment was entered for this change.)
Labels: -FixedIn-0.15-848.0 FixedIn-848.0.0
Jan 20, 2012
#38 chromeos...@chromium.org
(No comment was entered for this change.)
Labels: FixedInIndex-1d
Mar 6, 2013
#39 bugdroid1@chromium.org
(No comment was entered for this change.)
Labels: OS-Chrome
Blockedon: -chromium-os:18269 -chromium-os:18637 -chromium-os:18638 chromium-os:18269 chromium-os:18637 chromium-os:18638
Blocking: -chromium-os:17899 -chromium-os:18484 chromium-os:17899 chromium-os:18484
Mar 9, 2013
#40 bugdroid1@chromium.org
(No comment was entered for this change.)
Labels: -Area-Test -TreeCloser -Mstone-R14 Cr-Test Hotlist-TreeCloser M-14
Sign in to add a comment

Powered by Google Project Hosting