My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 192460: Sync is not working
12 people starred this issue and may be notified of changes. Back to list
 
Project Member Reported by nkostylev@chromium.org, Dec 6, 2010
Chrome OS Version  :  0.9.129.x dev
Chrome Version     :  10.0.604.0 (official 68339)
Type of computer   :  mario

What steps will reproduce the problem?
1. Login with the new user to Chrome OS which has syncable data
2. Observe sync status

What is the expected output?
Sync is working.

What do you see instead?
Sync is not working.

Manually enabling sync (entering password again) doesn't work.

Logs/screenshots are here http://www.corp.google.com/~nkostylev/no_crawl/cros/sync_bug/

Some of them
http://www.corp.google.com/~nkostylev/no_crawl/cros/sync_bug/About%20Sync.html
http://www.corp.google.com/~nkostylev/no_crawl/cros/sync_bug/chrome_sys
http://www.corp.google.com/~nkostylev/no_crawl/cros/sync_bug/chrome_user_before_forced_setup

After I've entered sync credentials via settings
http://www.corp.google.com/~nkostylev/no_crawl/cros/sync_bug/chrome_user_after_setup
Mar 13, 2013
#1 lafo...@gmail.com
(No comment was entered for this change.)
Blocking: chromium-os:9814
Dec 6, 2010
#2 nkostylev@chromium.org
(No comment was entered for this change.)
Cc: cmas...@chromium.org
Dec 6, 2010
#3 anna...@chromium.org
No repro, build 0.9.128.9 (CrOS first-run for existing sync accounts, as well as new accounts). 

Looking at the ChromeOS (and in particular Chrome build versions) - this is not a release build. Are you running on ToT?

Have you initiated a stop sync and clear sync data through the Google Dashboard - this might be a reason why you would encounter the sync disabled state? 


Dec 6, 2010
#4 nkostylev@chromium.org
>> Looking at the ChromeOS (and in particular Chrome build versions) - this is not a release build. Are you running on ToT?

Yes, issue reproduces on TOT CrOS builds.

>> Have you initiated a stop sync and clear sync data through the Google Dashboard
Yes, but it didn't help.

Also it's strange that sync shows disabled status for accounts that have it clearly enabled and working previously (like @google accounts).

Please take a look at the logs.

After I've signed in, sync showed that it's not configured (chrome://settings),
then I've entered credentials.
Logs show that some entities were synced http://www.corp.google.com/~nkostylev/no_crawl/cros/sync_bug/chrome_user_after_setup

but after that status is disabled
http://www.corp.google.com/~nkostylev/no_crawl/cros/sync_bug/About%20Sync.html
Dec 7, 2010
#5 nkostylev@chromium.org
To make it clear - works fine for R9.x but should be fixed on TOT for future builds.
Labels: Mstone-R10
Dec 7, 2010
#6 nkostylev@chromium.org
I have a pending CL for remaining parallel auth work
http://codereview.chromium.org/5641001/

It changes how cookies/tokens are fetched and I intend to test it with sync working on TOT to make sure it won't break anything.


Dec 7, 2010
#7 jasn...@chromium.org
Sync not working with today's release build : ChromeOS 0.9.130.0 Chrome 9.0.597.10. Going to about:sync - Summary Sync Disabled. 
Dec 8, 2010
#8 kan...@chromium.org
(No comment was entered for this change.)
Status: Assigned
Labels: -Mstone-R10 Mstone-R9.y
Dec 8, 2010
#9 or...@chromium.org
Bulk addition of beta block label.
Labels: ReleaseBlock-Beta
Dec 8, 2010
#10 cmasone@chromium.org
There are several changelists that are now blocked on this, both nikita's and my own, so upping the priority.
Labels: -Pri-1 Pri-0
Dec 8, 2010
#11 akalin@chromium.org
stevenjb@, can you investigate this?  I just got back from sick leave and am swamped. :(
Owner: stevenjb.chromium.org
Cc: steve...@google.com
Dec 8, 2010
#12 tim@chromium.org
Only a single sync change in chrome between 597.10 and 597.0, and it's a no-op on release builds. still looking...
Dec 9, 2010
#13 stevenjb@chromium.org
I am seeing this too on a recent ToT build, will start investigating right away.
Dec 9, 2010
#14 cmasone@chromium.org
@tim, this is on ToT, not the 597 branch.  It's keeping folks from testing CLs on trunk that we want to land and then merge to 597, though, which I think it why it's targeted at Mstone-R9.y
Dec 9, 2010
#15 tim@chromium.org
hm, comment 6 mentioned Chrome 9.0.597.10.
Dec 9, 2010
#16 stevenjb@chromium.org
I've isolated the problem down to commit http://src.chromium.org/viewvc/chrome?view=rev&revision=67278.

I double checked it because there is no obvious relationship between the CL and sync: http://codereview.chromium.org/4804001.

Investigating further.


Dec 9, 2010
#17 stevenjb@chromium.org
Aha.

CanShowPromo() is called from WebResourceService::Init() which calls:
sync_ui_util::GetStatus(profile->GetProfileSyncService())

I am guessing that this is initializing sync earlier than expected and causing the problem.

A quick fix would be to just use kShortCacheUpdateDelay instead of calling CanShowPromo() from Init(). Will sync with everyone first thing tomorrow and get a CL pushed.


Cc: aka...@chromium.org miran...@chromium.org a...@chromium.org
Dec 9, 2010
#18 mirandac@chromium.org
D'oh -- sorry about this. Actually, for now, we can switch to kLongCacheUpdateDelay, and remove the short version.  I can put in a CL for this first thing tomorrow morning, if you don't get to it first.
Dec 9, 2010
#19 stevenjb@chromium.org
Bah. It may not be that simple. The fix seemed to work in the test branch with (@67278 + the fix) but not in tot. Going back to the branch and will work forward. It's possible that a similar change introduced the same problem elsewhere (something we clearly need to fix).

Also I discovered issue  issue 9316  - sync tests and page cycler tests have been removed from build. 
I don't know if the tests would have caught this, but we clearly need to re-enable them and ensure they catch this sort of error.
 
Dec 9, 2010
#20 miran...@google.com
Hmm, CanShowPromo() is also called in NTPResourceCache, which may also be called early enough on to cause pain.  Can we put a check in CanShowPromo to specifically *not* initialize sync if it hasn't been initialized yet, and just return false instead?
Dec 10, 2010
#21 sotong0...@gmail.com
Chrome OS Version  : Chromium OS 0.9.131.2010_12_09_2217(Developer Build b5ed3128)
Chrome Version     :  Google Chrome 9.0.600.0(67982)
Type of computer   :  Lenovo s10-3
Network info       :  Ethernet, TP-Link TD-8816
Screenshot           : http://pixelpipe.com/item/29ab72d3-6e8e-422b-9bff-b58268e7d077
Screenshot           : http://pixelpipe.com/item/d13c1fb7-b4f6-428d-af8b-05a425753640

Same Problem (Sync can't work functionly )

Older version also can't sync(but the panel is show option, see the screenshot)
OlderVersion(Chromium OS 0.9.129.2010_12_05_0759, Chromium 8.0.552.333)Screenshot: http://pixelpipe.com/item/a3b63169-b85f-4ebb-8422-286cf7b50069

P.S.I have send the bug repot via built-in bug report but I don't know is it (bug report) work
Dec 10, 2010
#22 cmasone@chromium.org
Steven, I don't know if the sync_integration_tests would have caught this issue, as it sounds like you're saying it has to do with the timing of sync startup. I wouldn't be surprised if it only repros when you run Chromium for Chromium OS with the login screen and everything.

Sounds like autotests are required.
Dec 10, 2010
#23 miran...@google.com
I created a patch of CanShowPromo that doesn't allow it to initialize the sync service: http://codereview.chromium.org/5685004/

...if this works for you, I will commit ASAP.
Dec 10, 2010
#24 stevenjb@chromium.org
OK, false alarm. I must have been bleary-eyed at the end of the day yesterday, or sync was just acting up. mirandac's patch works fine in ToT. I will lgtm it and create an issue to protect sync from early initialization and look into enabling or creating an auto test that would catch this.

Dec 10, 2010
#25 stevenjb@chromium.org
Created  issue 10209  to properly fix GetProfileSyncService().
Also created  issue 10214  to add an auto test for sync.

Dec 11, 2010
#26 sotong0...@gmail.com
Wish this issue can fix quickly.
Dec 11, 2010
#27 mirandac@chromium.org
Should have been resolved by my patch (comment 22), but I don't have the power to mark this bug fixed.  :-)
Dec 12, 2010
#28 akalin@chromium.org
I'll do it! :)
Status: Fixed
Dec 13, 2010
#29 stevenjb@chromium.org
 Issue 10041  has been merged into this issue.
Cc: kr...@chromium.org tturche...@chromium.org kan...@chromium.org anna...@chromium.org
Dec 13, 2010
#30 kr...@chromium.org
 Issue 10290  has been merged into this issue.
Dec 13, 2010
#31 kr...@chromium.org
Have this been merged into Chrome 9?  I am still seeing it with 9.0.597.19 (Official Build 68937)
Dec 13, 2010
#32 miran...@google.com
Will contact laforge and merge asap.
Dec 13, 2010
#33 kr...@chromium.org
You rock miranda!
Labels: ForMerge-597
Dec 13, 2010
#34 lafo...@chromium.org
If it's possible to hold off until we clear beta for 597.  At this point our crash rate is too high >300/M on the browser, and I'm only accepting patches for stability fixes (to ensure short QA passes and limited risk).
Dec 20, 2010
#35 stevenjb@chromium.org
Issue 10461 has been merged into this issue.
Dec 20, 2010
#37 jasn...@chromium.org
Note : Issue reproducible on ChromeOS 0.9.130.7 Chrome 9.0.597.21
Dec 20, 2010
#38 stevenjb@chromium.org
9.0.597.21 corresponds to revision 69611. 
Fix is at revision 69726.


Jan 12, 2011
#39 srikan...@chromium.org
Chrome OS Version  :  0.10.142.0 
Chrome Version     :  10.0.634.0
Status: Verified
Jan 13, 2011
#40 or...@chromium.org
Please (re)verify on the latest R9.y build
Status: Fixed
Labels: -ForMerge-597 VerifiedIn-10.0.634.0
Jan 14, 2011
#41 anna...@chromium.org
Not seeing a repro, builds:
   - 0.9.130.9 (Chrome 9.0.597.34)
   - 0.10.140.0 (Chrome 10.0.633.0).
Labels: VerifiedIn-9.0.597.34
Jan 14, 2011
#42 pumaka...@chromium.org
Verified and Sync working with the latest R9.y build.


Chrome OS	0.9.130.10 (Official Build 35b1aebf) dev x86-mario test
Google Chrome	8.0.552.344 (Official Build 70793)
Status: Verified
Feb 11, 2011
#43 cepe...@chromium.org
I'm seeing the 'Sync Error' issue

Chrome OS 0.9.130.15 N+1 AU Test Image
Google Chrome 8.0.552.344
Feb 11, 2011
#44 hube...@google.com
 I'm also seeing this 'Sync Error' in bookmarks bar. It will not go away. Can't change sync from Dashboard.

about:sync states "INVALID_GAIA_CREDENTIALS" in Authentication failed.

Chrome OS: 0.9.130.14 (Official Build ce79fb21) beta x86-mario
Google Chrome: 8.0.552.344
Feb 11, 2011
#45 anna...@chromium.org
Have you enabled app-specific passwords recently?
Feb 11, 2011
#46 cepe...@chromium.org
Yes I upgraded my account for 'app-specific passwords' When I click on the 'Sync Error' in toolbar, it does nothing. Even when I downgrade my account to disable 'app-specific passwords' i still receive the sync error.

Chrome OS 0.9.130.15 N+1 AU Test Image
Google Chrome 8.0.552.344
Feb 11, 2011
#47 anna...@chromium.org
This is likely a duplicate of crosbug.com/11931. 
Mar 6, 2013
#48 lafo...@google.com
(No comment was entered for this change.)
Labels: OS-Chrome
Blocking: -chromium-os:9814 chromium-os:9814
Mar 9, 2013
#49 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Area-Sync Cr-Services-Sync
Sign in to add a comment

Powered by Google Project Hosting