| Issue 18472: | Crash at stl_tree.h:613 extension_file_util::LoadExtension(FilePath const&, bool, std::string*) | |
| 18 people starred this issue and may be notified of changes. | Back to list |
|
Sign in to add a comment
|
The full crash report details can be found at: http://go/crash/reportdetail?reportid=a5d4665f5bc15da3&product=Chrome_Linux&version=3.0.196.0&signature=extension_file_util%3A%3ALoadExtension(FilePath+const%26%2C+bool%2C+std%3A%3Astring*)-59AC2E Meta information: Client ID: E50025F7D228D65427F6FC18D8236A78 Report ID: a5d4665f5bc15da3 Report Time: 2009/08/05 03:52:17, Wed Uptime: 0 sec Cumulative Uptime: 0 sec User Email: User Comments: Product Name: Chrome_Linux Product Version: 3.0.196.0 OS Name: Linux OS Version: 0.0.0 Linux 2.6.24-gg24-generic #1 SMP Wed Apr 22 21:48:06 PDT 2009 x86_64 CPU Architecture: x86 CPU Info: AuthenticAMD family 1 model 65 stepping 2 ptype: browser lsb-release: Ubuntu 8.04.2 Stack Trace: Thread 0 0xf7321545 [libc-2.7.so] +0x000c9545 0xf7d24141 [libgtk-x11-2.0.so.0.1200.9] +0x00197141 0xf7d24448 [libgtk-x11-2.0.so.0.1200.9] +0x00197448 0xf7d3fc33 [libgtk-x11-2.0.so.0.1200.9] +0x001b2c33 0xf7d3fdc4 [libgtk-x11-2.0.so.0.1200.9] +0x001b2dc4 0xf7d59f6b [libgtk-x11-2.0.so.0.1200.9] +0x001ccf6b 0xf7a1bf45 [libgobject-2.0.so.0.1600.3] +0x0002af45 0xf7a01241 [libgobject-2.0.so.0.1600.3] +0x00010241 0xf7a01a07 [libgobject-2.0.so.0.1600.3] +0x00010a07 0xf7a02550 [libgobject-2.0.so.0.1600.3] +0x00011550 0xf7a026bf [libgobject-2.0.so.0.1600.3] +0x000116bf 0xf7d52016 [libgtk-x11-2.0.so.0.1200.9] +0x001c5016 0xf7df7e6c [libgtk-x11-2.0.so.0.1200.9] +0x0026ae6c 0xf7df7f0d [libgtk-x11-2.0.so.0.1200.9] +0x0026af0d 0xf7a1bd99 [libgobject-2.0.so.0.1600.3] +0x0002ad99 0xf7a01241 [libgobject-2.0.so.0.1600.3] +0x00010241 0xf7a01a07 [libgobject-2.0.so.0.1600.3] +0x00010a07 0xf7a02550 [libgobject-2.0.so.0.1600.3] +0x00011550 0xf7a026bf [libgobject-2.0.so.0.1600.3] +0x000116bf 0xf7e0dd73 [libgtk-x11-2.0.so.0.1200.9] +0x00280d73 0x082a36fd [chrome] - browser_window_gtk.cc:393 BrowserWindowGtk::BrowserWindowGtk(Browser*) 0x0829fd83 [chrome] - browser_window_factory_gtk.cc:12 _ZN13BrowserWindow19CreateBrowserWindowEP7Browser:F(0,5200)=*(0,5201)=xsBrowserWindow 0x0823eb77 [chrome] - browser.cc:275 Browser::CreateBrowserWindow() 0x0823f3d3 [chrome] - browser.cc:253 Browser::Create(Profile*) 0x08248ff6 [chrome] - browser_init.cc:565 BrowserInit::LaunchWithProfile::OpenURLsInBrowser(Browser*, bool, std::vector<GURL, std::allocator<GURL> > const&) 0x08249ead [chrome] - browser_init.cc:438 BrowserInit::LaunchWithProfile::Launch(Profile*, bool) 0x0824b163 [chrome] - browser_init.cc:335 BrowserInit::ProcessCmdLineImpl(CommandLine const&, std::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> > const&, bool, Profile*, int*, BrowserInit*) 0x08069f8f [chrome] - browser_init.h:39 BrowserMain(MainFunctionParams const&) 0x08060d89 [chrome] - chrome_dll_main.cc:539 ChromeMain 0x0805fc4e [chrome] - chrome_exe_main_gtk.cc:33 main 0xf726e44f [libc-2.7.so] +0x0001644f 0x0805fbb0 [chrome] +0x00017bb0 Thread 1 *CRASHED* 0x08275810 [chrome] - stl_tree.h:613 extension_file_util::LoadExtension(FilePath const&, bool, std::string*) 0x080ae155 [chrome] - extensions_service.cc:569 ExtensionsServiceBackend::LoadInstalledExtension(std::string const&, FilePath const&, Extension::Location) 0x080aca31 [chrome] - tuple.h:435 CallbackImpl<ExtensionsServiceBackend, void (ExtensionsServiceBackend::*)(std::string const&, FilePath const&, Extension::Location), Tuple3<std::string const&, FilePath const&, Extension::Location> >::RunWithParams(Tuple3<std::string const&, FilePath const&, Extension::Location> const&) 0x082856e9 [chrome] - task.h:553 InstalledExtensions::VisitInstalledExtensions(CallbackRunner<Tuple3<std::string const&, FilePath const&, Extension::Location> >*) 0x080ad1af [chrome] - extensions_service.cc:517 ExtensionsServiceBackend::LoadInstalledExtensions(scoped_refptr<ExtensionsService>, InstalledExtensions*) 0x080b02fe [chrome] - tuple.h:429 RunnableMethod<ExtensionsServiceBackend, void (ExtensionsServiceBackend::*)(scoped_refptr<ExtensionsService>, InstalledExtensions*), Tuple2<scoped_refptr<ExtensionsService>, InstalledExtensions*> >::Run() 0x084b9c58 [chrome] - message_loop.cc:313 MessageLoop::RunTask(Task*) 0x084b9d35 [chrome] - message_loop.cc:321 MessageLoop::DeferOrRunPendingTask(MessageLoop::PendingTask const&) 0x084b9f59 [chrome] - message_loop.cc:428 MessageLoop::DoWork() 0x084bc5bb [chrome] - message_pump_libevent.cc:224 base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) 0x084ba4b1 [chrome] - message_loop.cc:198 MessageLoop::RunInternal() 0x084ba5a5 [chrome] - message_loop.cc:155 MessageLoop::Run() 0x084e000f [chrome] - thread.cc:156 base::Thread::ThreadMain() 0x084c6b70 [chrome] - platform_thread_posix.cc:26 ThreadFunc(void*) 0xf765d4fa [libpthread-2.7.so] +0x000054fa 0xf733109d [libc-2.7.so] +0x000d909d Thread 2 0xffffe405 [linux-gate.so] +0x00000405 __kernel_vsyscall 0xf7661f14 [libpthread-2.7.so] +0x00009f14 0x084eeb1a [chrome] - waitable_event_posix.cc:195 base::WaitableEvent::TimedWait(base::TimeDelta const&) 0x084eeb55 [chrome] - waitable_event_posix.cc:201 base::WaitableEvent::Wait() 0x084baf40 [chrome] - message_pump_default.cc:42 base::MessagePumpDefault::Run(base::MessagePump::Delegate*) 0x084ba4b1 [chrome] - message_loop.cc:198 MessageLoop::RunInternal() 0x084ba5a5 [chrome] - message_loop.cc:155 MessageLoop::Run() 0x084e000f [chrome] - thread.cc:156 base::Thread::ThreadMain() 0x084c6b70 [chrome] - platform_thread_posix.cc:26 ThreadFunc(void*) 0xf765d4fa [libpthread-2.7.so] +0x000054fa 0xf733109d [libc-2.7.so] +0x000d909d Thread 3 0xffffe405 [linux-gate.so] +0x00000405 __kernel_vsyscall 0xf732da46 [libc-2.7.so] +0x000d5a46 0x086063ba [chrome] - event.c:513 event_base_loop 0x084bc5b3 [chrome] - message_pump_libevent.cc:253 base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) 0x084ba4b1 [chrome] - message_loop.cc:198 MessageLoop::RunInternal() 0x084ba5a5 [chrome] - message_loop.cc:155 MessageLoop::Run() 0x084e000f [chrome] - thread.cc:156 base::Thread::ThreadMain() 0x084c6b70 [chrome] - platform_thread_posix.cc:26 ThreadFunc(void*) 0xf765d4fa [libpthread-2.7.so] +0x000054fa 0xf733109d [libc-2.7.so] +0x000d909d Thread 4 0xffffe405 [linux-gate.so] +0x00000405 __kernel_vsyscall 0xf7661f14 [libpthread-2.7.so] +0x00009f14 0x084eeb1a [chrome] - waitable_event_posix.cc:195 base::WaitableEvent::TimedWait(base::TimeDelta const&) 0x084eeb55 [chrome] - waitable_event_posix.cc:201 base::WaitableEvent::Wait() 0x084baf40 [chrome] - message_pump_default.cc:42 base::MessagePumpDefault::Run(base::MessagePump::Delegate*) 0x084ba4b1 [chrome] - message_loop.cc:198 MessageLoop::RunInternal() 0x084ba5a5 [chrome] - message_loop.cc:155 MessageLoop::Run() 0x084e000f [chrome] - thread.cc:156 base::Thread::ThreadMain() 0x084c6b70 [chrome] - platform_thread_posix.cc:26 ThreadFunc(void*) 0xf765d4fa [libpthread-2.7.so] +0x000054fa 0xf733109d [libc-2.7.so] +0x000d909d |
,
Aug 05, 2009
Same crash is also occurring on OSX in 3.0.196.0, similar stack: http://crash/reportdetail?reportid=014b1fdcb792fcfa&product=Chrome_Mac&version=3.0.196.0&date=&signature=extension_file_util::LoadExtension(FilePath+const%26,+bool,+std::string*)-678654
Status: Available
Cc: a...@chromium.org j...@chromium.org erik...@chromium.org Labels: OS-Mac Crash |
|
,
Aug 05, 2009
(No comment was entered for this change.)
Cc: jer...@chromium.org
|
|
,
Aug 05, 2009
Heh, didn't realize I was the owner of this. Aaron, any thoughts?
Cc: a...@chromium.org
|
|
,
Aug 05, 2009
Issue 18538 has been merged into this issue. |
|
,
Aug 05, 2009
The function in question is really long, and we don't have a line number for the crash. I read the code and it looks ok enough to me; there are a lot of fields, though, so maybe one of them is NULL. |
|
,
Aug 05, 2009
Tony fixed this already a few days ago. :~(
commit 1c156612f2f7a510a683329d53472db8afc002d5
Author: tc@google.com <tc@google.com@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Mon Aug 3 23:22:10 2009 +0000
Put the null pointer check for theme images before we use the
pointer.
This was crashing for me with the theme I had installed.
Review URL: http://codereview.chromium.org/160550
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22342 0039d316-1c4b-4281-
b951-d872f2087c98
diff --git a/chrome/browser/extensions/extension_file_util.cc
b/chrome/browser/extensions/extension_file_util.cc
index 15e3cf8..b46404c 100644
--- a/chrome/browser/extensions/extension_file_util.cc
+++ b/chrome/browser/extensions/extension_file_util.cc
@@ -196,8 +196,8 @@ Extension* LoadExtension(const FilePath& extension_path, bool
require_key,
// Theme resource validation.
if (extension->IsTheme()) {
DictionaryValue* images_value = extension->GetThemeImages();
- DictionaryValue::key_iterator iter = images_value->begin_keys();
if (images_value) {
+ DictionaryValue::key_iterator iter = images_value->begin_keys();
while (iter != images_value->end_keys()) {
std::string val;
if (images_value->GetString(*iter , &val)) {
Status: Fixed
Owner: tony.chromium |
|
,
Aug 06, 2009
Issue 18556 has been merged into this issue.
Cc: fin...@chromium.org j...@chromium.org
|
|
,
Aug 06, 2009
Issue 18592 has been merged into this issue. |
|
,
Aug 06, 2009
Issue 18467 has been merged into this issue. |
|
,
Aug 06, 2009
Isn't Issue 18467 before Issue 18472 ? I thought the issues weer being merged to the first Issue that was submitted about the same problem... |
|
,
Aug 06, 2009
#10: I don't think there's a rule. I usually use the version of the bug that has the most and best information as the master. |
|
,
Aug 06, 2009
I see, that makes since, well then I think that Issue 18456 should be merged into this one then, or vice versa |
|
,
Aug 07, 2009
Issue 18518 has been merged into this issue.
Cc: g...@chromium.org m...@chromium.org kr...@chromium.org lafo...@chromium.org venkatar...@chromium.org
|
|
,
Aug 10, 2009
Issue 18745 has been merged into this issue.
Cc: stuartmo...@chromium.org
|
|
,
Aug 10, 2009
Verified on Mac with Chromium version: 3.0.201 SVN Revision: 22966
Status: Verified
|
|
,
Mar 03, 2010
(No comment was entered for this change.)
Labels: Feature-Extensions
|
|
| ► Sign in to add a comment |