My favorites | Sign in
Logo
             
New issue | Search
for
| Advanced search | Search tips
Issue 18385: Head in place of close button
55 people starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  evan@chromium.org
Closed:  Aug 04
Cc:  glen@chromium.org
OS-Linux
Area-BrowserUI
Size-Medium
Type-Bug
Pri-1


Sign in to add a comment
 
Reported by tshnofx, Aug 03, 2009
Chrome Version       : 3.0.197.0 (22354)
OS + version : Debian AMD64(Using 32-bit libs, inapplicable)
CPU architecture (32-bit / 64-bit): x86_64
window manager : GNOME(gtk)
URLs (if applicable) : All
Behavior in Firefox 3.x (if applicable): X button
Behavior in Chrome for Windows (optional): X button

What steps will reproduce the problem?
1. Look at what the X button is supposed to be
2.
3.

What is the expected result?
an X button

What happens instead?
Some guys head

Please provide any additional information below. Attach a screenshot
and backtrace if possible.
I think it's rather self-explanatory
http://img262.imageshack.us/img262/7919/screenshot9.png

I figure it's best to tell the developers who probably don't test **every** 
version.

I suspect it was either a prank or a mistake.

Comment 1 by est...@chromium.org, Aug 03, 2009
this is tragic
Status: Assigned
Owner: g...@chromium.org
Cc: e...@chromium.org
Labels: -Area-Misc Area-BrowserUI Pri-1
Comment 2 by evan@chromium.org, Aug 03, 2009
Aw, I kinda like him peeking over like that...
Comment 3 by pedersen.magnus, Aug 04, 2009
Still there in 22373...
Comment 4 by bugdroid1@chromium.org, Aug 04, 2009
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=22391 

------------------------------------------------------------------------
r22391 | evan@chromium.org | 2009-08-04 10:43:10 -0700 (Tue, 04 Aug 2009) | 5 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/app/resources/app_resources.grd?r1=22391&r2=22390
   M http://src.chromium.org/viewvc/chrome/trunk/src/app/resources/linux_close.png?r1=22391&r2=22390
   A http://src.chromium.org/viewvc/chrome/trunk/src/app/resources/linux_close_glen.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/app/resources/linux_close_h.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/app/resources/linux_close_mask.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/app/resources/linux_close_p.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/app/resources/linux_maximize.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/app/resources/linux_maximize_h.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/app/resources/linux_maximize_mask.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/app/resources/linux_maximize_p.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/app/resources/linux_minimize.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/app/resources/linux_minimize_h.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/app/resources/linux_minimize_mask.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/app/resources/linux_minimize_p.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/app/resources/linux_restore.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/app/resources/linux_restore_h.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/app/resources/linux_restore_p.png
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_titlebar.cc?r1=22391&r2=22390

linux: use linux-specific window control graphics from glen

BUG=15952,18385

Review URL: http://codereview.chromium.org/159859
------------------------------------------------------------------------

Comment 5 by evan@chromium.org, Aug 04, 2009
(No comment was entered for this change.)
Status: Fixed
Comment 6 by est...@chromium.org, Aug 04, 2009
 Issue 18397  has been merged into this issue.
Comment 8 by est...@chromium.org, Aug 04, 2009
 Issue 18421  has been merged into this issue.
Comment 9 by dusan.maliarik, Aug 05, 2009
just wondering what else can get in thru code reviews. you guys... ah, better not to
say anything. such a nice application and now this. there should be more buzz about
it to make less people using chromium, such a insecure bullshit, where everybody can
commit whatever. today it's creepy face, tomorrow it will be malicious code, nice work.
Comment 10 by missingno770, Aug 05, 2009
Funniest bug ever.

But I'm a bit newbie, what's the way to fix it without using GTK+ horrible theme? I 
want a X, no Glen's head.

...sorry, Glen.
Comment 11 by denis.zawada, Aug 05, 2009
@missingno770: Just right click and check [ ] Use system title bar in browser. 
Comment 13 by paniq303, Aug 05, 2009
Oh come on, don't be so abusive. It's an alpha version, it's not even out yet.
Possibly an easter egg gone wrong ;)
Comment 15 by stevenleeg, Aug 05, 2009
This is awesome, I love you google.
Comment 16 by drewshays, Aug 05, 2009
@dusan.maliarik, calm down.  There's nothing malicious about what just happened here, it's simply just 
motivation for someone specific to get something done.  It's fixed now, so clearly this passive-agressive 
behaiour got the message to the right places. ;)
Comment 17 by tomhaste, Aug 05, 2009
Good to know we'll be able to theme almost all aspects of Chromium once its finished :)
Comment 18 by missingno770, Aug 05, 2009
@denis.zawada Thank you. Is that easy. I never realized how idiot I could be =P 
Comment 19 by dennis.groves, Aug 05, 2009
hold up - that is a feature, not a bug. official mascot of chrome - some guys head.
Comment 20 by shevegen, Aug 05, 2009
I rather want an attractive female head than this melon head...
Comment 21 by grintz77, Aug 05, 2009
Thanks for a good laugh
Comment 23 by dhw@chromium.org, Aug 05, 2009
 Issue 18506  has been merged into this issue.
Comment 24 by dhw@chromium.org, Aug 05, 2009
 Issue 18469  has been merged into this issue.
Comment 25 by ceryen, Aug 05, 2009
I never realized a browser could be creepy
Comment 26 by alexandr...@yahoo.com, Aug 05, 2009
So who is this Glen person??? nice, although it should of been on the spy on the 
incognito mode, and on the incognito notice, it should of said watch out Glen is 
watching or something lol!

So was this done in order to emphasize the unindented Restore Down button when pressed?
Comment 27 by drewshays, Aug 05, 2009
This was done as a passive-aggressive motivation to get someone to create the linux 
close/min/max/restore buttons, I believe.  And the message got through, and the work 
was done. ;)
Comment 28 by alexandr...@yahoo.com, Aug 05, 2009
@drewshays nice! thanks for the report :)
Comment 29 by evan@chromium.org, Aug 05, 2009
(No comment was entered for this change.)
Owner: e...@chromium.org
Cc: -e...@chromium.org g...@chromium.org
Comment 30 by ceryen, Aug 05, 2009
P.S. Not to say that Glen is creepy, just that the last thing you would expect in a 
browser is someone watching you :)
Comment 31 by stevecostello, Aug 05, 2009
@ ceryn: Actually, the FIRST thing I expect in a browser is that someone is watching
me....
Comment 32 by sicarius.dracus, Aug 05, 2009
TOASTY!
Comment 34 by bruteork, Aug 05, 2009
sweet
Comment 40 by Christian.Purnomo, Aug 05, 2009
@dusan.maliarik: you can probably learn to be more appreciative

go google!! 
"don't be evil" (tm)
Comment 46 by micdesim, Aug 05, 2009
Good for us it's just "some guys head"...:)
Comment 47 by Bsamuels453, Aug 05, 2009
This would of been funny if it was Rick Astley's head
Comment 48 by jamesda...@gmail.com, Aug 06, 2009
When you go incognito, it should give Glen a blindfold.
Comment 49 by zeuslgn, Aug 06, 2009
"would have" or "would've", not "would of". :)
Comment 50 by dusan.maliarik, Aug 06, 2009
@drewshays: c'mon, somebody has to make people panic ;)
Comment 51 by toddlamp, Aug 06, 2009
Kilroy was there.
Comment 54 by sai.gautam, Aug 06, 2009
I got one too. It was in Ubuntu Jaunty, when I was using Chrome.
Comment 55 by omattos, Aug 06, 2009
The changelog implies that the original /src/app/resources/linux_close.png file was 
just moved to /src/app/resources/linux_close_glen.png .

Since this file is no longer referenced, isn't it just cruft in the codebase?  It 
should be removed, even though it isn't included in the final binary (unless it is part 
of a useful test, in which case it should be renamed and moved to reflect this)
Comment 56 by yuretsz, Aug 06, 2009
New buttons are the worst close\resotre buttons I've ever seen. How can I return old 
ones? 
Comment 57 by micah.alles, Aug 06, 2009
do you want the head back?
Comment 58 by est...@chromium.org, Aug 06, 2009
re 56: you might be seeing the spacing issues on the new buttons. We've fixed them to 
have proper spacing but that change did not get into the latest dev channel release, 
so you will have to live with the crappy spacing for ~1 week if you are on google-
chrome (if you are using the ubuntu nightlies, you will only have to live with it for 
a day or so).
Comment 59 by evan@chromium.org, Aug 06, 2009
re 58: actually, mmoss set me straight -- we did make this dev channel.
the official release should go straight from vista buttons to new-style buttons, no 
heads or other ugly bits in the interim.  (hopefully QA would catch something like the 
glenhead.)
Comment 60 by email.xamox, Aug 06, 2009
Reminds me of the "Toasty!" guy from mortal kombat.
Comment 61 by soulfx, Aug 06, 2009
Damn that's awesome!

http://www.p4o.net
Comment 62 by glen@chromium.org, Aug 07, 2009
 Issue 18756  has been merged into this issue.
Comment 63 by dcavalcante, Aug 08, 2009
Glen is a dead hacker and he's prying into your desktop. Be afraid. Be very afraid!
Comment 64 by lpicanco, Aug 09, 2009
TOASTY [2]
From Mega Drive...

Comment 65 by elcapo, Aug 10, 2009
I already miss Glen...
Comment 67 by evan@chromium.org, Aug 18, 2009
You can use the --glen flag to bring him back.
Comment 68 by sacred31.abhishek, Aug 20, 2009
I think it's a mischief.
Comment 69 by ezep.linux, Oct 06, 2009
Are you serious about --glen flag?

I mean, yes, it's a easter egg... but it's a quite weird and unpolite :).
Sign in to add a comment