| Issue 18385: | Head in place of close button | |
| 55 people starred this issue and may be notified of changes. | Back to list |
Sign in to add a comment
|
Chrome Version : 3.0.197.0 (22354) OS + version : Debian AMD64(Using 32-bit libs, inapplicable) CPU architecture (32-bit / 64-bit): x86_64 window manager : GNOME(gtk) URLs (if applicable) : All Behavior in Firefox 3.x (if applicable): X button Behavior in Chrome for Windows (optional): X button What steps will reproduce the problem? 1. Look at what the X button is supposed to be 2. 3. What is the expected result? an X button What happens instead? Some guys head Please provide any additional information below. Attach a screenshot and backtrace if possible. I think it's rather self-explanatory http://img262.imageshack.us/img262/7919/screenshot9.png I figure it's best to tell the developers who probably don't test **every** version. I suspect it was either a prank or a mistake. |
||||||||||||||||||
,
Aug 03, 2009
this is tragic
Status: Assigned
Owner: g...@chromium.org Cc: e...@chromium.org Labels: -Area-Misc Area-BrowserUI Pri-1 |
|||||||||||||||||||
,
Aug 03, 2009
Aw, I kinda like him peeking over like that... |
|||||||||||||||||||
,
Aug 04, 2009
Still there in 22373... |
|||||||||||||||||||
,
Aug 04, 2009
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=22391
------------------------------------------------------------------------
r22391 | evan@chromium.org | 2009-08-04 10:43:10 -0700 (Tue, 04 Aug 2009) | 5 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/app/resources/app_resources.grd?r1=22391&r2=22390
M http://src.chromium.org/viewvc/chrome/trunk/src/app/resources/linux_close.png?r1=22391&r2=22390
A http://src.chromium.org/viewvc/chrome/trunk/src/app/resources/linux_close_glen.png
A http://src.chromium.org/viewvc/chrome/trunk/src/app/resources/linux_close_h.png
A http://src.chromium.org/viewvc/chrome/trunk/src/app/resources/linux_close_mask.png
A http://src.chromium.org/viewvc/chrome/trunk/src/app/resources/linux_close_p.png
A http://src.chromium.org/viewvc/chrome/trunk/src/app/resources/linux_maximize.png
A http://src.chromium.org/viewvc/chrome/trunk/src/app/resources/linux_maximize_h.png
A http://src.chromium.org/viewvc/chrome/trunk/src/app/resources/linux_maximize_mask.png
A http://src.chromium.org/viewvc/chrome/trunk/src/app/resources/linux_maximize_p.png
A http://src.chromium.org/viewvc/chrome/trunk/src/app/resources/linux_minimize.png
A http://src.chromium.org/viewvc/chrome/trunk/src/app/resources/linux_minimize_h.png
A http://src.chromium.org/viewvc/chrome/trunk/src/app/resources/linux_minimize_mask.png
A http://src.chromium.org/viewvc/chrome/trunk/src/app/resources/linux_minimize_p.png
A http://src.chromium.org/viewvc/chrome/trunk/src/app/resources/linux_restore.png
A http://src.chromium.org/viewvc/chrome/trunk/src/app/resources/linux_restore_h.png
A http://src.chromium.org/viewvc/chrome/trunk/src/app/resources/linux_restore_p.png
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_titlebar.cc?r1=22391&r2=22390
linux: use linux-specific window control graphics from glen
BUG=15952,18385
Review URL: http://codereview.chromium.org/159859
------------------------------------------------------------------------
|
|||||||||||||||||||
,
Aug 04, 2009
(No comment was entered for this change.)
Status: Fixed
|
|||||||||||||||||||
,
Aug 04, 2009
Issue 18397 has been merged into this issue. |
|||||||||||||||||||
,
Aug 04, 2009
Issue 18421 has been merged into this issue. |
|||||||||||||||||||
,
Aug 05, 2009
just wondering what else can get in thru code reviews. you guys... ah, better not to say anything. such a nice application and now this. there should be more buzz about it to make less people using chromium, such a insecure bullshit, where everybody can commit whatever. today it's creepy face, tomorrow it will be malicious code, nice work. |
|||||||||||||||||||
,
Aug 05, 2009
Funniest bug ever. But I'm a bit newbie, what's the way to fix it without using GTK+ horrible theme? I want a X, no Glen's head. ...sorry, Glen. |
|||||||||||||||||||
,
Aug 05, 2009
@missingno770: Just right click and check [ ] Use system title bar in browser. |
|||||||||||||||||||
,
Aug 05, 2009
Oh come on, don't be so abusive. It's an alpha version, it's not even out yet. Possibly an easter egg gone wrong ;) |
|||||||||||||||||||
,
Aug 05, 2009
This is awesome, I love you google. |
|||||||||||||||||||
,
Aug 05, 2009
@dusan.maliarik, calm down. There's nothing malicious about what just happened here, it's simply just motivation for someone specific to get something done. It's fixed now, so clearly this passive-agressive behaiour got the message to the right places. ;) |
|||||||||||||||||||
,
Aug 05, 2009
Good to know we'll be able to theme almost all aspects of Chromium once its finished :) |
|||||||||||||||||||
,
Aug 05, 2009
@denis.zawada Thank you. Is that easy. I never realized how idiot I could be =P |
|||||||||||||||||||
,
Aug 05, 2009
hold up - that is a feature, not a bug. official mascot of chrome - some guys head. |
|||||||||||||||||||
,
Aug 05, 2009
I rather want an attractive female head than this melon head... |
|||||||||||||||||||
,
Aug 05, 2009
Thanks for a good laugh |
|||||||||||||||||||
,
Aug 05, 2009
Issue 18506 has been merged into this issue. |
|||||||||||||||||||
,
Aug 05, 2009
Issue 18469 has been merged into this issue. |
|||||||||||||||||||
,
Aug 05, 2009
I never realized a browser could be creepy |
|||||||||||||||||||
,
Aug 05, 2009
So who is this Glen person??? nice, although it should of been on the spy on the incognito mode, and on the incognito notice, it should of said watch out Glen is watching or something lol! So was this done in order to emphasize the unindented Restore Down button when pressed? |
|||||||||||||||||||
,
Aug 05, 2009
This was done as a passive-aggressive motivation to get someone to create the linux close/min/max/restore buttons, I believe. And the message got through, and the work was done. ;) |
|||||||||||||||||||
,
Aug 05, 2009
@drewshays nice! thanks for the report :) |
|||||||||||||||||||
,
Aug 05, 2009
(No comment was entered for this change.)
Owner: e...@chromium.org
Cc: -e...@chromium.org g...@chromium.org |
|||||||||||||||||||
,
Aug 05, 2009
P.S. Not to say that Glen is creepy, just that the last thing you would expect in a browser is someone watching you :) |
|||||||||||||||||||
,
Aug 05, 2009
@ ceryn: Actually, the FIRST thing I expect in a browser is that someone is watching me.... |
|||||||||||||||||||
,
Aug 05, 2009
TOASTY! |
|||||||||||||||||||
,
Aug 05, 2009
sweet |
|||||||||||||||||||
,
Aug 05, 2009
@dusan.maliarik: you can probably learn to be more appreciative go google!! "don't be evil" (tm) |
|||||||||||||||||||
,
Aug 05, 2009
Good for us it's just "some guys head"...:) |
|||||||||||||||||||
,
Aug 05, 2009
This would of been funny if it was Rick Astley's head |
|||||||||||||||||||
,
Aug 06, 2009
When you go incognito, it should give Glen a blindfold. |
|||||||||||||||||||
,
Aug 06, 2009
"would have" or "would've", not "would of". :) |
|||||||||||||||||||
,
Aug 06, 2009
@drewshays: c'mon, somebody has to make people panic ;) |
|||||||||||||||||||
,
Aug 06, 2009
Kilroy was there. |
|||||||||||||||||||
,
Aug 06, 2009
I got one too. It was in Ubuntu Jaunty, when I was using Chrome. |
|||||||||||||||||||
,
Aug 06, 2009
The changelog implies that the original /src/app/resources/linux_close.png file was just moved to /src/app/resources/linux_close_glen.png . Since this file is no longer referenced, isn't it just cruft in the codebase? It should be removed, even though it isn't included in the final binary (unless it is part of a useful test, in which case it should be renamed and moved to reflect this) |
|||||||||||||||||||
,
Aug 06, 2009
New buttons are the worst close\resotre buttons I've ever seen. How can I return old ones? |
|||||||||||||||||||
,
Aug 06, 2009
do you want the head back? |
|||||||||||||||||||
,
Aug 06, 2009
re 56: you might be seeing the spacing issues on the new buttons. We've fixed them to have proper spacing but that change did not get into the latest dev channel release, so you will have to live with the crappy spacing for ~1 week if you are on google- chrome (if you are using the ubuntu nightlies, you will only have to live with it for a day or so). |
|||||||||||||||||||
,
Aug 06, 2009
re 58: actually, mmoss set me straight -- we did make this dev channel. the official release should go straight from vista buttons to new-style buttons, no heads or other ugly bits in the interim. (hopefully QA would catch something like the glenhead.) |
|||||||||||||||||||
,
Aug 06, 2009
Reminds me of the "Toasty!" guy from mortal kombat. |
|||||||||||||||||||
,
Aug 06, 2009
Damn that's awesome! http://www.p4o.net |
|||||||||||||||||||
,
Aug 07, 2009
Issue 18756 has been merged into this issue. |
|||||||||||||||||||
,
Aug 08, 2009
Glen is a dead hacker and he's prying into your desktop. Be afraid. Be very afraid! |
|||||||||||||||||||
,
Aug 09, 2009
TOASTY [2] From Mega Drive... |
|||||||||||||||||||
,
Aug 10, 2009
I already miss Glen... |
|||||||||||||||||||
,
Aug 18, 2009
You can use the --glen flag to bring him back. |
|||||||||||||||||||
,
Aug 20, 2009
I think it's a mischief. |
|||||||||||||||||||
,
Oct 06, 2009
Are you serious about --glen flag? I mean, yes, it's a easter egg... but it's a quite weird and unpolite :). |
|||||||||||||||||||
|
|
|||||||||||||||||||