My favorites ▼ | Sign in
Logo
Project Home
  
Downloads
  
Wiki
  
Issues
    
New issue | Search
for
| Advanced search | Search tips
Issue 18203: Clicking on Flash plugins often doesn't work on the Mac
2 people starred this issue and may be notified of changes. Back to list
 
Reported by stuartmorgan@chromium.org, Jul 31, 2009 
What steps will reproduce the problem?
1. Go to YouTube
2. Try to pause/scrub the video

Left mouse button clicks sometimes register, but often don't (probably an 
activation issue). As a workaround for now, middle-clicking works 
substantially better than left-clicking.
Comment 1 by stuartmorgan@chromium.org, Jul 31, 2009 
Yep, this is entirely a fake-window-activation issue; if I interpose IsWindowHilited and 
lie, clicking works perfectly.
Comment 2 by stuartmorgan@chromium.org, Aug 07, 2009 
Fixed by revision 22799, http://codereview.chromium.org/164100
Status: Fixed
Comment 3 by bugdroid1@chromium.org, Aug 07, 2009 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=22799 

------------------------------------------------------------------------
r22799 | stuartmorgan@google.com | 2009-08-07 15:03:17 -0700 (Fri, 07 Aug 2009) | 10 lines
Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_carbon_interpose_mac.cc
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_process_host.cc?r1=22799&r2=22798
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=22799&r2=22798
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/plugin_carbon_interpose_constants_mac.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/plugin_carbon_interpose_constants_mac.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/plugin/plugin_main.cc?r1=22799&r2=22798
   A http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/plugins/fake_plugin_window_tracker_mac.cc
   A http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/plugins/fake_plugin_window_tracker_mac.h
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.mm?r1=22799&r2=22798
   M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/webkit.gyp?r1=22799&r2=22798

Set up a interposing library for Carbon calls made by plugins.

This gives us a library that's inserted into plugin process via DYLD_INSERT_LIBRARIES to intercept Carbon calls, and moves the window/process activation handling into that library (based on Carbon window activation/deactivation calls, rather than polling the front window). Over time we'll interpose more, but this gives us the foundation.

This fixes both the "window loses focus when loading a page with plugins" and "can't click on YouTube controls" bugs.

BUG=18203,18553
TEST=Clicking on Flash plugins should work much more reliably, opening a page with a plugin shouldn't cause the window to lose focus.

Review URL: http://codereview.chromium.org/164100
------------------------------------------------------------------------
Comment 4 by deep...@chromium.org, Aug 11, 2009 
ver:3.0.198.0
rev:22964
Status: Verified
Comment 5 by bugdroid1@chromium.org, Aug 11, 2009 
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=22936 

------------------------------------------------------------------------
r22936 | jon@chromium.org | 2009-08-10 12:19:56 -0700 (Mon, 10 Aug 2009) | 13 lines
Changed paths:
   A http://src.chromium.org/viewvc/chrome/branches/197/src/chrome/browser/plugin_carbon_interpose_mac.cc
   M http://src.chromium.org/viewvc/chrome/branches/197/src/chrome/browser/plugin_process_host.cc?r1=22936&r2=22935
   M http://src.chromium.org/viewvc/chrome/branches/197/src/chrome/chrome.gyp?r1=22936&r2=22935
   A http://src.chromium.org/viewvc/chrome/branches/197/src/chrome/common/plugin_carbon_interpose_constants_mac.cc
   A http://src.chromium.org/viewvc/chrome/branches/197/src/chrome/common/plugin_carbon_interpose_constants_mac.h
   M http://src.chromium.org/viewvc/chrome/branches/197/src/chrome/plugin/plugin_main.cc?r1=22936&r2=22935
   A http://src.chromium.org/viewvc/chrome/branches/197/src/webkit/glue/plugins/fake_plugin_window_tracker_mac.cc
   A http://src.chromium.org/viewvc/chrome/branches/197/src/webkit/glue/plugins/fake_plugin_window_tracker_mac.h
   M http://src.chromium.org/viewvc/chrome/branches/197/src/webkit/glue/plugins/webplugin_delegate_impl_mac.mm?r1=22936&r2=22935
   M http://src.chromium.org/viewvc/chrome/branches/197/src/webkit/webkit.gyp?r1=22936&r2=22935

Merge 22799 - Set up a interposing library for Carbon calls made by plugins.

This gives us a library that's inserted into plugin process via DYLD_INSERT_LIBRARIES to intercept Carbon calls, and moves the window/process activation handling into that library (based on Carbon window activation/deactivation calls, rather than polling the front window). Over time we'll interpose more, but this gives us the foundation.

This fixes both the "window loses focus when loading a page with plugins" and "can't click on YouTube controls" bugs.

BUG=18203,18553
TEST=Clicking on Flash plugins should work much more reliably, opening a page with a plugin shouldn't cause the window to lose focus.

Review URL: http://codereview.chromium.org/164100

TBR=stuartmorgan@google.com
Review URL: http://codereview.chromium.org/165250
------------------------------------------------------------------------
Comment 6 by stuartmorgan@chromium.org, Aug 12, 2009 
 Issue 18542  has been merged into this issue.
Cc: prog...@chromium.org
Comment 7 by mal.chromium, Dec 18, 2009 
(No comment was entered for this change.)
Labels: -Area-Plugins Area-Internals Internals-Plugins
► Sign in to add a comment

Powered by Google Project Hosting