| Issue 18107: | Add POST support for TemplateURLs | |
| 12 people starred this issue and may be notified of changes. | Back to list |
Sign in to add a comment
|
Some search engines (e.g. dir.bg) use POST instead of GET. Firefox supports search engines (or bookmark keywords, or both, I can't remember) doing POST, and we have support for it at the URLFetcher layer, so mostly we'd just need to add something to TemplateURLs. I don't know if the OpenSearch spec says something about this.
Dec 17, 2009
#1
or...@chromium.org
Labels:
-Area-BrowserBackend Area-Internals
Jan 28, 2010
(No comment was entered for this change.)
Labels:
HelpWanted
Feb 24, 2010
(No comment was entered for this change.)
Labels:
GoodFirstBug
Aug 4, 2010
There is the OpenSearch Parameter extension that adds support for POST requests: http://www.opensearch.org/Specifications/OpenSearch/Extensions/Parameter/1.0
Feb 14, 2011
(No comment was entered for this change.)
Labels:
-HelpWanted
Mar 18, 2011
Some search engines (e.g. dir.bg) use POST instead of GET. Firefox supports search engines (or bookmark keywords, or both, I can't remember) doing POST, and we have support for it at the URLFetcher layer, so mostly we'd just need to add something to TemplateURLs. I don't know if the OpenSearch spec says something about this.
Labels:
-GoodFirstBug bulkmove Hotlist-GoodFirstBug
Jun 9, 2011
I looked into this. The code to parse the parameter extension from OpenSearch and add it to TemplateURL is quite simple. The way this TemplateURL then gets passed down to be fetched is much more complicated, however. The NavigationEntry that needs to be created can store POST data, but it gets created with webkit tools which have no current FormData analogs in webkit/glue. Either faking it or creating those analogs is possible. There's also some messiness in passing the form data triggers from where the GURL is made from the TemplateURL down to the navigation controller that would have to be done. I have a patch for this which does the parsing and has a couple potential approaches to populating the NavigationEntry, but it looks like there'd need to be some refactoring to make this bug as straightforward as we first thought.
Cc:
brettw@chromium.org
Jul 25, 2011
Greg, can you post any useful partial work you've got somewhere? It looks like I'm going to be interested in seeing this happen.
Labels:
-Size-Medium -bulkmove -Hotlist-GoodFirstBug
Feb 16, 2012
(No comment was entered for this change.)
Blocking:
89945
Jul 12, 2012
(No comment was entered for this change.)
Blocking:
chromium:89945
Mar 10, 2013
(No comment was entered for this change.)
Labels:
-Area-Internals Cr-Internals
Blocking: -chromium:89945
Aug 29, 2013
The POST support has been added for TemplateURL. Close this bug as fixed.
Status:
Fixed
Owner: j...@chromium.org
Aug 29, 2013
And how would one use this?
Aug 29, 2013
This isn't fixed until the support actually works. See bug 268698. We also should support importing such search engines. That can probably be a separate bug.
Status:
Assigned
Blockedon: chromium:268698
Aug 29, 2013
Holy F*k, why do I have 390 search engines? I only use the ones (maybe a dozen) I added myself (Google, Wikipedia, etc). I takes ages to edit an entry in this huge list. |
||||||||
| ► Sign in to add a comment | |||||||||