My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 18078: Chrome keeps showing "Google Chrome did not shut down properly" message, when quitting via dock
10 people starred this issue and may be notified of changes. Back to list
Status:  Verified
Owner:  mark@chromium.org
Closed:  Sep 2009
Cc:  j...@chromium.org, pinkerton@chromium.org, jeremy@chromium.org, shess@chromium.org, mark@chromium.org, j...@chromium.org
M-4

Restricted
  • Only users with EditIssue permission may comment.


Sign in to add a comment
 
Reported by pbry...@googlemail.com, Jul 30, 2009
Chrome Version       : 3.0.195.1 
URLs (if applicable) :
OS version               : 10.5.7
Behavior in Safari 3.x/4.x (if applicable): N/A
Behavior in Firefox 3.x (if applicable): N/A
Behavior in Chrome for Windows: Quits cleanly without message

What steps will reproduce the problem?
1. I open Chrome, navigate to a web-site, then select quit by
right-clicking on Chrome's dock icon, and choosing Quit.

What is the expected result?
I don't expect a message saying "Chrome didn't shut down correctly".

What happens instead?
Chrome shows "Google Chrome didn't shut down correctly" message on next
startup, and will continue to do so if I quit via dock. To get rid of the
message, I have to close it, then select Quit from the menu-bar.

If I quit using the menu bar, I don't get the message. Also, I'm not sure
whether this error started when I removed Chrome using AppZapper, then
re-installed.
Aug 12, 2009
#1 j...@chromium.org
This happens to me almost everyday.  In my case I tend to log out of my account with 
Cmd-Shift-Q.  However that tells Chrome to shut down it apparently takes a code path 
that leave everything in a state that appears to have crashed.

This seems like it would be a pretty easy thing to fix.  I had not realized that you could 
also repro it by closing from the Dock.  I will try that.
Status: Available
Labels: -Area-Misc Area-BrowserBackend Mstone-MacBeta
Aug 12, 2009
#2 j...@chromium.org
Sure enough, it repros when you use Quit from the context menu of the Chrome icon in 
the dock.  
Aug 12, 2009
#3 j...@chromium.org
(No comment was entered for this change.)
Cc: j...@chromium.org
Aug 18, 2009
#4 p...@chromium.org
(No comment was entered for this change.)
Status: Started
Owner: p...@chromium.org
Aug 20, 2009
#5 p...@chromium.org
In discussing the possible solutions with Mike, we've decided to reduce the priority of 
this issue.
Cc: pinker...@chromium.org
Labels: -Pri-2 Pri-3
Aug 27, 2009
#6 pinkerton@chromium.org
 Issue 20443  has been merged into this issue.
Cc: jer...@chromium.org sh...@chromium.org
Sep 2, 2009
#7 j...@chromium.org
This blocks Mac Beta.
Labels: ReleaseBlock-Beta
Sep 2, 2009
#8 j...@chromium.org
(No comment was entered for this change.)
Labels: -Mstone-MacBeta Mstone-4
Sep 2, 2009
#9 j...@chromium.org
John wants to look at this to see if there is something new we can try.
Owner: j...@chromium.org
Sep 13, 2009
#10 mark@chromium.org
This is inflating the browser crash count in our stability data.  That's a real big deal.  I'm 
adjusting the priority and I'll take a look if jrg hasn't been able to.
Cc: m...@chromium.org
Labels: -Pri-3 Pri-1
Sep 14, 2009
#11 mark@chromium.org
My plan would be to fix this by subclassing NSApplication and overriding -terminate.  
From past experience, this is feasible.  Any thoughts?
Sep 14, 2009
#12 shess@chromium.org
http://crbug.com/14003 involves an OS bug with how it handles selecting windows from the dock menu (it 
points at window objects, if the window is closed while the dock menu is up you can still select it and crash us).  
AFAICT, there is no way to override those menu items, but we could intercept and fix at -[NSApplication 
sendAction:to:from:].  Which is hacky as sin, but also requires a custom NSApplication subclass to accomplish.
Sep 15, 2009
#13 mark@chromium.org
yoink
Owner: m...@chromium.org
Cc: j...@chromium.org
Sep 15, 2009
#15 mark@chromium.org
r26269
Status: Fixed
Sep 15, 2009
#16 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=26269 

------------------------------------------------------------------------
r26269 | mark@chromium.org | 2009-09-15 14:36:11 -0700 (Tue, 15 Sep 2009) | 18 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/app-Info.plist?r1=26269&r2=26268
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/MainMenu.xib?r1=26269&r2=26268
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/app_controller_mac.h?r1=26269&r2=26268
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/app_controller_mac.mm?r1=26269&r2=26268
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider_list_mac.mm?r1=26269&r2=26268
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_main.cc?r1=26269&r2=26268
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_main.h?r1=26269&r2=26268
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_main_gtk.cc?r1=26269&r2=26268
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_main_mac.mm?r1=26269&r2=26268
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_main_win.cc?r1=26269&r2=26268
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_application_mac.h
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chrome_application_mac.mm
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=26269&r2=26268

Chrome should shut down cleanly when quit from the Dock icon menu, during
user logout, and during system restart and shutdown.

MainMenu.xib changes (because you're not expected to parse nibs yourself):
 - The quit menu item's action is changed from the AppController object's
   -quit: method (which no longer exists) to the application object's
   -terminate: method (the Cocoa standard).
 - The application and owner object types are changed from NSApplication to
   CrApplication.
 - The application menu name is changed from Chromium to
   ^IDS_SHORT_PRODUCT_NAME.  Cocoa doesn't use this anyway, it gets replaced
   at runtime with the localized value of CFBundleName, but we shouldn't have
   branding-specific strings in our nibs.

BUG=18078
TEST=Use Chrome for a while, quit it from the Dock icon menu, and relaunch.
     You should NOT see the "Google Chrome didn't shut down correctly" info bar.
Review URL: http://codereview.chromium.org/201121
------------------------------------------------------------------------

Sep 16, 2009
#17 j...@chromium.org
Thanks for hitting this Mark.

Sep 21, 2009
#18 rohi...@chromium.org
212.0 (Developer Build 26685)
Status: Verified
Dec 18, 2009
#19 mal.chromium@gmail.com
(No comment was entered for this change.)
Labels: -Area-BrowserBackend Area-Internals
Oct 14, 2010
#20 bobkit...@gmail.com
This bug is happening NOW on today's current release when closed from the x in the upper right of the window. I am running Win7-current.
Oct 14, 2010
#21 shess@chromium.org
bobkitten, the Mac version of Chrome does not run on Win7, -current or otherwise.
Oct 11, 2012
#22 bugdro...@chromium.org
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Labels: Restrict-AddIssueComment-Commit
Mar 10, 2013
#23 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Mstone-4 -Area-Internals M-4 Cr-Internals
Mar 13, 2013
#24 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Sign in to add a comment

Powered by Google Project Hosting