My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 173205: Mac: DevTools overlaps bookmark bar and tabs
14 people starred this issue and may be notified of changes. Back to list
 
Reported by robert.c...@gmail.com, Jan 30, 2013
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_2) AppleWebKit/537.28 (KHTML, like Gecko) Chrome/26.0.1398.0 Safari/537.28

Steps to reproduce the problem:
1. Open Chrome Canary in Full Screen Presentation Mode
2. Open Dev Tools
3. Hover the top part of the screen to reveal tabs/menus

What is the expected behavior?
Dev Tools stays locked in Tab Area

What went wrong?
Dev Tools overlap browser Chrome.  Blocks access to Settings menu, unless you first close Dev Tools)

Did this work before? Yes Chrome Stable

Chrome version: 26.0.1398.0  Channel: canary
OS Version: OS X 10.8.2
stable.png
144 KB   View   Download
canary.png
158 KB   View   Download
Jan 30, 2013
#1 sail@chromium.org
This is due to r178392. Will fix.
Status: Assigned
Owner: sail@chromium.org
Feb 1, 2013
#2 sail@chromium.org
 Issue 173715  has been merged into this issue.
Feb 6, 2013
#3 sail@chromium.org
(No comment was entered for this change.)
Summary: Mac: DevTools overlaps bookmark bar and tabs (was: In Presentation Mode: DevTools overlaps tab chrome)
Feb 6, 2013
#4 sail@chromium.org
 Issue 174653  has been merged into this issue.
Feb 7, 2013
#6 sail@chromium.org
 Issue 174022  has been merged into this issue.
Cc: athi...@chromium.org vclarke@chromium.org sail@chromium.org
Feb 7, 2013
#7 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=181301

------------------------------------------------------------------------
r181301 | sail@chromium.org | 2013-02-07T14:09:55.470505Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/browser_window_controller.h?r1=181301&r2=181300&pathrev=181301
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/browser_window_controller.mm?r1=181301&r2=181300&pathrev=181301
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/dev_tools_controller.mm?r1=181301&r2=181300&pathrev=181301
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/devtools/devtools_window.h?r1=181301&r2=181300&pathrev=181301
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm?r1=181301&r2=181300&pathrev=181301
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests.gypi?r1=181301&r2=181300&pathrev=181301

Alternate NTP: Don't overlap dev tools with bookmark bar

When docked vertically the dev tools view overlaps the bookmark bar.

This was a bug I introduced in r178367 when I changed the bookmark bar to overlap web contents.

To fix this I've made the following changes:
  - implement constrainSplitPosition: to prevent the splitter from being dragged past the bookmark bar
  - move the dev tools view into a container view. The container view resizes the dev tools view to be below the bookmark bar

BUG=173205
TEST=Open dev tools and verified that it never went under the bookmark bar.


Review URL: https://chromiumcodereview.appspot.com/12208060
------------------------------------------------------------------------
Feb 7, 2013
#8 sail@chromium.org
(No comment was entered for this change.)
Status: Fixed
Feb 7, 2013
#9 robert.c...@gmail.com
Thanks!

On Thursday, February 7, 2013, wrote:
Feb 8, 2013
#10 meh...@chromium.org
 Issue 175117  has been merged into this issue.
Feb 8, 2013
#11 meh...@chromium.org
Hey Sail,

here is still something going wrong in 26.0.1407.0 (Official Build 181436) canary.

Now, the DevTools' Toolbar is under the bookmarksbar in a special case.

Here are the steps to reproduce (tested on 10.6.8.):

1.) go to google.com
2.) open DevTools (it is attached at th bottom)
3.) drag it to the right side
4.) close the DevTools
5.) open DevTools again

--> Result: please see the screenshot



devtools.png
102 KB   View   Download
Feb 8, 2013
#12 sail@chromium.org
Will fix. Thanks.
Status: Assigned
Feb 8, 2013
#13 sail@chromium.org
 Issue 175213  has been merged into this issue.
Feb 9, 2013
#14 meh...@chromium.org
 Issue 175290  has been merged into this issue.
Feb 11, 2013
#16 sail@chromium.org
(No comment was entered for this change.)
Status: Fixed
Feb 12, 2013
#17 meh...@chromium.org
 Issue 175700  has been merged into this issue.
Feb 12, 2013
#18 sail@chromium.org
Re-opening. My fix didn't make the M26 branch cut.
Once I verify on Canary I'll ask for merge approval.
Status: Assigned
Feb 12, 2013
#19 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=181867

------------------------------------------------------------------------
r181867 | sail@chromium.org | 2013-02-12T05:15:40.058227Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/dev_tools_controller.mm?r1=181867&r2=181866&pathrev=181867
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm?r1=181867&r2=181866&pathrev=181867

Alternate NTP: Fix dev tools layout

When docked to the right the dev tool's web view would be cropped.

This bug was due to the way I implemented view layout in r181301.

The dev tool view was being correctly layed out but the subview was not.

To fix this I've removed the container view (DevToolsContainerView). The new code just use the view's auto layout instead.

BUG=173205
TEST=Docked the devtools to the right and opened a new browser window. Verified that the devtools view was correctly layed out.

Review URL: https://codereview.chromium.org/12226086
------------------------------------------------------------------------
Feb 13, 2013
#20 sail@chromium.org
Verified that the fix works in 26.0.1411.0 canary. Merged requested.
Labels: Merge-Requested Mstone-26
Feb 13, 2013
#21 meh...@chromium.org
Hi Sail. Before merging, I noticed there is still an issue, when unhiding the bookmarks bar (Version 26.0.1411.0 canary / OSX 10.8.2). Please see the screenshot.

Steps to reproduce:

1.) Visit a page with visible Bookmarksbar
2.) Open DevTools
3.) drag to the right side
4.) Unhide the Bookmarksbar

-> Result: Please see the screenshot.


Thanks
Mehmet
Bildschirmfoto 2013-02-13 um 19.25.26.png
38.6 KB   View   Download
Feb 13, 2013
#22 akshayau...@gmail.com
Yes, issue is still there. Can't see tabs in DevTools when docked to right with bookmark bar.
Feb 13, 2013
#23 sail@chromium.org
mehmet: good catch, will fix.

akshayaurora2008: The issue in comment 21 only happens when you hide/show the bookmark bar while dev tools is open. Make sure you're using today's Canary (26.0.1411.0)
Labels: -Merge-Requested
Feb 13, 2013
#24 meh...@chromium.org
sail: One more thing :-)

When you do the following steps, then the overlap is also still there...

1.) Drag Devtools to the right.
2.) Close DevTools
3.) hide Bookmarksbar
4.) open DevTools (it is attached to the right)
5.) unhide Bookmarksbar


Bildschirmfoto 2013-02-13 um 19.41.28.png
31.6 KB   View   Download
Feb 13, 2013
#25 meh...@chromium.org
 Issue 176073  has been merged into this issue.
Feb 14, 2013
#26 pfeld...@chromium.org
 Issue 176245  has been merged into this issue.
Cc: dp...@chromium.org rana...@chromium.org Sriharir...@chromium.org mangalam...@chromium.org jayakris...@chromium.org
Feb 14, 2013
#27 pfeld...@chromium.org
@sail: The issue is still nowhere fixed, are you working on it?
Feb 14, 2013
#28 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=182499

------------------------------------------------------------------------
r182499 | sail@chromium.org | 2013-02-14T18:26:33.465144Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/dev_tools_controller.mm?r1=182499&r2=182498&pathrev=182499
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm?r1=182499&r2=182498&pathrev=182499

Alternate NTP: Resize devtools when hiding bookmark bar

Hiding the bookmark bar didn't update the devtools height. Fix was to update the frame when setTopContentOffset: was called.

BUG=173205

Review URL: https://codereview.chromium.org/12254021
------------------------------------------------------------------------
Feb 15, 2013
#29 jryans@chromium.org
(No comment was entered for this change.)
Cc: jryans@chromium.org
Feb 15, 2013
#30 meh...@chromium.org
This looks good now in Version 27.0.1413.0 canary (OSX 10.8.2). Can't reproduce it with the steps from comment 21 & 24.
Feb 15, 2013
#31 sail@chromium.org
(No comment was entered for this change.)
Labels: Merge-Requested
Feb 15, 2013
#32 dhar...@chromium.org
(No comment was entered for this change.)
Labels: -Merge-Requested Merge-Approved
Feb 15, 2013
#33 sail@chromium.org
(No comment was entered for this change.)
Labels: -Merge-Approved Merge-Merged
Feb 15, 2013
#34 sail@chromium.org
(No comment was entered for this change.)
Status: Fixed
Feb 15, 2013
#35 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=182776

------------------------------------------------------------------------
r182776 | sail@chromium.org | 2013-02-15T19:12:12.966066Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/cocoa/dev_tools_controller.mm?r1=182776&r2=182775&pathrev=182776
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm?r1=182776&r2=182775&pathrev=182776

Merge 181867
> Alternate NTP: Fix dev tools layout
> 
> When docked to the right the dev tool's web view would be cropped.
> 
> This bug was due to the way I implemented view layout in r181301.
> 
> The dev tool view was being correctly layed out but the subview was not.
> 
> To fix this I've removed the container view (DevToolsContainerView). The new code just use the view's auto layout instead.
> 
> BUG=173205
> TEST=Docked the devtools to the right and opened a new browser window. Verified that the devtools view was correctly layed out.
> 
> Review URL: https://codereview.chromium.org/12226086

TBR=sail@chromium.org
Review URL: https://codereview.chromium.org/12288006
------------------------------------------------------------------------
Labels: merge-merged-1410
Feb 15, 2013
#36 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=182777

------------------------------------------------------------------------
r182777 | sail@chromium.org | 2013-02-15T19:13:07.398861Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/cocoa/dev_tools_controller.mm?r1=182777&r2=182776&pathrev=182777
   M http://src.chromium.org/viewvc/chrome/branches/1410/src/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm?r1=182777&r2=182776&pathrev=182777

Merge 182499
> Alternate NTP: Resize devtools when hiding bookmark bar
> 
> Hiding the bookmark bar didn't update the devtools height. Fix was to update the frame when setTopContentOffset: was called.
> 
> BUG=173205
> 
> Review URL: https://codereview.chromium.org/12254021

TBR=sail@chromium.org
Review URL: https://codereview.chromium.org/12285005
------------------------------------------------------------------------
Feb 15, 2013
#37 mbo...@chromium.org
OS: Mac 10.8.2
Chrome:  27.0.1413.0 (Official Build 182629) canary

Able to reproduce DevTools overlaps bookmark bar and tabs when following Steps to Reproduce. See attachement 1. 

Unable to reproduce the issues mentioned in Comment 21 & 24.
Screen Shot 2013-02-15 at 11.39.55 AM.png
199 KB   View   Download
Screen Shot 2013-02-15 at 11.24.23 AM.png
214 KB   View   Download
Feb 15, 2013
#38 mbo...@chromium.org
(No comment was entered for this change.)
Cc: mbo...@chromium.org
Feb 15, 2013
#39 meh...@chromium.org
Hi mbollu@.

What are the steps to reproduce the issue from screenshot 1 ?

Thanks in advance.
Feb 15, 2013
#40 meh...@chromium.org
Ah, I see. This happen in Presentation Mode SHIFT-CMD-F.

Sail, should I file a seperate report for this ?
Feb 15, 2013
#41 sail@chromium.org
Hi mehmet, yea could you file a new bug? Thanks!
Feb 15, 2013
#42 meh...@chromium.org
sail: I filed  issue 176585 .
Feb 19, 2013
#43 ashej...@chromium.org
Retested the above issue as per comment 21 & 24 with Canary version "27.0.1416.0" on MAC 10.8.2 and Bookmark bar is not getting overlapped for "Normal mode".
As per comment #42 separate issue has been filed for "Presentation Mode" . Hence marking this issue as "Verified".
Status: Verified
Cc: ashej...@chromium.org
Labels: TE-Verified-27.0.1416.0
Mar 10, 2013
#44 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Area-UI -Mstone-26 M-26 Cr-UI
Sign in to add a comment

Powered by Google Project Hosting