My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 16915: GTK Theme:Star/Go button/entry area don't match GTK+
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  erg@chromium.org
Closed:  Jul 2009

Restricted
  • Only users with Commit permission may comment.


Sign in to add a comment
 
Project Member Reported by michael....@gmail.com, Jul 16, 2009
Chrome Version : 3.0.195.0 (Developer Build 20863)
OS + version : Linux

What steps will reproduce the problem?
1. set chrome to use GTK+ theme

To further test this, got make sure you have some backward history but no 
forward history. The "Next" button will be display grayed out = disabled. 
Now compare this to the Star button and the URL entry: those look even more 
grayed out. Same for the "go to" button and also the page/wrench buttons.

IMHO at least the Star and Goto buttons need to better match the 
active/disabled border colors of the GTK theme. Fill color could also be 
mimicked better but that's not the biggest problem.

Also, drawing the Star/Goto/Page/Wrench "glyphs" with a grayed out look 
makes it very hard to guess the state of the buttons. IMHO there are two 
possible solutions: 
a) use proper (colored) icons, if possible themed ones
or 
b) draw the glyphs in a known-to-be readable color (e.g. GTK theme's text 
color).
1.png
5.2 KB   View   Download
2.png
1.8 KB   View   Download
Jul 16, 2009
#1 est...@chromium.org
there is already a patch for this under review, written by eglaysher
Status: Assigned
Owner: e...@chromium.org
Jul 16, 2009
#2 erg@chromium.org
(No comment was entered for this change.)
Summary: GTK Theme:Star/Go button/entry area don't match GTK+
Jul 16, 2009
#3 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=20914 

------------------------------------------------------------------------
r20914 | erg@google.com | 2009-07-16 16:09:39 -0700 (Thu, 16 Jul 2009) | 14 lines
Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/star_noborder.png
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/starred_noborder.png
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources.grd?r1=20914&r2=20913
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_theme_provider.cc?r1=20914&r2=20913
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc?r1=20914&r2=20913
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h?r1=20914&r2=20913
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/go_button_gtk.cc?r1=20914&r2=20913
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/go_button_gtk.h?r1=20914&r2=20913
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc?r1=20914&r2=20913
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.cc?r1=20914&r2=20913
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/toolbar_star_toggle_gtk.h?r1=20914&r2=20913

GTK Themes: Make the location bar area look native.

Replace the star and go buttons with a native looking thing, where
we manually draw the theme's button image for the full omnibox area
and then position the star/go buttons on top of that.

Also adds stand in versions of star_noborder and starred_noborder
until Glen can make real icons.

http://crbug.com/16227
http://crbug.com/13967
http://crbug.com/16915

Review URL: http://codereview.chromium.org/149681
------------------------------------------------------------------------

Jul 16, 2009
#4 erg@chromium.org
(No comment was entered for this change.)
Status: Fixed
Jul 17, 2009
#5 michael....@gmail.com
Happy to see the original problem of this issue is indeed fixed. However the 
implementation is highly problematic, it seems to break on most (all?) themes with 
rounded buttons... see screenshot.
Screenshot.png
9.8 KB   View   Download
Oct 11, 2012
#6 bugdro...@chromium.org
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Labels: Restrict-AddIssueComment-Commit
Sign in to add a comment

Powered by Google Project Hosting