| Issue 16759: | Port ExtensionBrowserTest.Shelf to Linux | |
| 6 people starred this issue and may be notified of changes. | Back to list |
Sign in to add a comment
|
Add extension shelf for GTK. |
||||||||||||||||||||||||
,
Jul 20, 2009
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=21014
------------------------------------------------------------------------
r21014 | phajdan.jr@chromium.org | 2009-07-17 15:18:50 -0700 (Fri, 17 Jul 2009) | 8 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.cc?r1=21014&r2=21013
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_window_gtk.cc?r1=21014&r2=21013
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_window_gtk.h?r1=21014&r2=21013
A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/extension_shelf_gtk.cc
A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/extension_shelf_gtk.h
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=21014&r2=21013
Begin work on extension shelf for Linux.
For now it displays only a placeholder text, but knows when to display (it's connected to the ExtensionShelfModel).
TEST=none
http://crbug.com/16759
Review URL: http://codereview.chromium.org/159019
------------------------------------------------------------------------
|
|||||||||||||||||||||||||
,
Jul 22, 2009
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=21350
------------------------------------------------------------------------
r21350 | phajdan.jr@chromium.org | 2009-07-22 17:12:10 -0700 (Wed, 22 Jul 2009) | 6 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/extension_shelf_gtk.cc?r1=21350&r2=21349
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/extension_shelf_gtk.h?r1=21350&r2=21349
Populate the Linux extension shelf with placeholder labels containing each extension's name.
TEST=none
http://crbug.com/16759
Review URL: http://codereview.chromium.org/155957
------------------------------------------------------------------------
|
|||||||||||||||||||||||||
,
Jul 28, 2009
Issue 16869 has been merged into this issue. |
|||||||||||||||||||||||||
,
Jul 28, 2009
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=21908
------------------------------------------------------------------------
r21908 | phajdan.jr@chromium.org | 2009-07-28 15:45:58 -0700 (Tue, 28 Jul 2009) | 10 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.cc?r1=21908&r2=21907
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.h?r1=21908&r2=21907
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/extension_shelf_gtk.cc?r1=21908&r2=21907
A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/extension_view_gtk.cc
A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/extension_view_gtk.h
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=21908&r2=21907
Create render view for extensions on Linux.
Now when an extension is loaded, you will see its entry in the task manager.
However, on the shelf there is still only a placeholder label (I have to
work on setting proper size for the render widget).
TEST=none
http://crbug.com/16759
Review URL: http://codereview.chromium.org/159527
------------------------------------------------------------------------
|
|||||||||||||||||||||||||
,
Aug 04, 2009
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=22439
------------------------------------------------------------------------
r22439 | phajdan.jr@chromium.org | 2009-08-04 16:24:01 -0700 (Tue, 04 Aug 2009) | 7 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.cc?r1=22439&r2=22438
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/extension_shelf_gtk.cc?r1=22439&r2=22438
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/extension_view_gtk.cc?r1=22439&r2=22438
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/extension_view_gtk.h?r1=22439&r2=22438
Make extensions in the extension shelf render their content to a visible GTK
widget.
TEST=none
http://crbug.com/16759
Review URL: http://codereview.chromium.org/160610
------------------------------------------------------------------------
|
|||||||||||||||||||||||||
,
Aug 06, 2009
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=22672
------------------------------------------------------------------------
r22672 | phajdan.jr@chromium.org | 2009-08-06 14:34:11 -0700 (Thu, 06 Aug 2009) | 8 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_host.cc?r1=22672&r2=22671
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/extension_shelf_gtk.cc?r1=22672&r2=22671
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/extension_view_gtk.cc?r1=22672&r2=22671
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/extension_view_gtk.h?r1=22672&r2=22671
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/extensions/extension_view.cc?r1=22672&r2=22671
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/extensions/extension_view.h?r1=22672&r2=22671
Correctly handle extensions width in the GTK extension shelf.
Also make the method name used on Windows shorter and more obvious.
TEST=none
http://crbug.com/16759
Review URL: http://codereview.chromium.org/164092
------------------------------------------------------------------------
|
|||||||||||||||||||||||||
,
Aug 26, 2009
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=24539
------------------------------------------------------------------------
r24539 | phajdan.jr@chromium.org | 2009-08-26 14:55:34 -0700 (Wed, 26 Aug 2009) | 6 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/extension_shelf_gtk.cc?r1=24539&r2=24538
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/extension_shelf_gtk.h?r1=24539&r2=24538
Polish the look of Linux extension shelf.
TEST=none
http://crbug.com/16759
Review URL: http://codereview.chromium.org/174564
------------------------------------------------------------------------
|
|||||||||||||||||||||||||
,
Aug 27, 2009
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=24605
------------------------------------------------------------------------
r24605 | phajdan.jr@chromium.org | 2009-08-27 08:06:03 -0700 (Thu, 27 Aug 2009) | 8 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/extension_shelf_gtk.cc?r1=24605&r2=24604
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/extension_shelf_gtk.h?r1=24605&r2=24604
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/extension_view_gtk.cc?r1=24605&r2=24604
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/extension_view_gtk.h?r1=24605&r2=24604
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc?r1=24605&r2=24604
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h?r1=24605&r2=24604
Draw background of Linux extension toolstrips.
This makes Linux extension shelf quite pretty now IMHO.
TEST=Just see it.
http://crbug.com/16759
Review URL: http://codereview.chromium.org/174585
------------------------------------------------------------------------
|
|||||||||||||||||||||||||
,
Aug 27, 2009
I wish I can see it...but I get segmentation faults http://crbug.com/19890 |
|||||||||||||||||||||||||
,
Aug 28, 2009
no more crash on loading...shelf looks good, but any plans to support themes? |
|||||||||||||||||||||||||
,
Sep 01, 2009
I think that basic shelf support is done, so marking Fixed. About themes, and possibly other things - I don't know now, will ask UI and Linux people. Themes would make sense to me though.
Status: Fixed
|
|||||||||||||||||||||||||
,
Sep 01, 2009
Can you also get the ExtensionBrowserTest.Shelf working on linux as part of closing this bug? |
|||||||||||||||||||||||||
,
Sep 01, 2009
Ok, re-opening. Will do.
Status: Assigned
|
|||||||||||||||||||||||||
,
Sep 09, 2009
(No comment was entered for this change.)
Labels: -Size-Medium Size-Large Mstone-4 Channel-Dev
|
|||||||||||||||||||||||||
,
Sep 24, 2009
It appears that the shelf is getting the default text color from the desktop theme (when the theme is set to the GTK+ theme, at least). In that case, wouldn't it make sense to get the background color from GTK too? As it is, the shelf doesn't match the rest of the UI when it is set to the GTK theme, and it can be hard to read the text in the shelf when it is set to a bright color. |
|||||||||||||||||||||||||
,
Sep 24, 2009
benjo316: that's a great bug report. can you file it separately so it isn't lost? |
|||||||||||||||||||||||||
,
Sep 24, 2009
(No comment was entered for this change.)
Summary: Port ExtensionBrowserTest.Shelf to Linux
|
|||||||||||||||||||||||||
,
Sep 25, 2009
evan: filed as http://crbug.com/23031 I'm not really good with summaries, so change it if you feel it's necessary. |
|||||||||||||||||||||||||
,
Oct 12, 2009
The extensions team has decided that we like browser actions (code.google.com/p/chromium/w/edit/BrowserActions) better than toolstrips, and will be removing toolstrips before the beta. So please don't do any more work on toolstrips.
Status: WontFix
|
|||||||||||||||||||||||||
,
Mar 03 (6 days ago)
(No comment was entered for this change.)
Labels: Feature-Extensions
|
|||||||||||||||||||||||||
| ► Sign in to add a comment | |||||||||||||||||||||||||