My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 16657: Ensure FFmpeg binaries end up in snapshots on all platforms
2 people starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  scherkus@chromium.org
Closed:  Jul 2009

Restricted
  • Only users with Commit permission may comment.


Sign in to add a comment
 
Project Member Reported by ajw...@chromium.org, Jul 13, 2009
Currently, the daily snapshots are not always including the ffmpeg binaries 
required to enable the audio/video tags.

This needs to be fixed.

This is a continuous of bug:
  https://code.google.com/p/chromium/issues/detail?id=15906
Jul 13, 2009
#1 scherkus@chromium.org
CL out for review

http://codereview.chromium.org/149571
Status: Started
Owner: scher...@chromium.org
Jul 13, 2009
#2 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=20548 

------------------------------------------------------------------------
r20548 | mmoss@chromium.org | 2009-07-13 14:47:29 -0700 (Mon, 13 Jul 2009) | 6 lines
Changed paths:
   D /trunk/src/third_party/ffmpeg/copy_binaries.sh
   M http://src.chromium.org/viewvc/chrome/trunk/src/third_party/ffmpeg/ffmpeg.gyp?r1=20548&r2=20547

Rewrite ffmpeg_binaries target to use GYP built-ins and branding conditions.

BUG=16657

Review URL: http://codereview.chromium.org/149554

------------------------------------------------------------------------

Jul 13, 2009
#3 bugdroid1@gmail.com
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=20583 

------------------------------------------------------------------------
r20583 | scherkus@chromium.org | 2009-07-13 17:02:36 -0700 (Mon, 13 Jul 2009) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/tools/build/linux/FILES?r1=20583&r2=20582
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/tools/build/linux/FILES.official?r1=20583&r2=20582
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/tools/build/win/FILES?r1=20583&r2=20582

Adding Ogg/Theora/Vorbis-only FFmpeg binaries to Chromium nightly builds.

BUG=16657
TEST=nightly builds of Chromium should include avutil-50.dll, avformat-52.dll, avcodec-52.dll and pthreadGC2.dll

Review URL: http://codereview.chromium.org/149571
------------------------------------------------------------------------

Jul 13, 2009
#4 scherkus@chromium.org
I was told there was little way of testing this change, so let's see if snapshots of 
r20583 or greater contain the DLLs!
Jul 13, 2009
#5 scherkus@chromium.org
http://build.chromium.org/buildbot/snapshots/chromium-rel-linux/20583/

contains the linux chromium libraries, will test shortly

still waiting on the windows build
Jul 13, 2009
#6 scherkus@chromium.org
Confirmed working on Linux using the following command:
cd /path/to/chrome-linux
LD_LIBRARY_PATH=. ./chrome
Jul 14, 2009
#7 scherkus@chromium.org
Confirmed working on Windows latest snapshots.
Jul 14, 2009
#8 scherkus@chromium.org
The binaries are packaged with Mac snapshots, however <video> is still disabled.

Closing this bug and will open a separate one for enabling the Mac snapshots.
Status: Fixed
Oct 11, 2012
#9 bugdro...@chromium.org
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Labels: Restrict-AddIssueComment-Commit
Sign in to add a comment

Powered by Google Project Hosting