Actually the whole test is flaky. Another example:

[----------] 1 test from FindInPageControllerTest
[ RUN      ] FindInPageControllerTest.FindMovesWhenObscuring
C:\b\slave\chromium-dbg-
builder\build\src\chrome\browser\views\find_bar_win_browsertest.cc(522): error: 
Expected: (start_position.x()) != (position.x()), actual: 643 vs 643
[  FAILED  ] FindInPageControllerTest.FindMovesWhenObscuring (3779 ms)
[----------] 1 test from FindInPageControllerTest (3779 ms total)

  // Search for 'dream' which the Find box is obscuring.
  int ordinal = 0;
  EXPECT_EQ(1, FindInPage(L"dream", FWD, IGNORE_CASE, &ordinal));
  EXPECT_EQ(1, ordinal);

  // Make sure Find box has moved.
  GetFindBarWindowInfo(&position, &fully_visible);
  EXPECT_EQ(start_position.y(), position.y());
  EXPECT_NE(start_position.x(), position.x());  // Fails here.
  EXPECT_TRUE(fully_visible);

(No comment was entered for this change.)

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=22322 

------------------------------------------------------------------------
r22322 | phajdan.jr@chromium.org | 2009-08-03 14:57:30 -0700 (Mon, 03 Aug 2009) | 6 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/find_bar_win_browsertest.cc?r1=22322&r2=22321

Disable flaky parts of FindInPageControllerTest.

TEST=none
http://crbug.com/16447

Review URL: http://codereview.chromium.org/159805
------------------------------------------------------------------------

(No comment was entered for this change.)

Finnur, could you take a look at this? Recently the priority has been bumped to P1, and I 
don't have free cycles for that.

(No comment was entered for this change.)

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=31325 

------------------------------------------------------------------------
r31325 | finnur@chromium.org | 2009-11-06 15:41:11 -0800 (Fri, 06 Nov 2009) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/find_bar_host_browsertest.cc?r1=31325&r2=31324

Adding traces to a test when it fails in the hope of at
least ruling some things out. These traces will be 
either be removed (once I get more data).

TBR=jcampan
BUG=16447
TEST=This is changing a test

Review URL: http://codereview.chromium.org/373019
------------------------------------------------------------------------

Hey Phajdan,

The flakiness dashboard lists the test that I just modified, but not the other test 
you marked flaky (FindInPageControllerTest.FLAKY_FindDisappearOnNavigate).

You limit the number shown on the dashboard to what... 25 or so? Does it have 
additional data that you are not showing or is that discarded?

In other words, I'd like to look at the logs for the failures, but don't want to sort 
through the build logs for a failure that last happened a week ago or something. Is 
that easily available somewhere?

Yes, the flakiness dashboard is limited to 25 entries. I can tweak it a little to display 
more flaky tests (because people need this info to see if the flakiness has been 
fixed), and the same number of flaky groups (just to limit the noise).

For now, I grepped the dashboard logs manually, and the only failure looks like this:

C:\b\slave\chromium-rel-
builder\build\src\chrome\browser\views\find_bar_host_browsertest.cc(528): error: 
Expected: (start_position.x()) != (position.x()), actual: 686 vs 686

Failed this way 9 time(s). First failure was on 2009-10-26, and last on 2009-11-04.

It's FindInPageControllerTest.FindMovesWhenObscuring I think (the line numbers 
seem to have shifted a little).

So, I think you can safely mark FindDisappearOnNavigate as not flaky (as well as 
other tests in this group). It had no flaky flips in the last 3 weeks. It's still possible 
that the test was just lucky, but then the flakiness in it is tiny.

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=31399 

------------------------------------------------------------------------
r31399 | finnur@chromium.org | 2009-11-07 19:08:17 -0800 (Sat, 07 Nov 2009) | 10 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/find_bar_host_browsertest.cc?r1=31399&r2=31398

Remove flaky label for FindInPageControllerTest.FindDisappearOnNavigate

When I started looking into the test flakiness, it
turns out it hasn't failed in 3 weeks, according to
Phajdan's logs, so I am removing the Flaky label.

BUG=16447
TEST=This is a test change.

Review URL: http://codereview.chromium.org/371054
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=31446 

------------------------------------------------------------------------
r31446 | finnur@chromium.org | 2009-11-09 10:15:52 -0800 (Mon, 09 Nov 2009) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/find_bar_host_browsertest.cc?r1=31446&r2=31445

Try one other thing temporarily to try to determine cause for a flaky test.

TBR=jcampan
BUG=16447
TEST=This is changing a test

Review URL: http://codereview.chromium.org/376024
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=31325 

------------------------------------------------------------------------
r31325 | finnur@chromium.org | 2009-11-06 15:41:11 -0800 (Fri, 06 Nov 2009) | 9 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/find_bar_host_browsertest.cc?r1=31325&r2=31324

Adding traces to a test when it fails in the hope of at
least ruling some things out. These traces will be 
either be removed (once I get more data).

TBR=jcampan
BUG=16447
TEST=This is changing a test

Review URL: http://codereview.chromium.org/373019
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=31399 

------------------------------------------------------------------------
r31399 | finnur@chromium.org | 2009-11-07 19:08:17 -0800 (Sat, 07 Nov 2009) | 10 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/find_bar_host_browsertest.cc?r1=31399&r2=31398

Remove flaky label for FindInPageControllerTest.FindDisappearOnNavigate

When I started looking into the test flakiness, it
turns out it hasn't failed in 3 weeks, according to
Phajdan's logs, so I am removing the Flaky label.

BUG=16447
TEST=This is a test change.

Review URL: http://codereview.chromium.org/371054
------------------------------------------------------------------------

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=31446 

------------------------------------------------------------------------
r31446 | finnur@chromium.org | 2009-11-09 10:15:52 -0800 (Mon, 09 Nov 2009) | 7 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/find_bar_host_browsertest.cc?r1=31446&r2=31445

Try one other thing temporarily to try to determine cause for a flaky test.

TBR=jcampan
BUG=16447
TEST=This is changing a test

Review URL: http://codereview.chromium.org/376024
------------------------------------------------------------------------

I see a lot of changes, but it's not clear what the status is now. It looks like the 
Flaky label has been removed... but then Jay has a change after that.

Is this still a flaky test?

This bug was tracking two flaky tests. One has been marked as not flaky. The other I 
added debugging info to. That issue is still open and the traces have ruled out some 
things, but not pinpointed the problem. I was in process of adding more traces (it 
takes a couple of days to get the results each time I make a change because it doesn't 
fail that often) and then I got pulled into something else...

(No comment was entered for this change.)