My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 159902: Print preview is not working in Windows 8 mode of chrome
11 people starred this issue and may be notified of changes. Back to list
 
Project Member Reported by pbommana@chromium.org, Nov 7, 2012
Version: 24.0.1312.5
OS: Win8

What steps will reproduce the problem?
1. Install Chrome and launch in windows 8 mode 
2. Open any webpage and try to do an print preview


What is the expected output?
Print preview of the page should be shown

What do you see instead?
Unable to see the print preview and saw the message "Google Chrome Cannot show the print preview when the built-in PDF viewer is missing". 
Is this the expected behavior are we suppose to show the Infobar to relaunch for print preview.





Nov 7, 2012
#1 gideonw...@chromium.org
Hummm. MAD, what's up with this one, since you worked on printing in Metro?
Cc: mad@chromium.org
Nov 7, 2012
#2 mad@chromium.org
Yeah, I didn't think about that... We would need to redirect the user to OS print dialog which opens the charm and show the (ugly) preview there...
Nov 7, 2012
#3 gideonw...@chromium.org
Ah, I see. How bad is this bug? How can a user trigger a print preview?

Aren't we supposed to have Pepper PDF viewer bundled with Metro Chrome?
Nov 8, 2012
#4 ydol...@chromium.org
Vitaly, could you repro?
Status: Unconfirmed
Owner: vitalyb...@chromium.org
Nov 8, 2012
#5 pbommana@chromium.org
(No comment was entered for this change.)
Labels: ReleaseBlock-Stable
Nov 8, 2012
#6 vitalyb...@chromium.org
pbommana@ Can you clarify what is "Install Chrome and launch in windows 8 mode"?
Nov 9, 2012
#7 msrchan...@chromium.org
(No comment was entered for this change.)
Cc: pbommana@chromium.org
Nov 9, 2012
#8 mad@chromium.org
I thought he meant running Chrome in Metro mode, but I couldn't reproduce it there, I thought I blocked all the access to print preview from metro... Maybe I missed an entry point?
Nov 9, 2012
#9 pbommana@chromium.org
Windows 8 mode aka Metro mode of chrome.
Nov 9, 2012
#10 gideonw...@chromium.org
Prudhvi, how did you invoke print preview in Metro mode?
Nov 9, 2012
#11 pbommana@chromium.org
Through keyboard shortcut "Ctrl+P"
Nov 9, 2012
#12 vitalyb...@chromium.org
pbommana@ How to run Chrome in metro mode? I see only desktop Chrome if I use normal installer.
Nov 9, 2012
#13 gideonw...@chromium.org
vit, make Chrome your default browser on Windows 8 and then choose Relaunch Chrome in Windows 8 mode from the Chrome menu.
Nov 9, 2012
#14 pbommana@chromium.org
Navigate to Wrench--> Relaunch Chrome in Windows 8 mode(If chrome is Default browser it would be launched straight away, If not system dialog will be seen to make chrome as default)
This can be reproduced with short cut key(CTRL+P) and wrench --> Print.
Nov 9, 2012
#15 vitalyb...@chromium.org
Thanks. Reproduced. It's not clear yet why it does not work. PDF plugin seems working in metro mode. 

As quick fix we can disable preview and use system dialog (Ctrl+Shit+P).

Status: Assigned
Nov 9, 2012
#16 mad@chromium.org
It's working for Stable/Beta? Why did it stop working in M24?

And sorry about my comment for the entry point, I remember now that this is when PDF is not installed, we go straight to OS printing which brings up the charm... And I was testing with Tip of tree without PDF...

Nov 9, 2012
#17 pbommana@chromium.org
Here is the Bisect:

Good build : 24.0.1308.0
Broken Build : 24.0.1309.0

Change log : http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/trunk/src&range=164268:164521&mode=html
Labels: -Type-Bug Type-Regression
Nov 9, 2012
#18 bauerb@chromium.org
Interestingly enough, the plug-in *is* available in working for regular PDFs in Metro mode, but when we try to load it in print preview, some of the custom methods on the plug-in object seem to be missing (see https://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/browser/resources/print_preview/previewarea/preview_area.js&exact_package=chromium&type=cs&l=325)
Labels: Feature-Plugins Feature-Plugins-Pepper
Nov 9, 2012
#19 vitalyb...@chromium.org
If we have no ideas, I'll try bisect to particular CL next week.

BTW. I have installed canary and see "Run in Windows8 Mode in menu", but it does nothing. Is this expected?
Nov 9, 2012
#20 gideonw...@chromium.org
Unfortunately yes :/. Canary can't be set as your default browser, and browsers have to be default to run in Metro. We could remove the option just for Canary, but haven't gotten around to it yet.
Nov 9, 2012
#21 bauerb@chromium.org
Argh, I think I know what's happening here. We override the plug-in for print preview so that it's always enabled (https://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/browser/printing/print_preview_tab_controller.cc&exact_package=chromium&l=62), but we override it with a WebPluginInfo that claims to be NPAPI, and NPAPI is not supported in Metro mode.
Owner: bauerb@chromium.org
Cc: vitalyb...@chromium.org jam@chromium.org
Nov 9, 2012
#23 bauerb@chromium.org
That's part of it, but the most recent change that triggered this was https://chromiumcodereview.appspot.com/11066043.
Nov 13, 2012
#25 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=167524

------------------------------------------------------------------------
r167524 | wez@chromium.org | 2012-11-14T00:29:11.455779Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/browser_with_test_window_test.h?r1=167524&r2=167523&pathrev=167524
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc?r1=167524&r2=167523&pathrev=167524
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller_unittest.cc?r1=167524&r2=167523&pathrev=167524
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller.cc?r1=167524&r2=167523&pathrev=167524

Revert 167487 - Get full WebPluginInfo for the PDF plug-in before enabling it for print preview.

This CL coincided with the DuplicateTab test starting to fail due to a prior
test failing to unregister a window class; the addition of the AtExitManager
could potentially be the cause.  See crbug.com/160862.

BUG=159902

Review URL: https://chromiumcodereview.appspot.com/11364202

TBR=bauerb@chromium.org
Review URL: https://codereview.chromium.org/11312223
------------------------------------------------------------------------
Nov 14, 2012
#26 pbommana@chromium.org
 Issue 160042  has been merged into this issue.
Nov 15, 2012
#27 bauerb@chromium.org
 Issue 160128  has been merged into this issue.
Cc: fsam...@chromium.org ibra...@gmail.com
Nov 16, 2012
#28 ligim...@chromium.org
 Issue 158192  has been merged into this issue.
Cc: mbo...@chromium.org
Nov 17, 2012
#29 ligim...@chromium.org
 Issue 160923  has been merged into this issue.
Nov 19, 2012
#30 dhar...@google.com
bauerb: will the change be landing again soon?
Nov 27, 2012
#31 dhar...@google.com
The change is still under review - https://codereview.chromium.org/11417003/
Nov 28, 2012
#32 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=169938

------------------------------------------------------------------------
r169938 | bauerb@chromium.org | 2012-11-28T14:45:46.440931Z

Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_test.cc?r1=169938&r2=169937&pathrev=169938
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_test.h?r1=169938&r2=169937&pathrev=169938
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/browser_with_test_window_test.h?r1=169938&r2=169937&pathrev=169938
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/win/window_impl.cc?r1=169938&r2=169937&pathrev=169938
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc?r1=169938&r2=169937&pathrev=169938
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_tests_unit.gypi?r1=169938&r2=169937&pathrev=169938
   M http://src.chromium.org/viewvc/chrome/trunk/src/ui/base/win/window_impl.h?r1=169938&r2=169937&pathrev=169938
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller_unittest.cc?r1=169938&r2=169937&pathrev=169938
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/printing/print_preview_tab_controller.cc?r1=169938&r2=169937&pathrev=169938

Reland r167487: Get full WebPluginInfo for the PDF plug-in before enabling it for print preview.

Previous review: http://codereview.chromium.org/11364202/

TBR=thestig@chromium.org
BUG=159902,113008

Review URL: https://chromiumcodereview.appspot.com/11417003
------------------------------------------------------------------------
Nov 29, 2012
#33 dhar...@google.com
This is part of 25.0.1338.0. Please verify the fix.
Labels: Merge-Requested
Nov 30, 2012
#34 ligim...@chromium.org
Print Preview works fine in current canary - 25.0.1342.0 ( Official Build 170408)
Labels: QA-Verified
Nov 30, 2012
#35 dhar...@google.com
(No comment was entered for this change.)
Labels: -Merge-Requested Merge-Approved
Dec 2, 2012
#36 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=170690

------------------------------------------------------------------------
r170690 | bauerb@chromium.org | 2012-12-02T18:20:15.900582Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/test/base/browser_with_test_window_test.h?r1=170690&r2=170689&pathrev=170690
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/ui/base/win/window_impl.cc?r1=170690&r2=170689&pathrev=170690
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc?r1=170690&r2=170689&pathrev=170690
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/ui/base/win/window_impl.h?r1=170690&r2=170689&pathrev=170690
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/browser/printing/print_preview_tab_controller_unittest.cc?r1=170690&r2=170689&pathrev=170690
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/chrome_tests.gypi?r1=170690&r2=170689&pathrev=170690
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/browser/printing/print_preview_tab_controller.cc?r1=170690&r2=170689&pathrev=170690
   A http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/browser/printing/print_preview_test.cc?r1=170690&r2=170689&pathrev=170690
   A http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/browser/printing/print_preview_test.h?r1=170690&r2=170689&pathrev=170690

Merge r169938: Reland r167487: Get full WebPluginInfo for the PDF plug-in before enabling it for print preview.

Previous review: http://codereview.chromium.org/11364202/

TBR=thestig@chromium.org
BUG=159902,113008

Review URL: https://chromiumcodereview.appspot.com/11417003


Conflicts:

	chrome/chrome_tests_unit.gypi

Review URL: https://codereview.chromium.org/11316300
------------------------------------------------------------------------
Labels: -Merge-Approved merge-merged-1312
Dec 3, 2012
#37 dhar...@google.com
(No comment was entered for this change.)
Status: Fixed
Dec 4, 2012
#38 pavanv@chromium.org
verified that print preview is available in windows 8 mode.
Status: Verified
Mar 9, 2013
#39 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Type-Regression -Area-UI -Mstone-24 -Feature-PrintPreview -Feature-Plugins -Feature-Plugins-Pepper Type-Bug-Regression Cr-Content-Plugins Cr-UI M-24 Cr-Content-Plugins-Pepper Cr-UI-Browser-PrintPreview
Apr 5, 2013
#40 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: Cr-Blink
Apr 5, 2013
#41 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Cr-Content-Plugins Cr-Internals-Plugins
Apr 5, 2013
#42 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Cr-Content-Plugins-Pepper Cr-Internals-Plugins-Pepper
Aug 30, 2013
#43 ricle...@gmail.com
Forgive me if this is the wrong place to ask, but how are you managing to bypass the system charm print dialog from withing the metro application?  I thought that was a hard WinRT restriction.
Sep 3, 2013
#44 cpu@chromium.org
@43, default metro browsers are a special category of application. When in metro API restrictions are not enforced, by the same token they can't be distributed in the store. Sort of a hybrid between a regular metro app and a regular desktop app.


Sign in to add a comment

Powered by Google Project Hosting