My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 159156: Some texts in a Website Settings popup are trimmed.
6 people starred this issue and may be notified of changes. Back to list
 
Project Member Reported by yusukes@chromium.org, Nov 2, 2012
OS: Chrome OS lumpy

Google Chrome	24.0.1305.4 (Official Build 164971) dev
Platform	3083.2.0 (Official Build) dev-channel lumpy
WebKit	537.16 (@132013)
JavaScript	V8 3.14.5

What steps will reproduce the problem?

1. Switch the UI language to Japanese.
2. Go to an online banking site. eg. http://www.mizuhobank.co.jp/direct/start.html
3. Click the green area in Omnibox

What is the expected output? What do you see instead?

Actual:
Some texts are trimmed and cannot verify if it's a legitimate site.


Please use labels and text to provide additional information.

I believe the popup should be resized depending on the current UI locale.

Screenshot 2012-11-02 at 09.48.22 - Edited.png
15.0 KB   View   Download
Screenshot 2012-11-02 at 09.48.22.png
202 KB   View   Download
Nov 2, 2012
#1 yusukes@chromium.org
"cannot verify" was probably too strong. But I felt a bit anxious and stopped using the site. I guess it's not just me.


Nov 6, 2012
#2 Kusc...@chromium.org
This may be all OS - does this repro on WIn and Mac?

Jeff, who built this UI?
Cc: jeffr...@chromium.org
Nov 6, 2012
#3 jeffr...@google.com
these guys!
Cc: nepper@chromium.org markushe...@chromium.org
Nov 7, 2012
#4 markushe...@chromium.org
(No comment was entered for this change.)
Status: Assigned
Owner: markushe...@chromium.org
Nov 7, 2012
#5 markushe...@chromium.org
A CL is on the way to fix this.
Status: Started
Labels: -Mstone-25 Mstone-24 ReleaseBlock-Stable
Nov 8, 2012
#6 markushe...@chromium.org
(No comment was entered for this change.)
Cc: dub...@chromium.org
Nov 8, 2012
#7 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=166748

------------------------------------------------------------------------
r166748 | markusheintz@chromium.org | 2012-11-08T20:43:48.066700Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc?r1=166748&r2=166747&pathrev=166748

[Views] Set the width of the Website Settings UI dynamically based on the size of the Permissions Tab contents.


BUG=159156

Review URL: https://chromiumcodereview.appspot.com/11362134
------------------------------------------------------------------------
Nov 9, 2012
#8 mbo...@chromium.org
Verified on 25.0.1321.0 canary for Chrome OS & Win7. Text doesn't get trimmed. Fix works as expected. QA is signing off this fix to be merged to M24.
Cc: mbo...@chromium.org dhar...@chromium.org
Nov 9, 2012
#9 dhar...@google.com
(No comment was entered for this change.)
Labels: Merge-Approved
Nov 12, 2012
#10 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=167202

------------------------------------------------------------------------
r167202 | markusheintz@chromium.org | 2012-11-12T17:17:51.885497Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc?r1=167202&r2=167201&pathrev=167202

Merge 166748 - [Views] Set the width of the Website Settings UI dynamically based on the size of the Permissions Tab contents.


BUG=159156

Review URL: https://chromiumcodereview.appspot.com/11362134

TBR=markusheintz@chromium.org
Review URL: https://codereview.chromium.org/11363197
------------------------------------------------------------------------
Labels: -Merge-Approved merge-merged-1312
Nov 12, 2012
#11 dhar...@chromium.org
(No comment was entered for this change.)
Status: Fixed
Nov 13, 2012
#12 song...@chromium.org
Verified, chrome25.0.1324.0 (Official Build 167303) dev/ChromeOS 3196.0.0 - lumpy
Status: Verified
Nov 22, 2012
#13 markushe...@chromium.org
The fix for this issue was merged to M24. I'd like to get this into M23 as well.
Status: Started
Labels: -Mstone-24 Mstone-23 Merge-Requested
Nov 22, 2012
#14 markushe...@chromium.org
(No comment was entered for this change.)
Summary: Some texts in a Website Settings popup are trimmed.
Nov 22, 2012
#15 markushe...@chromium.org
(No comment was entered for this change.)
Blocking: chromium:162367
Nov 22, 2012
#16 markushe...@chromium.org
(No comment was entered for this change.)
Labels: OS-Windows
Nov 22, 2012
#17 markushe...@chromium.org
Issue 162369 has been merged into this issue.
Nov 27, 2012
#18 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=169678

------------------------------------------------------------------------
r169678 | dubroy@chromium.org | 2012-11-27T17:22:27.328257Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/website_settings_bubble_controller.h?r1=169678&r2=169677&pathrev=169678
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/website_settings_bubble_controller_unittest.mm?r1=169678&r2=169677&pathrev=169678
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/website_settings_bubble_controller.mm?r1=169678&r2=169677&pathrev=169678

[Mac] Website settings: Enlarge window when permission strings are too long.

The website settings window was using a fixed width. This was fine for most
text since it would wrap, but the permissions can't wrap, so the window should
be made wide enough to fit the largest permission string.

BUG=159156

Review URL: https://codereview.chromium.org/11417082
------------------------------------------------------------------------
Dec 3, 2012
#19 dhar...@google.com
do we need to merge r169678 in M24?
Dec 3, 2012
#20 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=170836

------------------------------------------------------------------------
r170836 | karen@chromium.org | 2012-12-03T23:12:02.331012Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1271/src/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc?r1=170836&r2=170835&pathrev=170836

Merge 166748
> [Views] Set the width of the Website Settings UI dynamically based on the size of the Permissions Tab contents.
> 
> 
> BUG=159156
> 
> Review URL: https://chromiumcodereview.appspot.com/11362134

TBR=markusheintz@chromium.org
Review URL: https://codereview.chromium.org/11316319
------------------------------------------------------------------------
Labels: merge-merged-1271
Dec 4, 2012
#21 dub...@chromium.org
Karen, can we merge the Mac fix (https://src.chromium.org/viewvc/chrome?view=rev&revision=169678) into M24?
Dec 4, 2012
#22 markushe...@chromium.org
@Patrick: I think Dharani is managing the M24 branch.

@Dharani: I changed the label from Mstone 23 to Mstone 24.
We would love to merge CL https://codereview.chromium.org/11417082 to M24. The CL fixes the issue for Mac OS X. As far as we know the CL did not cause any trouble on canary.

Thanks a lot :)


Labels: -Mstone-23 Mstone-24
Dec 4, 2012
#23 dhar...@google.com
(No comment was entered for this change.)
Labels: -Merge-Requested Merge-Approved
Dec 5, 2012
#24 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=171259

------------------------------------------------------------------------
r171259 | markusheintz@chromium.org | 2012-12-05T18:37:39.368177Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/browser/ui/cocoa/website_settings_bubble_controller_unittest.mm?r1=171259&r2=171258&pathrev=171259

Merge 169678
> [Mac] Website settings: Enlarge window when permission strings are too long.
> 
> The website settings window was using a fixed width. This was fine for most
> text since it would wrap, but the permissions can't wrap, so the window should
> be made wide enough to fit the largest permission string.
> 
> BUG=159156
> 
> Review URL: https://codereview.chromium.org/11417082

TBR=dubroy@chromium.org
Review URL: https://codereview.chromium.org/11445020
------------------------------------------------------------------------
Labels: -Merge-Approved
Dec 5, 2012
#25 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=171268

------------------------------------------------------------------------
r171268 | markusheintz@chromium.org | 2012-12-05T19:06:19.133127Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/browser/ui/cocoa/website_settings_bubble_controller.h?r1=171268&r2=171267&pathrev=171268
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/browser/ui/cocoa/website_settings_bubble_controller.mm?r1=171268&r2=171267&pathrev=171268

Merge 169678
> [Mac] Website settings: Enlarge window when permission strings are too long.
> 
> The website settings window was using a fixed width. This was fine for most
> text since it would wrap, but the permissions can't wrap, so the window should
> be made wide enough to fit the largest permission string.
> 
> BUG=159156
> 
> Review URL: https://codereview.chromium.org/11417082

TBR=dubroy@chromium.org
Review URL: https://codereview.chromium.org/11446012
------------------------------------------------------------------------
Dec 5, 2012
#26 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=171275

------------------------------------------------------------------------
r171275 | dharani@google.com | 2012-12-05T19:18:57.386906Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/browser/ui/cocoa/website_settings_bubble_controller_unittest.mm?r1=171275&r2=171274&pathrev=171275

Revert 171259
> Merge 169678
> > [Mac] Website settings: Enlarge window when permission strings are too long.
> > 
> > The website settings window was using a fixed width. This was fine for most
> > text since it would wrap, but the permissions can't wrap, so the window should
> > be made wide enough to fit the largest permission string.
> > 
> > BUG=159156
> > 
> > Review URL: https://codereview.chromium.org/11417082
> 
> TBR=dubroy@chromium.org
> Review URL: https://codereview.chromium.org/11445020

TBR=markusheintz@chromium.org
Review URL: https://codereview.chromium.org/11443018
------------------------------------------------------------------------
Dec 5, 2012
#27 dhar...@google.com
(No comment was entered for this change.)
Status: Fixed
Dec 5, 2012
#28 pbommana@chromium.org
Verified the fix with latest M23(23.0.1271.97)on windows 7.
Attached screenshot for reference.
Certificate.png
77.2 KB   View   Download
Dec 5, 2012
#29 pbommana@chromium.org
Also verified on Lumpy with chrome 23.0.1271.97.
Dec 6, 2012
#30 pbommana@chromium.org
(No comment was entered for this change.)
Status: Verified
Dec 10, 2012
#31 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=172030

------------------------------------------------------------------------
r172030 | dubroy@chromium.org | 2012-12-10T10:49:12.860837Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/branches/1312/src/chrome/browser/ui/cocoa/website_settings_bubble_controller_unittest.mm?r1=172030&r2=172029&pathrev=172030

Merge 171259
> Merge 169678
> > [Mac] Website settings: Enlarge window when permission strings are too long.
> > 
> > The website settings window was using a fixed width. This was fine for most
> > text since it would wrap, but the permissions can't wrap, so the window should
> > be made wide enough to fit the largest permission string.
> > 
> > BUG=159156
> > 
> > Review URL: https://codereview.chromium.org/11417082
> 
> TBR=dubroy@chromium.org
> Review URL: https://codereview.chromium.org/11445020

TBR=markusheintz@chromium.org
Review URL: https://codereview.chromium.org/11488006
------------------------------------------------------------------------
Mar 10, 2013
#32 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Area-UI -Mstone-24 -Feature-I18N Cr-UI M-24 Cr-UI-I18N
Mar 20, 2013
#33 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Cr-UI-I18N Cr-UI-Internationalization
Jul 24, 2013
#34 lafo...@google.com
(No comment was entered for this change.)
Cc: -jeffr...@chromium.org
Sign in to add a comment

Powered by Google Project Hosting