| Issue 15845: | need bookmark bar overflow chevron | |
| 6 people starred this issue and may be notified of changes. | Back to list |
Sign in to add a comment
|
Chrome Version :3.0.191.0 (Official Build 19705) OS + version : Ubuntu 8.04 CPU architecture (32-bit / 64-bit): 64-bit window manager : Gnome 2.22.3 URLs (if applicable) : Behavior in Firefox 3.x (if applicable): Behavior in Chrome for Windows (optional): What steps will reproduce the problem? 1. Create a few bookmarks in the bookmarks folder so that some will not fit in the bar view What is the expected result? There should be a >> in the bookmarks bar to expand the list of bookmarks What happens instead? Nothing. No way to get to the bookmarks that do not fit in the bookmarks bar view. Please provide any additional information below. Attach a screenshot and backtrace if possible. |
||||||||||||||||||||||
,
Jul 02, 2009
well, it's not exactly true there's *no way*, as the bookmark manager will let you access them
Summary: need bookmark bar overflow chevron
Status: Available Owner: --- Cc: est...@chromium.org e...@chromium.org Labels: -Size-Medium Pri-2 Size-Small Mstone-LinuxBeta |
|||||||||||||||||||||||
,
Jul 02, 2009
I meant no way to get to the other bookmarks from the bookmarks menu. |
|||||||||||||||||||||||
,
Jul 17, 2009
(No comment was entered for this change.)
Labels: -Size-Small Size-Medium
|
|||||||||||||||||||||||
,
Jul 31, 2009
(No comment was entered for this change.)
Status: Assigned
Owner: jhawk...@chromium.org |
|||||||||||||||||||||||
,
Sep 01, 2009
If we used a GtkToolbar we could _set_show_arrow() to get this, but I guess that might not work right with our theme. http://library.gnome.org/devel/gtk/unstable/GtkToolbar.html |
|||||||||||||||||||||||
,
Sep 01, 2009
IIRC, we do use a GtkToolbar, and only for the content that could overflow... |
|||||||||||||||||||||||
,
Sep 01, 2009
yep. I'm looking at it right now, for some reason that call isn't working. In the process of investigating... |
|||||||||||||||||||||||
,
Sep 01, 2009
ok, wth, this doesn't work as a standalone program (see attachment)
|
|||||||||||||||||||||||
,
Sep 01, 2009
d'oh, apparently we need to make "proxy menu items" for the tool items. Dang it! |
|||||||||||||||||||||||
,
Sep 01, 2009
(No comment was entered for this change.)
Status: Started
Owner: est...@chromium.org |
|||||||||||||||||||||||
,
Sep 01, 2009
Rearranging bugs to eliminate LinuxBeta label.
Labels: -Mstone-LinuxBeta ReleaseBlock-Beta Mstone-4
|
|||||||||||||||||||||||
,
Sep 02, 2009
(No comment was entered for this change.)
Status: Fixed
|
|||||||||||||||||||||||
,
Sep 02, 2009
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=25200
------------------------------------------------------------------------
r25200 | estade@chromium.org | 2009-09-02 11:10:09 -0700 (Wed, 02 Sep 2009) | 9 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc?r1=25200&r2=25199
M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h?r1=25200&r2=25199
GTK: Implement the bookmark bar chevron.
I didn't use the native GtkToolbar version of this because, as usual, GTK doesn't give us enough flexibility to do what we want. But it wasn't too hard or super hacky to re-implement it.
The chromium version (and hence the Windows version) looks bad. This is not my fault. I don't know why it points right rather than down, when the menu pops down, not to the right. This is why I used a down arrow for the GTK version rather than matching with a right arrow.
BUG=15845
Review URL: http://codereview.chromium.org/187001
------------------------------------------------------------------------
|
|||||||||||||||||||||||
| ► Sign in to add a comment | |||||||||||||||||||||||
