My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 157721: Shorten incognito NTP text
8 people starred this issue and may be notified of changes. Back to list
 
Project Member Reported by nyquist@chromium.org, Oct 24, 2012
The text on the incognito NTP for Android is just as long as on desktop. However, we already have a shortened version of this string.

Basically, this requires using IDS_NEW_TAB_OTR_MESSAGE_MOBILE instead of IDS_NEW_TAB_OTR_MESSAGE.

It was added here:
http://codereview.chromium.org/9585021
Oct 24, 2012
#1 srika...@chromium.org
Is this m/master only as it seems to be using the strings in m/m18
Status: Available
Oct 24, 2012
#2 nyquist@chromium.org
This would be for all branches. However, in practice it would only be for the next Chrome for Android release.

On m/m18 we are using a long version of the NTP text, but in a mobile version (ie. search/replace computer with mobile).
Oct 24, 2012
#3 nyquist@chromium.org
(No comment was entered for this change.)
Blocking: chromium:114964
Oct 25, 2012
#4 migu...@chromium.org
This looks like a great bug to get Tim started on m/25 
Owner: timvolod...@chromium.org
Oct 25, 2012
#5 srika...@chromium.org
Thanks Miguel - but we should be doing this in the context of a large effort on  issue 114964 . Probably better for Tim to start looking into bugs on OWP/Text Autosizing. 
Owner: ---
Cc: timvolod...@chromium.org
Labels: ReleaseBlock-Dev
Nov 13, 2012
#6 cra...@chromium.org
(No comment was entered for this change.)
Status: Started
Owner: cra...@chromium.org
Nov 14, 2012
#7 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=167855

------------------------------------------------------------------------
r167855 | cramya@chromium.org | 2012-11-15T04:39:39.748167Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/webui/ntp/ntp_resource_cache_android.cc?r1=167855&r2=167854&pathrev=167855

Update the incognito NTP text for android to use the shorter version.

BUG=157721


Review URL: https://chromiumcodereview.appspot.com/11362240
------------------------------------------------------------------------
Nov 26, 2012
#8 cra...@chromium.org
(No comment was entered for this change.)
Status: Fixed
Mar 9, 2013
#9 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Feature-Incognito -Type-Polish -Mstone-25 -Area-UI Cr-UI-Polish Cr-UI-Browser-Incognito Type-Bug Cr-UI M-25
Sign in to add a comment

Powered by Google Project Hosting