My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 156025: Maintain a ring buffer for about:tracing so it can keep open and not OOM
3 people starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  dsinclair@chromium.org
Closed:  Mar 2013
Cc:  nd...@chromium.org, chrome-p...@google.com


Sign in to add a comment
 
Project Member Reported by willchan@chromium.org, Oct 15, 2012
I want to keep tracing enabled so I can repro a bug that only happens intermittently. Once it happens, I want to stop tracing and then examine the trace to see what happened.
Oct 15, 2012
#1 nd...@chromium.org
Love it. We've talked about this a ton of times but never found cycles to hack it up. I *think* it should be straightforward. If you can find someone with coding cycles, I'm happy to hand hold etc.
Status: Available
Labels: Feature-DevTools-Tracing
Feb 1, 2013
#2 dsinclair@chromium.org
(No comment was entered for this change.)
Status: Started
Owner: dsinclair@chromium.org
Feb 22, 2013
#3 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=184258

------------------------------------------------------------------------
r184258 | dsinclair@chromium.org | 2013-02-23T02:09:53.822009Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/components/tracing/child_trace_message_filter.cc?r1=184258&r2=184257&pathrev=184258
   M http://src.chromium.org/viewvc/chrome/trunk/src/components/tracing/child_trace_message_filter.h?r1=184258&r2=184257&pathrev=184258
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tracing/trace_message_filter.cc?r1=184258&r2=184257&pathrev=184258
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/test/trace_event_analyzer_unittest.cc?r1=184258&r2=184257&pathrev=184258
   M http://src.chromium.org/viewvc/chrome/trunk/src/components/tracing/tracing_messages.h?r1=184258&r2=184257&pathrev=184258
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tracing/trace_message_filter.h?r1=184258&r2=184257&pathrev=184258
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/base/tracing.cc?r1=184258&r2=184257&pathrev=184258
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/debug/trace_event_unittest.cc?r1=184258&r2=184257&pathrev=184258
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/devtools/devtools_tracing_handler.cc?r1=184258&r2=184257&pathrev=184258
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/app/content_main_runner.cc?r1=184258&r2=184257&pathrev=184258
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/devtools/devtools_tracing_handler.h?r1=184258&r2=184257&pathrev=184258
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tracing/trace_controller_impl.cc?r1=184258&r2=184257&pathrev=184258
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/app/android/library_loader_hooks.cc?r1=184258&r2=184257&pathrev=184258
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tracing/trace_controller_impl.h?r1=184258&r2=184257&pathrev=184258
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/tracing/tracing_ui.cc?r1=184258&r2=184257&pathrev=184258
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/automation/automation_provider.cc?r1=184258&r2=184257&pathrev=184258
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/browser/trace_controller.h?r1=184258&r2=184257&pathrev=184258
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/debug/trace_event_impl.cc?r1=184258&r2=184257&pathrev=184258
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/debug/trace_event_impl.h?r1=184258&r2=184257&pathrev=184258
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/android/tracing_intent_handler.cc?r1=184258&r2=184257&pathrev=184258

Add a mode flag to the tracing framework.

The mode is provided when SetEnabled is called. Currently there
is only one mode which is the trace until buffer is full mode.

We will be adding a continuous tracing mode which this will support.

BUG=156025


Review URL: https://chromiumcodereview.appspot.com/12302036
------------------------------------------------------------------------
Mar 10, 2013
#4 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Stability-Performance Performance
Mar 13, 2013
#5 nd...@chromium.org
(No comment was entered for this change.)
Labels: -Feature-DevTools-Tracing Cr-Platform-DevTools-Tracing
Mar 15, 2013
#6 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=188505

------------------------------------------------------------------------
r188505 | dsinclair@chromium.org | 2013-03-15T23:28:44.007380Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/debug/trace_event_unittest.cc?r1=188505&r2=188504&pathrev=188505
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/devtools/devtools_tracing_handler.cc?r1=188505&r2=188504&pathrev=188505
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/debug/trace_event_impl.cc?r1=188505&r2=188504&pathrev=188505
   M http://src.chromium.org/viewvc/chrome/trunk/src/base/debug/trace_event_impl.h?r1=188505&r2=188504&pathrev=188505

Update tracing framework to optionally use a ringbuffer.

This updates the code to allow passing a continuous_tracing option into the trace framework. When enabled a ringbuffer will be used for event storage instead of a simple vector.

The continuous_tracing option will allow us to trace for longer periods of time without needing to worry that we'll stop tracing before hitting the event we're looking for.

BUG=156025


Review URL: https://chromiumcodereview.appspot.com/12096115
------------------------------------------------------------------------
Mar 19, 2013
#7 dsinclair@chromium.org
The code for the ringbuffer is all submitted, just needs a DEPS roll to include https://code.google.com/p/trace-viewer/source/detail?r=223 to have all the pieces in place.

nduca, would you be able to do the DEPS roll for me?
Mar 20, 2013
#8 dsinclair@chromium.org
(No comment was entered for this change.)
Cc: nd...@chromium.org
Mar 20, 2013
#9 nd...@chromium.org
You should be able to roll deps, just edit src/DEPS and look for trace-viewer string. Put up a CL to bump to a newer version and I'll rubber stamp.
Mar 22, 2013
#10 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=189856

------------------------------------------------------------------------
r189856 | dsinclair@chromium.org | 2013-03-22T18:27:03.293426Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/DEPS?r1=189856&r2=189855&pathrev=189856

Bump trace viewer dep to r223.

This pulls in the continuous tracing code from trace-viewer.

BUG=156025

Review URL: https://codereview.chromium.org/12990003
------------------------------------------------------------------------
Mar 22, 2013
#11 dsinclair@chromium.org
(No comment was entered for this change.)
Status: Fixed
Labels: M-27
Sign in to add a comment

Powered by Google Project Hosting