My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 155330: Upstream ModalDialogTest
6 people starred this issue and may be notified of changes. Back to list
 
Project Member Reported by klundberg@chromium.org, Oct 11, 2012
We should upstream ModalDialogTest and de-flake the flaky test in it.

The one tricky piece is the handling of events since event handling is different upstream (at least if we are upstreaming to ContentShell, not sure about ChromeTestShell).
Oct 11, 2012
#1 yfriedman@chromium.org
This needs to live in ChromeTestShell as the native code that drives it is in chrome/
Oct 11, 2012
#2 vino...@chromium.org
(No comment was entered for this change.)
Status: Available
Oct 23, 2012
#3 klundberg@chromium.org
I'll try to take a look at this.
Status: Started
Owner: klundberg@chromium.org
Oct 23, 2012
#4 srika...@chromium.org
(No comment was entered for this change.)
Labels: ReleaseBlock-Dev
Oct 30, 2012
#5 srika...@chromium.org
(No comment was entered for this change.)
Labels: Area-Internals
Oct 30, 2012
#6 klundberg@chromium.org
We need the right resources to be available in order to upstream ModalDialogTest so marking this blocked on 136704.
Blockedon: chromium:136704
Nov 7, 2012
#7 yfriedman@chromium.org
(No comment was entered for this change.)
Labels: -MStone-24 Mstone-25
Nov 16, 2012
#8 yfriedman@chromium.org
(No comment was entered for this change.)
Status: av
Labels: Hotlist-Android-TestingFixit
Nov 19, 2012
#9 klundberg@chromium.org
(No comment was entered for this change.)
Status: Assigned
Nov 27, 2012
#10 lafo...@google.com
(No comment was entered for this change.)
Labels: Project-Refresh
Dec 3, 2012
#11 vino...@chromium.org
(No comment was entered for this change.)
Labels: -ReleaseBlock-Dev
Dec 5, 2012
#12 klundberg@chromium.org
I'm pretty swamped so marking this available in case somebody else has the time to look at this.
Status: Available
Owner: ---
Cc: klundberg@chromium.org
Jan 4, 2013
#13 aruslan@chromium.org
(No comment was entered for this change.)
Status: Started
Jan 4, 2013
#14 aruslan@chromium.org
(No comment was entered for this change.)
Owner: aruslan@chromium.org
Jan 7, 2013
#15 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=175429

------------------------------------------------------------------------
r175429 | aruslan@chromium.org | 2013-01-08T00:31:12.863915Z

Changed paths:
   A http://src.chromium.org/viewvc/chrome/trunk/src/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewClientWrapper.java?r1=175429&r2=175428&pathrev=175429
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/public/android/java/src/org/chromium/content/browser/ContentView.java?r1=175429&r2=175428&pathrev=175429
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/android/java/src/org/chromium/chrome/browser/TabObserver.java?r1=175429&r2=175428&pathrev=175429
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java?r1=175429&r2=175428&pathrev=175429
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/android/java/src/org/chromium/chrome/browser/TabBase.java?r1=175429&r2=175428&pathrev=175429
   A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/android/javatests/src/org/chromium/chrome/browser/test/util/TabBaseUtils.java?r1=175429&r2=175428&pathrev=175429
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellActivity.java?r1=175429&r2=175428&pathrev=175429
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/android/testshell/javatests/src/org/chromium/chrome/testshell/ChromiumTestShellTestBase.java?r1=175429&r2=175428&pathrev=175429
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/android/testshell/java/src/org/chromium/chrome/testshell/TestShellToolbar.java?r1=175429&r2=175428&pathrev=175429

JavascriptAppModalDialog tests and necessary infrastructure.

BUG=155330


Review URL: https://chromiumcodereview.appspot.com/11778005
------------------------------------------------------------------------
Jan 7, 2013
#16 bugdro...@chromium.org
Project: .../internal/apps
Branch : master
Author : Ruslan Abdikeev <aruslan@chromium.org>
Commit : 8c64ed94976fdf0e206fbab6469539bb9c0a9af6

Code Review +2: Ruslan Abdikeev
Verified    +1: Ruslan Abdikeev
Change-Id     : I6e448752acd637801accf746d5cbe0531f2ef7b6
Reviewed-at   : https://gerrit-int.chromium.org/30645
Jan 7, 2013
#17 aruslan@chromium.org
(No comment was entered for this change.)
Status: Fixed
Jan 9, 2013
#18 srika...@chromium.org
(No comment was entered for this change.)
Labels: -Project-Refresh nomerge
Mar 9, 2013
#19 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Mstone-25 -Type-Cleanup -Area-Internals Cr-Internals Type-Bug M-25
Sign in to add a comment

Powered by Google Project Hosting