My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 153961: [Fullscreen magnifier] Change keyboard shortcut from [CTRL + brightness keys] to [CTRL + ALT + brightness keys]
1 person starred this issue and may be notified of changes. Back to list
 
Project Member Reported by kenjibaheux@chromium.org, Oct 3, 2012
Current situation:
 - Keyboard shortcut is using CTRL (CTRL + brightness keys)
 - Mouse shortcut is using ALT (ALT + 2 fingers gesture)

Both keyboard and mouse shortcuts for the fullscreen magnifier should use the same key modifier (better when fine tuning the magnifier level, consistent).

We have agreed to use ALT:
 - ALT+brightness keys = alternate meaning of brightness keys
 - as opposed to CTRL+brightness keys = still controlling brightness?!
Oct 4, 2012
#1 kenjibaheux@chromium.org
(No comment was entered for this change.)
Blocking: chromium:154003
Oct 4, 2012
#2 yoshiki@chromium.org
(No comment was entered for this change.)
Status: Started
Oct 4, 2012
#3 kenjibaheux@chromium.org
(No comment was entered for this change.)
Blocking: chromium:154239
Oct 4, 2012
#4 kenjibaheux@chromium.org
There is an shortcut clash. Let me reach out to the team member using the ALT + Brightness shortcut to see if we can swap.
Labels: Action-FeedbackNeeded
Oct 4, 2012
#5 kenjibaheux@chromium.org
OK the shortcut clash could not be resolved, let's use CTRL + ALT + brightness keys.
Sorry again for the confusion.
Summary: [Fullscreen magnifier] Change keyboard shortcut from [CTRL + brightness keys] to [CTRL + ALT + brightness keys]
Labels: -Action-FeedbackNeeded
Oct 5, 2012
#6 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=160353

------------------------------------------------------------------------
r160353 | yoshiki@chromium.org | 2012-10-05T12:47:56.482089Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ash/magnifier/magnification_controller.cc?r1=160353&r2=160352&pathrev=160353

Screen Magnifier: Change keyboard shortcut from [ALT + Scroll] to [CTRL + ALT + Scroll]

BUG=153961
TEST=manual
TBR=sky@chromium.org
# TRBing for a simple change.

Review URL: https://chromiumcodereview.appspot.com/11026062
------------------------------------------------------------------------
Oct 8, 2012
#7 yoshiki@chromium.org
(No comment was entered for this change.)
Labels: Iteration-66
Oct 8, 2012
#8 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=160776

------------------------------------------------------------------------
r160776 | yoshiki@chromium.org | 2012-10-09T02:45:42.063876Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ash/accelerators/accelerator_table.cc?r1=160776&r2=160775&pathrev=160776

Screen Magnifier: Change keyboard shortcut from [CTRL + brightness] to [CTRL + ALT + brightness]

BUG=153961

Review URL: https://chromiumcodereview.appspot.com/11035051
------------------------------------------------------------------------
Oct 8, 2012
#9 yoshiki@chromium.org
(No comment was entered for this change.)
Status: Fixed
Oct 10, 2012
#10 yoshiki@chromium.org
I'm found a problem. On Developer mode, [Ctrl + Alt + Fn] shortcut keys are hooked by X11 layer and [CTRL + ALT + brightness] doesn't work. We have to disable the hooking in X11 layer.

And I'll make the patch reverted for a while until X11 layer problem is solved.
Status: Started
Oct 10, 2012
#11 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=161073

------------------------------------------------------------------------
r161073 | yoshiki@chromium.org | 2012-10-10T07:35:15.900644Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ash/accelerators/accelerator_table.cc?r1=161073&r2=161072&pathrev=161073

Revert 160776 - Screen Magnifier: Change keyboard shortcut from [CTRL + brightness] to [CTRL + ALT + brightness]

On Developer mode, [Ctrl + Alt + Fn] shortcut keys are hooked by X11 layer and [CTRL + ALT + brightness] doesn't work.
This patch will be reverted for a while until X11 layer is solved.

BUG=153961

Review URL: https://chromiumcodereview.appspot.com/11035051

TBR=yoshiki@chromium.org
Review URL: https://codereview.chromium.org/11088053
------------------------------------------------------------------------
Oct 15, 2012
#12 sato...@chromium.org
(No comment was entered for this change.)
Labels: Iteration-67
Oct 22, 2012
#13 yoshiki@chromium.org
(No comment was entered for this change.)
Blockedon: chromium-os:153961
Oct 22, 2012
#14 sato...@chromium.org
(No comment was entered for this change.)
Labels: -Pri-2 Pri-1
Oct 24, 2012
#15 bugdro...@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=163797

------------------------------------------------------------------------
r163797 | yoshiki@chromium.org | 2012-10-24T09:06:52.119685Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/ash/accelerators/accelerator_table.cc?r1=163797&r2=163796&pathrev=163797

Screen Magnifier: Change keyboard shortcut from [CTRL + brightness] to [CTRL + ALT + brightness]

BUG=153961

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160776

Review URL: https://chromiumcodereview.appspot.com/11035051
------------------------------------------------------------------------
Oct 28, 2012
#16 sato...@chromium.org
punting to m25
Labels: -Mstone-24 mstone-25
Oct 28, 2012
#17 sato...@chromium.org
(No comment was entered for this change.)
Labels: Iteration-68
Oct 29, 2012
#18 bugdro...@chromium.org
Project: chromiumos/platform/login_manager
Branch : master
Author : yoshiki iguchi <yoshiki@chromium.org>
Commit : 828faf082f41b17ec64b59d91e4f2ecf3fec2e85

Code Review +2: Daniel Erat
Verified    +1: Yoshiki IGUCHI
Change-Id     : Ica7e32e2206c2b3e9e4410dd493d8ff2e719068f
Reviewed-at   : https://gerrit.chromium.org/gerrit/36315

Use -maxvt flag to disable VT switching.

BUG=chromium:153961, chromium-os:35606
TEST=manual

M  xstart.sh
Cc: chrome-...@google.com
Nov 7, 2012
#20 nhu...@chromium.org
There was no keyboard shortcut when trying [CTRL + brightness] or [CTRL + ALT + brightness].
Please advise what the expected behaviour is. Thanks.
Device: Lumpy
Chrome/OS: 25.0.1315.1 / 3156.0.0
Cc: rohi...@chromium.org
Nov 9, 2012
#21 kenjibaheux@chromium.org
Currently, you need to enable the magnifier in chrome://settings advanced->accessibility

Nov 9, 2012
#22 bugdro...@chromium.org
Project  : chromiumos/overlays/chromiumos-overlay
Branch   : master
Author   : Yoshiki Iguchi <yoshiki@google.com>
Committer: Gerrit <chrome-bot@google.com>
Commit   : 299014fd5baef408b82a82056a447367fd0d5d86

Code Review +2: Daniel Erat
Verified    +1: Yoshiki IGUCHI
Change-Id     : I69224a519adf1575493ad726917a1ab2e024548c
Reviewed-at   : https://gerrit.chromium.org/gerrit/37610

Remove the unnecessary patch to disable VT switching.

This patch is no longer used because it is replaced by another patch
(commit de991af7).

BUG=chromium:153961
TEST=manual

D  x11-base/xorg-server/files/1.9.3-disable-vt-switching-for-verified-boot.patch
D  x11-base/xorg-server/xorg-server-1.12.4-r3.ebuild
A  x11-base/xorg-server/xorg-server-1.12.4-r4.ebuild
Nov 13, 2012
#23 bugdro...@chromium.org
Project: chromiumos/platform/login_manager
Branch : master
Author : Yoshiki Iguchi <yoshiki@google.com>
Commit : 4b1d03da128778003963856d521b9e300328355e

Code Review +2: Seigo Nonaka
Verified    +1: Yoshiki IGUCHI
Change-Id     : Id35aa5cb9c98cc1e4c7e782fb64a1005a286ca1d
Reviewed-at   : https://gerrit.chromium.org/gerrit/37815

Add the comment about use of the duplicated logic.

BUG=chromium:153961, chromium-os:35606
TEST=none

M  xstart.sh
Nov 13, 2012
#24 bugdro...@chromium.org
Project: chromiumos/platform/init
Branch : master
Author : Yoshiki Iguchi <yoshiki@google.com>
Commit : 62c0618c97857d90e1d4423016768047387a2ca1

Code Review +2: Richard Barnette
Verified    +1: Yoshiki IGUCHI
Change-Id     : I557b2074424a9cfac8d43bb071dece796760a0a5
Reviewed-at   : https://gerrit.chromium.org/gerrit/37816

Removes the code to create and remove allow-vt-switching flag file.

This CL also adds the comment about use of the duplicated logic.

BUG=chromium:153961, chromium-os:35606
TEST=none

M  hotkey-access.conf
Nov 13, 2012
#25 bugdro...@chromium.org
Project: chromiumos/overlays/chromiumos-overlay
Branch : master
Author : Daniel Kurtz <djkurtz@chromium.org>
Commit : 88de4259c05f6b5d6df15a155142b62072ad5b58

Code Review +2: Daniel Kurtz, Yoshiki IGUCHI
Verified    +1: Daniel Kurtz
Change-Id     : Ie30a3b83405e132a8361dd712cfc71cb82cf4e4d
Reviewed-at   : https://gerrit.chromium.org/gerrit/37813

x11-base/xorg-server: Convert add-maxvt patch to git diff

For ease of maintenance, regenerate the patch using git format-patch

Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>

BUG=chromium:153961
TEST=builds clean

M  x11-base/xorg-server/files/1.12.0-add-maxvt-flag.patch
Nov 20, 2012
#26 ka...@chromium.org
Verifying that Ctrl+Alt+brightness keys are the Fullscreen magnifier keyboard control.

Google Chrome   25.0.1330.0 (Official Build 168752) dev
Platform        3236.0.0 (Official Build) dev-channel 
Status: Verified
Mar 9, 2013
#27 bugdro...@chromium.org
(No comment was entered for this change.)
Labels: -Type-Polish -Area-UI -Feature-Accessibility -mstone-25 Cr-UI-Accessibility Cr-UI-Polish Cr-UI Type-Bug M-25
Sign in to add a comment

Powered by Google Project Hosting